| Message ID | 20231101102257.1232179-2-vincent.knecht@mailoo.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote: > Document AK7345 bindings. The commit message should mention why this device is incompatible with the 7375. Something like "Document the ak7345 voice coil motor actuator. Similar to the ak7375, this model has 4 unilateral phase detractors instead of 8." Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> > --- > .../devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml > index 22a810fc7222..fe312cc6a873 100644 > --- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml > @@ -15,7 +15,9 @@ description: > > properties: > compatible: > - const: asahi-kasei,ak7375 > + enum: > + - asahi-kasei,ak7345 > + - asahi-kasei,ak7375 > > reg: > maxItems: 1 > -- > 2.41.0 > > >
Le mercredi 01 novembre 2023 à 15:10 +0000, Conor Dooley a écrit : > On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote: > > Document AK7345 bindings. > > The commit message should mention why this device is incompatible with > the 7375. Something like > > "Document the ak7345 voice coil motor actuator. Similar to the ak7375, > this model has 4 unilateral phase detractors instead of 8." > > Otherwise, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor. Thank you for the review! I don't know anything about phase detractors, nor any other details (having found no datasheets for either of these ICs) apart what could be infered from vendor/downstream drivers like in the commit text for patch 3/3... So I guess I'll send a v2 with a commit text along these lines : Document AK7345 bindings. Compared to AK7375, it has only 9 bits position values (instead of 12), 20 ms power-up delay (instead of 10), and no known standby register setting.
On Wed, Nov 01, 2023 at 04:29:20PM +0100, Vincent Knecht wrote: > Le mercredi 01 novembre 2023 à 15:10 +0000, Conor Dooley a écrit : > > On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote: > > > Document AK7345 bindings. > > > > The commit message should mention why this device is incompatible with > > the 7375. Something like > > > > "Document the ak7345 voice coil motor actuator. Similar to the ak7375, > > this model has 4 unilateral phase detractors instead of 8." > > > > Otherwise, > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > Cheers, > > Conor. > > Thank you for the review! > > I don't know anything about phase detractors, nor any other details hah, that was just me putting techobabble in the example text rather than using foo. See also: https://www.youtube.com/watch?v=RXJKdh1KZ0w > (having found no datasheets for either of these ICs) > apart what could be infered from vendor/downstream drivers > like in the commit text for patch 3/3... > > So I guess I'll send a v2 with a commit text along these lines : > Document AK7345 bindings. > Compared to AK7375, it has only 9 bits position values (instead of 12), > 20 ms power-up delay (instead of 10), and no known standby register setting. Yah, that is the exact sort of information that is good to have, thanks.
diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml index 22a810fc7222..fe312cc6a873 100644 --- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml @@ -15,7 +15,9 @@ description: properties: compatible: - const: asahi-kasei,ak7375 + enum: + - asahi-kasei,ak7345 + - asahi-kasei,ak7375 reg: maxItems: 1
Document AK7345 bindings. Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org> --- .../devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)