| Message ID | 20231031072124.201181-2-Delphine_CC_Chiu@Wiwynn.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | LTC4286 and LTC4287 driver support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Oct 31, 2023 at 03:21:21PM +0800, Delphine CC Chiu wrote: > Add a device tree bindings for ltc4286 device. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > Changelog: > v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable > v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6 > - Add type for adi,vrange-select-25p6 > - Revise rsense-micro-ohms to shunt-resistor-micro-ohms > --- > .../bindings/hwmon/lltc,ltc4286.yaml | 52 +++++++++++++++++++ > MAINTAINERS | 10 ++++ > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > new file mode 100644 > index 000000000000..4695bca77c05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LTC4286 power monitors > + > +maintainers: > + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > + > +properties: > + compatible: > + enum: > + - lltc,ltc4286 > + - lltc,ltc4287 > + > + reg: > + maxItems: 1 > + > + adi,vrange-low-enable: > + description: > + This property is a bool parameter to represent the > + voltage range is 25.6 volts or 102.4 volts for > + this chip. > + The default is 102.4 volts. You've got weird wrapping of text here (short lines). Either this property or the corollary work for me, depending on what Guenter wants. With two nits below, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > + type: boolean > + > + shunt-resistor-micro-ohms: > + description: > + Resistor value in micro-Ohm micro-ohms > + > +required: > + - compatible > + - reg > + - shunt-resistor-micro-ohms > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + power-sensor@40 { the generic node name is "power-monitor". Cheers, Conor.
On 10/31/23 10:06, Conor Dooley wrote: > On Tue, Oct 31, 2023 at 03:21:21PM +0800, Delphine CC Chiu wrote: >> Add a device tree bindings for ltc4286 device. >> >> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> >> >> Changelog: >> v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable >> v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6 >> - Add type for adi,vrange-select-25p6 >> - Revise rsense-micro-ohms to shunt-resistor-micro-ohms >> --- >> .../bindings/hwmon/lltc,ltc4286.yaml | 52 +++++++++++++++++++ >> MAINTAINERS | 10 ++++ >> 2 files changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml >> >> diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml >> new file mode 100644 >> index 000000000000..4695bca77c05 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: LTC4286 power monitors >> + >> +maintainers: >> + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> >> + >> +properties: >> + compatible: >> + enum: >> + - lltc,ltc4286 >> + - lltc,ltc4287 >> + >> + reg: >> + maxItems: 1 >> + >> + adi,vrange-low-enable: >> + description: >> + This property is a bool parameter to represent the >> + voltage range is 25.6 volts or 102.4 volts for >> + this chip. >> + The default is 102.4 volts. > > You've got weird wrapping of text here (short lines). Either this > property or the corollary work for me, depending on what Guenter > wants. With two nits below, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Oh, I am tired of arguing, so I'll accept whatever gets a Reviewed-by: tag from a DT maintainer (people do a pretty good job of wearing me down lately). Guenter
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Wednesday, November 1, 2023 1:06 AM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com> > Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter Roeck > <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>; > Jonathan Corbet <corbet@lwn.net>; linux-i2c@vger.kernel.org; > linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org > Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver > bindings > > On Tue, Oct 31, 2023 at 03:21:21PM +0800, Delphine CC Chiu wrote: > > Add a device tree bindings for ltc4286 device. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > > > Changelog: > > v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable > > v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6 > > - Add type for adi,vrange-select-25p6 > > - Revise rsense-micro-ohms to shunt-resistor-micro-ohms > > --- > > .../bindings/hwmon/lltc,ltc4286.yaml | 52 > +++++++++++++++++++ > > MAINTAINERS | 10 ++++ > > 2 files changed, 62 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > new file mode 100644 > > index 000000000000..4695bca77c05 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LTC4286 power monitors > > + > > +maintainers: > > + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > + > > +properties: > > + compatible: > > + enum: > > + - lltc,ltc4286 > > + - lltc,ltc4287 > > + > > + reg: > > + maxItems: 1 > > + > > + adi,vrange-low-enable: > > + description: > > + This property is a bool parameter to represent the > > + voltage range is 25.6 volts or 102.4 volts for > > + this chip. > > + The default is 102.4 volts. > > You've got weird wrapping of text here (short lines). Either this property or the > corollary work for me, depending on what Guenter wants. With two nits > below, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> We will revise to adi,vrange-low-enable: description: This property is a bool parameter to represent the voltage range is 25.6 volts or 102.4 volts for this chip. > > > > + type: boolean > > + > > + shunt-resistor-micro-ohms: > > + description: > > + Resistor value in micro-Ohm > > micro-ohms We will revise to micro-ohms > > > + > > +required: > > + - compatible > > + - reg > > + - shunt-resistor-micro-ohms > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + power-sensor@40 { > > the generic node name is "power-monitor". We will revise to power-monitor@40 > > Cheers, > Conor.
diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml new file mode 100644 index 000000000000..4695bca77c05 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LTC4286 power monitors + +maintainers: + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> + +properties: + compatible: + enum: + - lltc,ltc4286 + - lltc,ltc4287 + + reg: + maxItems: 1 + + adi,vrange-low-enable: + description: + This property is a bool parameter to represent the + voltage range is 25.6 volts or 102.4 volts for + this chip. + The default is 102.4 volts. + type: boolean + + shunt-resistor-micro-ohms: + description: + Resistor value in micro-Ohm + +required: + - compatible + - reg + - shunt-resistor-micro-ohms + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + power-sensor@40 { + compatible = "lltc,ltc4286"; + reg = <0x40>; + adi,vrange-low-enable; + shunt-resistor-micro-ohms = <300>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 55d9d860f1a7..c60e29dc04ad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12489,6 +12489,16 @@ S: Maintained F: Documentation/hwmon/ltc4261.rst F: drivers/hwmon/ltc4261.c +LTC4286 HARDWARE MONITOR DRIVER +M: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> +L: linux-i2c@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml +F: Documentation/devicetree/bindings/hwmon/ltc4286.rst +F: drivers/hwmon/pmbus/Kconfig +F: drivers/hwmon/pmbus/Makefile +F: drivers/hwmon/pmbus/ltc4286.c + LTC4306 I2C MULTIPLEXER DRIVER M: Michael Hennerich <michael.hennerich@analog.com> L: linux-i2c@vger.kernel.org
Add a device tree bindings for ltc4286 device. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> Changelog: v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6 - Add type for adi,vrange-select-25p6 - Revise rsense-micro-ohms to shunt-resistor-micro-ohms --- .../bindings/hwmon/lltc,ltc4286.yaml | 52 +++++++++++++++++++ MAINTAINERS | 10 ++++ 2 files changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml