| Message ID | 20231016155547.2973853-1-robh@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | ASoC: dt-bindings: tas5805m: Disallow undefined properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Oct 16, 2023 at 10:55:47AM -0500, Rob Herring wrote: > Device specific bindings should not allow undefined properties. This is > accomplished in json-schema with 'additionalProperties: false'. > > Examples should be last in the schema, so move additionalProperties up > while we're here. > > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/tas5805m.yaml b/Documentation/devicetree/bindings/sound/tas5805m.yaml > index 63edf52f061c..12c41974274e 100644 > --- a/Documentation/devicetree/bindings/sound/tas5805m.yaml > +++ b/Documentation/devicetree/bindings/sound/tas5805m.yaml > @@ -37,6 +37,8 @@ properties: > generated from TI's PPC3 tool. > $ref: /schemas/types.yaml#/definitions/string > > +additionalProperties: false > + > examples: > - | > i2c { > @@ -52,5 +54,4 @@ examples: > ti,dsp-config-name = "mono_pbtl_48khz"; > }; > }; > - > -additionalProperties: true > +... > -- > 2.42.0 > >
On Tue, Oct 17, 2023 at 11:50:42AM +0100, Conor Dooley wrote: > On Mon, Oct 16, 2023 at 10:55:47AM -0500, Rob Herring wrote: > > Device specific bindings should not allow undefined properties. This is > > accomplished in json-schema with 'additionalProperties: false'. > > > > Examples should be last in the schema, so move additionalProperties up > > while we're here. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Rob, I don't have the original patch for this. It looks like whatever email troubles you were having are persisting - if there's anything else you've sent me I'm just unawaere of it.
On Mon, 16 Oct 2023 10:55:47 -0500, Rob Herring wrote: > Device specific bindings should not allow undefined properties. This is > accomplished in json-schema with 'additionalProperties: false'. > > Examples should be last in the schema, so move additionalProperties up > while we're here. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: tas5805m: Disallow undefined properties commit: 086357275fc7635c5a2856c667b3d2f7604403fa All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/tas5805m.yaml b/Documentation/devicetree/bindings/sound/tas5805m.yaml index 63edf52f061c..12c41974274e 100644 --- a/Documentation/devicetree/bindings/sound/tas5805m.yaml +++ b/Documentation/devicetree/bindings/sound/tas5805m.yaml @@ -37,6 +37,8 @@ properties: generated from TI's PPC3 tool. $ref: /schemas/types.yaml#/definitions/string +additionalProperties: false + examples: - | i2c { @@ -52,5 +54,4 @@ examples: ti,dsp-config-name = "mono_pbtl_48khz"; }; }; - -additionalProperties: true +...
Device specific bindings should not allow undefined properties. This is accomplished in json-schema with 'additionalProperties: false'. Examples should be last in the schema, so move additionalProperties up while we're here. Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)