| Message ID | 20231004161038.2818327-6-gregory.clement@bootlin.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for the Mobileye EyeQ5 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 4/10/23 18:10, Gregory CLEMENT wrote: > The MIPS Warrior I-class I6500 was announced by Imagination > Technologies in 2016 and is used in the Mobileye SoC EyeQ5. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > --- > Documentation/devicetree/bindings/mips/cpus.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote: > The MIPS Warrior I-class I6500 was announced by Imagination > Technologies in 2016 and is used in the Mobileye SoC EyeQ5. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > --- > Documentation/devicetree/bindings/mips/cpus.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml > index cf382dea3922..87fd2842ba68 100644 > --- a/Documentation/devicetree/bindings/mips/cpus.yaml > +++ b/Documentation/devicetree/bindings/mips/cpus.yaml > @@ -39,6 +39,7 @@ properties: > - mti,mips24KEc > - mti,mips14KEc > - mti,mips14Kc > + - mti,i6500 Since the CPU core vendor is Imagination Technologies thus it would be more appropriate to have the "img," prefix. Wouldn't it? -Serge(y) > > reg: > maxItems: 1 > -- > 2.40.1 >
On Wed, Oct 4, 2023 at 6:15 PM Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > > The MIPS Warrior I-class I6500 was announced by Imagination > Technologies in 2016 and is used in the Mobileye SoC EyeQ5. > > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > --- > Documentation/devicetree/bindings/mips/cpus.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Hello Serge(y), > On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote: >> The MIPS Warrior I-class I6500 was announced by Imagination >> Technologies in 2016 and is used in the Mobileye SoC EyeQ5. >> >> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> >> --- >> Documentation/devicetree/bindings/mips/cpus.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml >> index cf382dea3922..87fd2842ba68 100644 >> --- a/Documentation/devicetree/bindings/mips/cpus.yaml >> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml >> @@ -39,6 +39,7 @@ properties: >> - mti,mips24KEc >> - mti,mips14KEc >> - mti,mips14Kc > >> + - mti,i6500 > > Since the CPU core vendor is Imagination Technologies thus it would > be more appropriate to have the "img," prefix. Wouldn't it? According to Documentation/devicetree/bindings/vendor-prefixes.yaml "^mti,.*": description: Imagination Technologies Ltd. (formerly MIPS Technologies Inc.) So I think it's OK. Gregory > > -Serge(y) > >> >> reg: >> maxItems: 1 >> -- >> 2.40.1 >>
On Thu, Oct 05, 2023 at 04:51:50PM +0200, Gregory CLEMENT wrote: > Hello Serge(y), > > > On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote: > >> The MIPS Warrior I-class I6500 was announced by Imagination > >> Technologies in 2016 and is used in the Mobileye SoC EyeQ5. > >> > >> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > >> --- > >> Documentation/devicetree/bindings/mips/cpus.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml > >> index cf382dea3922..87fd2842ba68 100644 > >> --- a/Documentation/devicetree/bindings/mips/cpus.yaml > >> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml > >> @@ -39,6 +39,7 @@ properties: > >> - mti,mips24KEc > >> - mti,mips14KEc > >> - mti,mips14Kc > > > >> + - mti,i6500 > > > > Since the CPU core vendor is Imagination Technologies thus it would > > be more appropriate to have the "img," prefix. Wouldn't it? > > According to Documentation/devicetree/bindings/vendor-prefixes.yaml > > "^mti,.*": > description: Imagination Technologies Ltd. (formerly MIPS > Technologies Inc.) Yes, "mti" is also marked as Imagination Technologies Ltd, but I doubt we should use "mti" prefix for something what has been developed after Image Tech acquired MIPS Tech. What is the point in having the "img," prefix then? Rob, your opinion? -Serge(y) > > So I think it's OK. > > Gregory > > > > > -Serge(y) > > > >> > >> reg: > >> maxItems: 1 > >> -- > >> 2.40.1 > >> > > -- > Gregory Clement, Bootlin > Embedded Linux and Kernel engineering > http://bootlin.com
On Thu, Oct 5, 2023, at 16:51, Gregory CLEMENT wrote: >> On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote: >>> The MIPS Warrior I-class I6500 was announced by Imagination >>> Technologies in 2016 and is used in the Mobileye SoC EyeQ5. >>> >>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> >>> --- >>> Documentation/devicetree/bindings/mips/cpus.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml >>> index cf382dea3922..87fd2842ba68 100644 >>> --- a/Documentation/devicetree/bindings/mips/cpus.yaml >>> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml >>> @@ -39,6 +39,7 @@ properties: >>> - mti,mips24KEc >>> - mti,mips14KEc >>> - mti,mips14Kc >> >>> + - mti,i6500 >> >> Since the CPU core vendor is Imagination Technologies thus it would >> be more appropriate to have the "img," prefix. Wouldn't it? > > According to Documentation/devicetree/bindings/vendor-prefixes.yaml > > "^mti,.*": > description: Imagination Technologies Ltd. (formerly MIPS > Technologies Inc.) > > So I think it's OK. I don't see any good solution, they changed their name and ownership too many times. I would actually revert back the description here to "MIPS Technologies Inc" instead of trying to keep track of what they currently call themselves. Since we already have both the 'mips,' and 'mti,' vendow names for the 14Kc, 14KEc and 24KEc parts, maybe we can just go back to 'mips,' for all cores past the mti era rather than trying to date and geolocate each of the classic cores as one of 'mti', 'img', 'wavecomp', 'tallwood', 'mips' 'cipunited' etc. Arnd
On Fri, Oct 06, 2023 at 12:48:03PM +0200, Arnd Bergmann wrote: > On Thu, Oct 5, 2023, at 16:51, Gregory CLEMENT wrote: > >> On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote: > >>> The MIPS Warrior I-class I6500 was announced by Imagination > >>> Technologies in 2016 and is used in the Mobileye SoC EyeQ5. > >>> > >>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > >>> --- > >>> Documentation/devicetree/bindings/mips/cpus.yaml | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml > >>> index cf382dea3922..87fd2842ba68 100644 > >>> --- a/Documentation/devicetree/bindings/mips/cpus.yaml > >>> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml > >>> @@ -39,6 +39,7 @@ properties: > >>> - mti,mips24KEc > >>> - mti,mips14KEc > >>> - mti,mips14Kc > >> > >>> + - mti,i6500 > >> > >> Since the CPU core vendor is Imagination Technologies thus it would > >> be more appropriate to have the "img," prefix. Wouldn't it? > > > > According to Documentation/devicetree/bindings/vendor-prefixes.yaml > > > > "^mti,.*": > > description: Imagination Technologies Ltd. (formerly MIPS > > Technologies Inc.) > > > > So I think it's OK. > > I don't see any good solution, they changed their name and > ownership too many times. I would actually revert back the > description here to "MIPS Technologies Inc" instead of trying > to keep track of what they currently call themselves. > > Since we already have both the 'mips,' and 'mti,' vendow > names for the 14Kc, 14KEc and 24KEc parts, maybe we can > just go back to 'mips,' for all cores past the mti era > rather than trying to date and geolocate each of the > classic cores as one of 'mti', 'img', 'wavecomp', 'tallwood', > 'mips' 'cipunited' etc. I would reserve 'mips' for anything common. Much like 'riscv' is only for things based on RiscV specs/standards. I would use 'img' here if we know this was designed/implemented by Imagination. Rob
Rob Herring <robh@kernel.org> writes: > On Fri, Oct 06, 2023 at 12:48:03PM +0200, Arnd Bergmann wrote: >> On Thu, Oct 5, 2023, at 16:51, Gregory CLEMENT wrote: >> >> On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote: >> >>> The MIPS Warrior I-class I6500 was announced by Imagination >> >>> Technologies in 2016 and is used in the Mobileye SoC EyeQ5. >> >>> >> >>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> >> >>> --- >> >>> Documentation/devicetree/bindings/mips/cpus.yaml | 1 + >> >>> 1 file changed, 1 insertion(+) >> >>> >> >>> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml >> >>> index cf382dea3922..87fd2842ba68 100644 >> >>> --- a/Documentation/devicetree/bindings/mips/cpus.yaml >> >>> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml >> >>> @@ -39,6 +39,7 @@ properties: >> >>> - mti,mips24KEc >> >>> - mti,mips14KEc >> >>> - mti,mips14Kc >> >> >> >>> + - mti,i6500 >> >> >> >> Since the CPU core vendor is Imagination Technologies thus it would >> >> be more appropriate to have the "img," prefix. Wouldn't it? >> > >> > According to Documentation/devicetree/bindings/vendor-prefixes.yaml >> > >> > "^mti,.*": >> > description: Imagination Technologies Ltd. (formerly MIPS >> > Technologies Inc.) >> > >> > So I think it's OK. >> >> I don't see any good solution, they changed their name and >> ownership too many times. I would actually revert back the >> description here to "MIPS Technologies Inc" instead of trying >> to keep track of what they currently call themselves. >> >> Since we already have both the 'mips,' and 'mti,' vendow >> names for the 14Kc, 14KEc and 24KEc parts, maybe we can >> just go back to 'mips,' for all cores past the mti era >> rather than trying to date and geolocate each of the >> classic cores as one of 'mti', 'img', 'wavecomp', 'tallwood', >> 'mips' 'cipunited' etc. > > I would reserve 'mips' for anything common. Much like 'riscv' is only > for things based on RiscV specs/standards. > > I would use 'img' here if we know this was designed/implemented by > Imagination. If there is no objection I will use 'img' then. Gregory > > Rob
On Mon, Oct 9, 2023, at 17:32, Gregory CLEMENT wrote: > Rob Herring <robh@kernel.org> writes: >> On Fri, Oct 06, 2023 at 12:48:03PM +0200, Arnd Bergmann wrote: >>> On Thu, Oct 5, 2023, at 16:51, Gregory CLEMENT wrote: >>> >>> I don't see any good solution, they changed their name and >>> ownership too many times. I would actually revert back the >>> description here to "MIPS Technologies Inc" instead of trying >>> to keep track of what they currently call themselves. >>> >>> Since we already have both the 'mips,' and 'mti,' vendow >>> names for the 14Kc, 14KEc and 24KEc parts, maybe we can >>> just go back to 'mips,' for all cores past the mti era >>> rather than trying to date and geolocate each of the >>> classic cores as one of 'mti', 'img', 'wavecomp', 'tallwood', >>> 'mips' 'cipunited' etc. >> >> I would reserve 'mips' for anything common. Much like 'riscv' is only >> for things based on RiscV specs/standards. >> >> I would use 'img' here if we know this was designed/implemented by >> Imagination. > > If there is no objection I will use 'img' then. Ok, let's do that then. With this modification: Acked-by: Arnd Bergmann <arnd@arndb.de>
On Mon, Oct 09, 2023 at 05:32:57PM +0200, Gregory CLEMENT wrote: > Rob Herring <robh@kernel.org> writes: > > > On Fri, Oct 06, 2023 at 12:48:03PM +0200, Arnd Bergmann wrote: > >> On Thu, Oct 5, 2023, at 16:51, Gregory CLEMENT wrote: > >> >> On Wed, Oct 04, 2023 at 06:10:32PM +0200, Gregory CLEMENT wrote: > >> >>> The MIPS Warrior I-class I6500 was announced by Imagination > >> >>> Technologies in 2016 and is used in the Mobileye SoC EyeQ5. > >> >>> > >> >>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> > >> >>> --- > >> >>> Documentation/devicetree/bindings/mips/cpus.yaml | 1 + > >> >>> 1 file changed, 1 insertion(+) > >> >>> > >> >>> diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml > >> >>> index cf382dea3922..87fd2842ba68 100644 > >> >>> --- a/Documentation/devicetree/bindings/mips/cpus.yaml > >> >>> +++ b/Documentation/devicetree/bindings/mips/cpus.yaml > >> >>> @@ -39,6 +39,7 @@ properties: > >> >>> - mti,mips24KEc > >> >>> - mti,mips14KEc > >> >>> - mti,mips14Kc > >> >> > >> >>> + - mti,i6500 > >> >> > >> >> Since the CPU core vendor is Imagination Technologies thus it would > >> >> be more appropriate to have the "img," prefix. Wouldn't it? > >> > > >> > According to Documentation/devicetree/bindings/vendor-prefixes.yaml > >> > > >> > "^mti,.*": > >> > description: Imagination Technologies Ltd. (formerly MIPS > >> > Technologies Inc.) > >> > > >> > So I think it's OK. > >> > >> I don't see any good solution, they changed their name and > >> ownership too many times. I would actually revert back the > >> description here to "MIPS Technologies Inc" instead of trying > >> to keep track of what they currently call themselves. > >> > >> Since we already have both the 'mips,' and 'mti,' vendow > >> names for the 14Kc, 14KEc and 24KEc parts, maybe we can > >> just go back to 'mips,' for all cores past the mti era > >> rather than trying to date and geolocate each of the > >> classic cores as one of 'mti', 'img', 'wavecomp', 'tallwood', > >> 'mips' 'cipunited' etc. > > > > I would reserve 'mips' for anything common. Much like 'riscv' is only > > for things based on RiscV specs/standards. > > > > I would use 'img' here if we know this was designed/implemented by > > Imagination. > > If there is no objection I will use 'img' then. Sounds good. Thanks. Feel free to add then: Acked-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > > Gregory > > > > > Rob > > -- > Gregory Clement, Bootlin > Embedded Linux and Kernel engineering > http://bootlin.com
diff --git a/Documentation/devicetree/bindings/mips/cpus.yaml b/Documentation/devicetree/bindings/mips/cpus.yaml index cf382dea3922..87fd2842ba68 100644 --- a/Documentation/devicetree/bindings/mips/cpus.yaml +++ b/Documentation/devicetree/bindings/mips/cpus.yaml @@ -39,6 +39,7 @@ properties: - mti,mips24KEc - mti,mips14KEc - mti,mips14Kc + - mti,i6500 reg: maxItems: 1
The MIPS Warrior I-class I6500 was announced by Imagination Technologies in 2016 and is used in the Mobileye SoC EyeQ5. Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com> --- Documentation/devicetree/bindings/mips/cpus.yaml | 1 + 1 file changed, 1 insertion(+)