| Message ID | 20231002165957.11388-1-wsa+renesas@sang-engineering.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | arm64: dts: renesas: r8a77990: document Ebisu-4D support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 22 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Wolfram, On Mon, Oct 2, 2023 at 7:00 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Document properly that Ebisu-support includes the Ebisu-4D variant, so > there won't be confusion what happened with support for this board. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > @@ -302,7 +302,7 @@ properties: > - description: R-Car E3 (R8A77990) > items: > - enum: > - - renesas,ebisu # Ebisu (RTP0RC77990SEB0010S) > + - renesas,ebisu # Ebisu/Ebisu-4D (RTP0RC77990SEB0010S) Ebisu-4D has a different part number: RTP0RC77990SEB0020S. According to the schematics, the only difference is the presence of four DRAM chips ("4D") instead of two. The rest LGTM. Gr{oetje,eeting}s, Geert
On Mon, 02 Oct 2023 18:59:57 +0200, Wolfram Sang wrote: > Document properly that Ebisu-support includes the Ebisu-4D variant, so > there won't be confusion what happened with support for this board. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 +- > arch/arm64/boot/dts/renesas/ebisu.dtsi | 2 +- > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Geert,
> Ebisu-4D has a different part number: RTP0RC77990SEB0020S.
Oh, then the elinux wiki entry is at least vague [1]. I checked against
it and it says "This is the Wiki for the Renesas Ebisu (Ebisu-4D,
RTP0RC77990SEB0010S) board," which I read that the the 4D is 10S.
But I'll fix according to your information.
Thanks!
Wolfram
[1] https://elinux.org/R-Car/Boards/Ebisu
Hi Wolfram, On Wed, Oct 4, 2023 at 5:22 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > Ebisu-4D has a different part number: RTP0RC77990SEB0020S. > > Oh, then the elinux wiki entry is at least vague [1]. I checked against > it and it says "This is the Wiki for the Renesas Ebisu (Ebisu-4D, > RTP0RC77990SEB0010S) board," which I read that the the 4D is 10S. Yesterday, I checked the schematics. I guess I created the wiki page based on the DT bindings doc. > But I'll fix according to your information. Thanks! > [1] https://elinux.org/R-Car/Boards/Ebisu I updated the wiki page. Gr{oetje,eeting}s, Geert
diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml index 53b95f348f8e..af80358b5fd3 100644 --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml @@ -302,7 +302,7 @@ properties: - description: R-Car E3 (R8A77990) items: - enum: - - renesas,ebisu # Ebisu (RTP0RC77990SEB0010S) + - renesas,ebisu # Ebisu/Ebisu-4D (RTP0RC77990SEB0010S) - const: renesas,r8a77990 - description: R-Car D3 (R8A77995) diff --git a/arch/arm64/boot/dts/renesas/ebisu.dtsi b/arch/arm64/boot/dts/renesas/ebisu.dtsi index bbc29452d1be..f1a5778ef115 100644 --- a/arch/arm64/boot/dts/renesas/ebisu.dtsi +++ b/arch/arm64/boot/dts/renesas/ebisu.dtsi @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Device Tree Source for the Ebisu board + * Device Tree Source for the Ebisu/Ebisu-4D board * * Copyright (C) 2018 Renesas Electronics Corp. */ diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 9da0fd08f8c4..d5ac34a966f6 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Device Tree Source for the Ebisu board with R-Car E3 + * Device Tree Source for the Ebisu/Ebisu-4D board with R-Car E3 * * Copyright (C) 2018 Renesas Electronics Corp. */
Document properly that Ebisu-support includes the Ebisu-4D variant, so there won't be confusion what happened with support for this board. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 +- arch/arm64/boot/dts/renesas/ebisu.dtsi | 2 +- arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)