| Message ID | 20230929-pm7250b-gpio-fixup-v1-1-ef68543c1d3b@fairphone.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Small updates / fixups for PMIC spmi-gpio | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 16 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 29/09/2023 10:17, Luca Weiss wrote: > As per commit ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node > label for PMIC gpios") all dts files now use the plural _gpios instead > of the singular _gpio as label. Update the schema example also to match. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > index 55e931ba5b47..e4842e1fbd65 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > @@ -245,7 +245,7 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - pmi8998_gpio: gpio@c000 { > + pmi8998_gpios: gpio@c000 This does no make sense... you update label only here, but not in any user of it which proves that label is not used. If it is not used, it should be dropped, not changed... Best regards, Krzysztof
On Sat Sep 30, 2023 at 5:06 PM CEST, Krzysztof Kozlowski wrote: > On 29/09/2023 10:17, Luca Weiss wrote: > > As per commit ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node > > label for PMIC gpios") all dts files now use the plural _gpios instead > > of the singular _gpio as label. Update the schema example also to match. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > > index 55e931ba5b47..e4842e1fbd65 100644 > > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > > @@ -245,7 +245,7 @@ examples: > > #address-cells = <1>; > > #size-cells = <0>; > > > > - pmi8998_gpio: gpio@c000 { > > + pmi8998_gpios: gpio@c000 > > This does no make sense... you update label only here, but not in any > user of it which proves that label is not used. If it is not used, it > should be dropped, not changed... Okay, I will drop the label instead of updating it in v2. Regards Luca > > Best regards, > Krzysztof
On Mon, Oct 02, 2023 at 08:40:10AM +0200, Luca Weiss wrote: > On Sat Sep 30, 2023 at 5:06 PM CEST, Krzysztof Kozlowski wrote: > > On 29/09/2023 10:17, Luca Weiss wrote: > > > As per commit ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node > > > label for PMIC gpios") all dts files now use the plural _gpios instead > > > of the singular _gpio as label. Update the schema example also to match. > > > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > > --- > > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > > > index 55e931ba5b47..e4842e1fbd65 100644 > > > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > > > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > > > @@ -245,7 +245,7 @@ examples: > > > #address-cells = <1>; > > > #size-cells = <0>; > > > > > > - pmi8998_gpio: gpio@c000 { > > > + pmi8998_gpios: gpio@c000 > > > > This does no make sense... you update label only here, but not in any > > user of it which proves that label is not used. If it is not used, it > > should be dropped, not changed... > > Okay, I will drop the label instead of updating it in v2. Or just drop the patch and skip the trivial changes. If you want to fix unused labels, fix it for the whole subsystem (mfd) or treewide. Rob
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 55e931ba5b47..e4842e1fbd65 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -245,7 +245,7 @@ examples: #address-cells = <1>; #size-cells = <0>; - pmi8998_gpio: gpio@c000 { + pmi8998_gpios: gpio@c000 { compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; @@ -330,7 +330,7 @@ examples: }; }; - pm6150_gpio: gpio@c000 { + pm6150_gpios: gpio@c000 { compatible = "qcom,pm6150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller;
As per commit ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node label for PMIC gpios") all dts files now use the plural _gpios instead of the singular _gpio as label. Update the schema example also to match. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)