diff mbox series

[v3,2/2] dt-bindings: arm: sunxi: Add itead,iteaduino-plus-a20

Message ID 20230928165803.30127-2-julian.ribbeck@gmx.de
State Not Applicable
Headers show
Series None | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Julian Ribbeck Sept. 28, 2023, 4:57 p.m. UTC 
Add itead,iteaduino-plus-a20 bindings

Signed-off-by: Julian Ribbeck <julian.ribbeck@gmx.de>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
 1 file changed, 5 insertions(+)

--
2.42.0

Comments

Conor Dooley Sept. 29, 2023, 2:20 p.m. UTC | #1 
On Thu, Sep 28, 2023 at 06:57:02PM +0200, Julian Ribbeck wrote:
> Add itead,iteaduino-plus-a20 bindings
> 
> Signed-off-by: Julian Ribbeck <julian.ribbeck@gmx.de>

FYI, you missed a tag from Krzysztof
| Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
from https://lore.kernel.org/all/20230617205624.1178427-2-julian.ribbeck@gmx.de/

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index e4dd678f4212..25251ce4b60d 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -362,6 +362,11 @@ properties:
>            - const: itead,iteaduino-plus-a10
>            - const: allwinner,sun4i-a10
> 
> +      - description: Itead Iteaduino Plus A20
> +        items:
> +          - const: itead,iteaduino-plus-a20
> +          - const: allwinner,sun7i-a20
> +
>        - description: Jesurun Q5
>          items:
>            - const: jesurun,q5
> --
> 2.42.0
>
Jernej Škrabec Oct. 13, 2023, 7:18 p.m. UTC | #2 
Dne petek, 06. oktober 2023 ob 11:01:30 CEST je Julian Ribbeck napisal(a):
> Iteaduino Plus A20 is very similar to Iteaduino Plus A10. In fact it
> shares the same breakout board and the Itead Core A20 on top of it, is
> only adapted to support the dual-core A20.
> 
> This commits enables the following hardware:
> 
> * HDMI Video output
> * USB
> * SATA (untested due to lack of hardware I could attach)
> * Ethernet
> * MMC storage
> * UART
> * USB OTG (untested, because I don't own an USB OTG cable/device)
> 
> Signed-off-by: Julian Ribbeck <julian.ribbeck@gmx.de>
> ---
>  arch/arm/boot/dts/allwinner/Makefile          |   1 +
>  .../sun7i-a20-itead-iteaduino-plus.dts        | 104 ++++++++++++++++++
>  2 files changed, 105 insertions(+)
>  create mode 100644 arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts
> 
> diff --git a/arch/arm/boot/dts/allwinner/Makefile b/arch/arm/boot/dts/allwinner/Makefile
> index eebb5a0c873a..39af5ad94590 100644
> --- a/arch/arm/boot/dts/allwinner/Makefile
> +++ b/arch/arm/boot/dts/allwinner/Makefile
> @@ -124,6 +124,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
>  	sun7i-a20-haoyu-marsboard.dtb \
>  	sun7i-a20-hummingbird.dtb \
>  	sun7i-a20-itead-ibox.dtb \
> +	sun7i-a20-itead-iteaduino-plus.dts \

This should be .dtb.

Other than that:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

I'll fix it while applying.

For future reference, please follow proper patch submission procedure:
- each revision should be sent in separate thread
- each new revision should contain changelog, either in cover letter (when
there is more than one patch) or below --- line in each patch
- compatible description patch comes before first usage (I'll invert order
when applying)

Best regards,
Jernej

>  	sun7i-a20-i12-tvbox.dtb \
>  	sun7i-a20-icnova-a20-adb4006.dtb \
>  	sun7i-a20-icnova-swac.dtb \
> diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts
> new file mode 100644
> index 000000000000..c9f9b0275381
> --- /dev/null
> +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts
> @@ -0,0 +1,104 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +
> +/dts-v1/;
> +#include "sun7i-a20.dtsi"
> +#include "sunxi-itead-core-common.dtsi"
> +
> +/ {
> +	model = "Itead Iteaduino Plus A20";
> +	compatible = "itead,iteaduino-plus-a20", "allwinner,sun7i-a20";
> +
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +};
> +
> +&ac_power_supply {
> +	status = "okay";
> +};
> +
> +&ahci {
> +	target-supply = <&reg_ahci_5v>;
> +	status = "okay";
> +};
> +
> +&axp209 {
> +	interrupt-parent = <&nmi_intc>;
> +	interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +};
> +
> +&battery_power_supply {
> +	status = "okay";
> +};
> +
> +&codec {
> +	stauts = "okay";
> +};
> +
> +&de {
> +	status = "okay";
> +};
> +
> +&emac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&emac_pa_pins>;
> +	phy-handle = <&phy1>;
> +	status = "okay";
> +};
> +
> +&emac_sram {
> +	status = "okay";
> +};
> +
> +&hdmi {
> +	status = "okay";
> +};
> +
> +&hdmi_out {
> +	hdmi_out_con: endpoint {
> +		remote-endpoint = <&hdmi_con_in>;
> +	};
> +};
> +
> +&mdio {
> +	status = "okay";
> +
> +	phy1: ethernet-phy@1 {
> +		reg = <1>;
> +	};
> +};
> +
> +&mmc0 {
> +	vmmc-supply = <&reg_vcc3v3>;
> +	bus-width = <4>;
> +	cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */
> +	status = "okay";
> +};
> +
> +&otg_sram {
> +	status = "okay";
> +};
> +
> +&reg_ahci_5v {
> +	status = "okay";
> +};
> +
> +&reg_usb0_vbus {
> +	status = "okay";
> +};
> +
> +&usb_otg {
> +	status = "okay";
> +	dr_mode = "host";
> +};
> +
> +&usbphy {
> +	usb0_vbus-supply = <&reg_usb0_vbus>;
> +};
> --
> 2.42.0
> 
>
Jernej Škrabec Oct. 13, 2023, 7:21 p.m. UTC | #3 
Dne petek, 13. oktober 2023 ob 21:18:00 CEST je Jernej Škrabec napisal(a):
> Dne petek, 06. oktober 2023 ob 11:01:30 CEST je Julian Ribbeck napisal(a):
> > Iteaduino Plus A20 is very similar to Iteaduino Plus A10. In fact it
> > shares the same breakout board and the Itead Core A20 on top of it, is
> > only adapted to support the dual-core A20.
> > 
> > This commits enables the following hardware:
> > 
> > * HDMI Video output
> > * USB
> > * SATA (untested due to lack of hardware I could attach)
> > * Ethernet
> > * MMC storage
> > * UART
> > * USB OTG (untested, because I don't own an USB OTG cable/device)
> > 
> > Signed-off-by: Julian Ribbeck <julian.ribbeck@gmx.de>
> > ---
> >  arch/arm/boot/dts/allwinner/Makefile          |   1 +
> >  .../sun7i-a20-itead-iteaduino-plus.dts        | 104 ++++++++++++++++++
> >  2 files changed, 105 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts
> > 
> > diff --git a/arch/arm/boot/dts/allwinner/Makefile b/arch/arm/boot/dts/allwinner/Makefile
> > index eebb5a0c873a..39af5ad94590 100644
> > --- a/arch/arm/boot/dts/allwinner/Makefile
> > +++ b/arch/arm/boot/dts/allwinner/Makefile
> > @@ -124,6 +124,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> >  	sun7i-a20-haoyu-marsboard.dtb \
> >  	sun7i-a20-hummingbird.dtb \
> >  	sun7i-a20-itead-ibox.dtb \
> > +	sun7i-a20-itead-iteaduino-plus.dts \
> 
> This should be .dtb.
> 
> Other than that:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> 
> I'll fix it while applying.
> 
> For future reference, please follow proper patch submission procedure:
> - each revision should be sent in separate thread
> - each new revision should contain changelog, either in cover letter (when
> there is more than one patch) or below --- line in each patch
> - compatible description patch comes before first usage (I'll invert order
> when applying)

Sorry, I won't apply it as yet. How was this tested if it didn't even built due
to mistake in Makefile?

Best regards,
Jernej

> 
> Best regards,
> Jernej
> 
> >  	sun7i-a20-i12-tvbox.dtb \
> >  	sun7i-a20-icnova-a20-adb4006.dtb \
> >  	sun7i-a20-icnova-swac.dtb \
> > diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts
> > new file mode 100644
> > index 000000000000..c9f9b0275381
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-itead-iteaduino-plus.dts
> > @@ -0,0 +1,104 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +
> > +/dts-v1/;
> > +#include "sun7i-a20.dtsi"
> > +#include "sunxi-itead-core-common.dtsi"
> > +
> > +/ {
> > +	model = "Itead Iteaduino Plus A20";
> > +	compatible = "itead,iteaduino-plus-a20", "allwinner,sun7i-a20";
> > +
> > +	hdmi-connector {
> > +		compatible = "hdmi-connector";
> > +		type = "a";
> > +
> > +		port {
> > +			hdmi_con_in: endpoint {
> > +				remote-endpoint = <&hdmi_out_con>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> > +&ac_power_supply {
> > +	status = "okay";
> > +};
> > +
> > +&ahci {
> > +	target-supply = <&reg_ahci_5v>;
> > +	status = "okay";
> > +};
> > +
> > +&axp209 {
> > +	interrupt-parent = <&nmi_intc>;
> > +	interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > +};
> > +
> > +&battery_power_supply {
> > +	status = "okay";
> > +};
> > +
> > +&codec {
> > +	stauts = "okay";
> > +};
> > +
> > +&de {
> > +	status = "okay";
> > +};
> > +
> > +&emac {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&emac_pa_pins>;
> > +	phy-handle = <&phy1>;
> > +	status = "okay";
> > +};
> > +
> > +&emac_sram {
> > +	status = "okay";
> > +};
> > +
> > +&hdmi {
> > +	status = "okay";
> > +};
> > +
> > +&hdmi_out {
> > +	hdmi_out_con: endpoint {
> > +		remote-endpoint = <&hdmi_con_in>;
> > +	};
> > +};
> > +
> > +&mdio {
> > +	status = "okay";
> > +
> > +	phy1: ethernet-phy@1 {
> > +		reg = <1>;
> > +	};
> > +};
> > +
> > +&mmc0 {
> > +	vmmc-supply = <&reg_vcc3v3>;
> > +	bus-width = <4>;
> > +	cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */
> > +	status = "okay";
> > +};
> > +
> > +&otg_sram {
> > +	status = "okay";
> > +};
> > +
> > +&reg_ahci_5v {
> > +	status = "okay";
> > +};
> > +
> > +&reg_usb0_vbus {
> > +	status = "okay";
> > +};
> > +
> > +&usb_otg {
> > +	status = "okay";
> > +	dr_mode = "host";
> > +};
> > +
> > +&usbphy {
> > +	usb0_vbus-supply = <&reg_usb0_vbus>;
> > +};
> > --
> > 2.42.0
> > 
> > 
> 
> 
> 
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index e4dd678f4212..25251ce4b60d 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -362,6 +362,11 @@  properties:
           - const: itead,iteaduino-plus-a10
           - const: allwinner,sun4i-a10

+      - description: Itead Iteaduino Plus A20
+        items:
+          - const: itead,iteaduino-plus-a20
+          - const: allwinner,sun7i-a20
+
       - description: Jesurun Q5
         items:
           - const: jesurun,q5