| Message ID | 20230925165715.34883-1-bragathemanick0908@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ASoC: dt-bindings: rt5616: Convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 53 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Sep 25, 2023 at 10:27:15PM +0530, Bragatheswaran Manickavel wrote: > Convert the rt5616 audio CODEC bindings to DT schema > No error/warning seen when running make dt_binding_check No need to say that. That's the assumption and it should never get applied if not. > > Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> > --- > .../bindings/sound/realtek,rt5616.yaml | 53 +++++++++++++++++++ > .../devicetree/bindings/sound/rt5616.txt | 32 ----------- > 2 files changed, 53 insertions(+), 32 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5616.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml > new file mode 100644 > index 000000000000..00ff9b4e3c7e > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/realtek,rt5616.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek rt5616 ALSA SoC audio codec driver > + > +description: | > + Pins on the device (for linking into audio routes) for RT5616: > + > + * IN1P > + * IN2P > + * IN2N > + * LOUTL > + * LOUTR > + * HPOL > + * HPOR > + > +maintainers: > + - Bard Liao <bardliao@realtek.com> > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: realtek,rt5616 > + > + reg: > + maxItems: 1 > + > + "#sound-dai-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - '#sound-dai-cells' This was not in the original doc. Was that an error? If so, just state that in the commit msg. > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; blank line > + codec@1b { audio-codec@1b > + compatible = "realtek,rt5616"; > + reg = <0x1b>; > + #sound-dai-cells = <0>; > + }; > + };
On 28/09/23 21:49, Rob Herring wrote: > On Mon, Sep 25, 2023 at 10:27:15PM +0530, Bragatheswaran Manickavel wrote: >> Convert the rt5616 audio CODEC bindings to DT schema >> No error/warning seen when running make dt_binding_check > No need to say that. That's the assumption and it should never get > applied if not. > >> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> >> --- >> .../bindings/sound/realtek,rt5616.yaml | 53 +++++++++++++++++++ >> .../devicetree/bindings/sound/rt5616.txt | 32 ----------- >> 2 files changed, 53 insertions(+), 32 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5616.yaml >> delete mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml >> new file mode 100644 >> index 000000000000..00ff9b4e3c7e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/realtek,rt5616.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Realtek rt5616 ALSA SoC audio codec driver >> + >> +description: | >> + Pins on the device (for linking into audio routes) for RT5616: >> + >> + * IN1P >> + * IN2P >> + * IN2N >> + * LOUTL >> + * LOUTR >> + * HPOL >> + * HPOR >> + >> +maintainers: >> + - Bard Liao <bardliao@realtek.com> >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + const: realtek,rt5616 >> + >> + reg: >> + maxItems: 1 >> + >> + "#sound-dai-cells": >> + const: 0 >> + >> +required: >> + - compatible >> + - reg >> + - '#sound-dai-cells' > This was not in the original doc. Was that an error? If so, just state > that in the commit msg. Its was added by me. Will remove it >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; > blank line > >> + codec@1b { > audio-codec@1b > >> + compatible = "realtek,rt5616"; >> + reg = <0x1b>; >> + #sound-dai-cells = <0>; >> + }; >> + }; Will make these changes and send a new patch Thanks, Bragathe
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml new file mode 100644 index 000000000000..00ff9b4e3c7e --- /dev/null +++ b/Documentation/devicetree/bindings/sound/realtek,rt5616.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/realtek,rt5616.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek rt5616 ALSA SoC audio codec driver + +description: | + Pins on the device (for linking into audio routes) for RT5616: + + * IN1P + * IN2P + * IN2N + * LOUTL + * LOUTR + * HPOL + * HPOR + +maintainers: + - Bard Liao <bardliao@realtek.com> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: realtek,rt5616 + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + +required: + - compatible + - reg + - '#sound-dai-cells' + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + codec@1b { + compatible = "realtek,rt5616"; + reg = <0x1b>; + #sound-dai-cells = <0>; + }; + }; diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt deleted file mode 100644 index 540a4bf252e4..000000000000 --- a/Documentation/devicetree/bindings/sound/rt5616.txt +++ /dev/null @@ -1,32 +0,0 @@ -RT5616 audio CODEC - -This device supports I2C only. - -Required properties: - -- compatible : "realtek,rt5616". - -- reg : The I2C address of the device. - -Optional properties: - -- clocks: The phandle of the master clock to the CODEC. - -- clock-names: Should be "mclk". - -Pins on the device (for linking into audio routes) for RT5616: - - * IN1P - * IN2P - * IN2N - * LOUTL - * LOUTR - * HPOL - * HPOR - -Example: - -rt5616: codec@1b { - compatible = "realtek,rt5616"; - reg = <0x1b>; -};
Convert the rt5616 audio CODEC bindings to DT schema No error/warning seen when running make dt_binding_check Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> --- .../bindings/sound/realtek,rt5616.yaml | 53 +++++++++++++++++++ .../devicetree/bindings/sound/rt5616.txt | 32 ----------- 2 files changed, 53 insertions(+), 32 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5616.yaml delete mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt