| Message ID | 20230924113725.164948-2-ayushdevel1325@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | greybus: Add BeaglePlay Greybus Driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 24/09/2023 13:36, Ayush Singh wrote: > Adds DT bindings for BeaglePlay CC1352 co-processor. I gave you the link to the exact wording you should use. "Add", not "Adds". The latter is not a correct English sentences, I believe. > > BeaglePlay has a CC1352 co-processor connected to the main AM62 (running > Linux) over UART. In the BeagleConnect Technology, CC1352 is responsible > for handling 6LoWPAN communication with beagleconnect freedom nodes as > well as their discovery. > > It is used by gb-beagleplay greybus driver. > > Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com> > --- > .../bindings/net/beagle,play-cc1352.yaml | 25 +++++++++++++++++++ > MAINTAINERS | 6 +++++ > 2 files changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml > > diff --git a/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml b/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml > new file mode 100644 > index 000000000000..f8536d1a6765 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml > @@ -0,0 +1,25 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/beagle,play-cc1352.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: BeaglePlay CC1352 co-processor So this is "Texas Instruments Simplelink CC1352P7 wireless MCU"? Since you do not have any fixed feature and run general-purpose OS, then this should be rather compatible matching actual hardware (so ti,cc1352p7). > + > +maintainers: > + - Ayush Singh <ayushdevel1325@gmail.com> > + > +properties: > + compatible: > + const: beagle,play-cc1352 > + > +required: > + - compatible Still no resources? I asked about it last time and you did not answer anything. > + > +additionalProperties: false > + > +examples: > + - | > + mcu { > + compatible = "beagle,play-cc1352"; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 37b9626ee654..9d1b49a6dfad 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8969,6 +8969,12 @@ F: drivers/staging/greybus/sdio.c > F: drivers/staging/greybus/spi.c > F: drivers/staging/greybus/spilib.c > > +GREYBUS BEAGLEPLAY DRIVERS > +M: Ayush Singh <ayushdevel1325@gmail.com> > +L: greybus-dev@lists.linaro.org (moderated for non-subscribers) > +S: Maintained > +F: Documentation/devicetree/bindings/serial/beaglecc1352.yaml That's not a correct path. Best regards, Krzysztof
> So this is "Texas Instruments Simplelink CC1352P7 wireless MCU"? Since > you do not have any fixed feature and run general-purpose OS, then this > should be rather compatible matching actual hardware (so ti,cc1352p7). Yes, it is "Texas Instruments Simplelink CC1352P7 wireless MCU". Since the docs suggest that all functionality of the device should be mentioned in the bindings rather than just what is being used, I suppose all the other properties can be defined as optional? The bindings for this device do exist in Zephyr, so I guess that can be re-purposed for Linux kernel. However, I think in that case it should be moved into `soc` instead of `net`? > >> + >> +maintainers: >> + - Ayush Singh <ayushdevel1325@gmail.com> >> + >> +properties: >> + compatible: >> + const: beagle,play-cc1352 >> + >> +required: >> + - compatible > Still no resources? I asked about it last time and you did not answer > anything. Sorry, I missed that. By resources, I think you mean pins, peripherals, etc right? Ayush Singh
On 24/09/2023 14:22, Ayush Singh wrote: >> So this is "Texas Instruments Simplelink CC1352P7 wireless MCU"? Since >> you do not have any fixed feature and run general-purpose OS, then this >> should be rather compatible matching actual hardware (so ti,cc1352p7). > Yes, it is "Texas Instruments Simplelink CC1352P7 wireless MCU". Since > the docs suggest that all functionality of the device should be > mentioned in the bindings rather than just what is being used, I suppose > all the other properties can be defined as optional? The bindings for > this device do exist in Zephyr, so I guess that can be re-purposed for > Linux kernel. However, I think in that case it should be moved into > `soc` instead of `net`? Zephyr bindings might be entirely different, because they are for the case of running Zephyr OS on this processor. I still do not fully understand whether you describe here generic MCU used for Greybus or some specific firmware with fixed features. Looks like the first, thus my suggestion about compatible. The location could be arm. >> >>> + >>> +maintainers: >>> + - Ayush Singh <ayushdevel1325@gmail.com> >>> + >>> +properties: >>> + compatible: >>> + const: beagle,play-cc1352 >>> + >>> +required: >>> + - compatible >> Still no resources? I asked about it last time and you did not answer >> anything. > Sorry, I missed that. By resources, I think you mean pins, peripherals, > etc right? By resources I mean whatever is needed to power it up and operate, e.g. clocks, supplies, reset lines. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml b/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml new file mode 100644 index 000000000000..f8536d1a6765 --- /dev/null +++ b/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml @@ -0,0 +1,25 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/beagle,play-cc1352.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BeaglePlay CC1352 co-processor + +maintainers: + - Ayush Singh <ayushdevel1325@gmail.com> + +properties: + compatible: + const: beagle,play-cc1352 + +required: + - compatible + +additionalProperties: false + +examples: + - | + mcu { + compatible = "beagle,play-cc1352"; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 37b9626ee654..9d1b49a6dfad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8969,6 +8969,12 @@ F: drivers/staging/greybus/sdio.c F: drivers/staging/greybus/spi.c F: drivers/staging/greybus/spilib.c +GREYBUS BEAGLEPLAY DRIVERS +M: Ayush Singh <ayushdevel1325@gmail.com> +L: greybus-dev@lists.linaro.org (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/serial/beaglecc1352.yaml + GREYBUS SUBSYSTEM M: Johan Hovold <johan@kernel.org> M: Alex Elder <elder@kernel.org>
Adds DT bindings for BeaglePlay CC1352 co-processor. BeaglePlay has a CC1352 co-processor connected to the main AM62 (running Linux) over UART. In the BeagleConnect Technology, CC1352 is responsible for handling 6LoWPAN communication with beagleconnect freedom nodes as well as their discovery. It is used by gb-beagleplay greybus driver. Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com> --- .../bindings/net/beagle,play-cc1352.yaml | 25 +++++++++++++++++++ MAINTAINERS | 6 +++++ 2 files changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml