| Message ID | 20230920152015.1376838-4-hugo@hugovil.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | serial: sc16is7xx: device tree improvements | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/patch-applied | success |
Hugo Villeneuve wrote on 2023-09-20 17:20: > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > @@ -21,8 +21,8 @@ Optional properties: > the second cell is used to specify the GPIO polarity: > 0 = active high, > 1 = active low. > -- irda-mode-ports: An array that lists the indices of the port that > - should operate in IrDA mode. > +- nxp,irda-mode-ports: An array that lists the indices of the port > that > + should operate in IrDA mode. > - nxp,modem-control-line-ports: An array that lists the indices of > the port that Are you sure you want this line removed? > should have shared GPIO lines configured as > modem control lines. > @@ -80,8 +80,8 @@ Optional properties: > the second cell is used to specify the GPIO polarity: > 0 = active high, > 1 = active low. > -- irda-mode-ports: An array that lists the indices of the port that > - should operate in IrDA mode. > +- nxp,irda-mode-ports: An array that lists the indices of the port > that > + should operate in IrDA mode. > - nxp,modem-control-line-ports: An array that lists the indices of > the port that Same here. > should have shared GPIO lines configured as > modem control lines. Greets, Maarten
On Thu, 21 Sep 2023 12:29:13 +0200 m.brock@vanmierlo.com wrote: > Hugo Villeneuve wrote on 2023-09-20 17:20: > > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > @@ -21,8 +21,8 @@ Optional properties: > > the second cell is used to specify the GPIO polarity: > > 0 = active high, > > 1 = active low. > > -- irda-mode-ports: An array that lists the indices of the port that > > - should operate in IrDA mode. > > +- nxp,irda-mode-ports: An array that lists the indices of the port > > that > > + should operate in IrDA mode. > > - nxp,modem-control-line-ports: An array that lists the indices of > > the port that > > Are you sure you want this line removed? Hi Maarten, the line "- nxp,modem-control-line-ports..." is not removed, but because it starts with a dash in the source file, maybe it is confusing when looking at the patch only? Hugo. > > > should have shared GPIO lines configured as > > modem control lines. > > @@ -80,8 +80,8 @@ Optional properties: > > the second cell is used to specify the GPIO polarity: > > 0 = active high, > > 1 = active low. > > -- irda-mode-ports: An array that lists the indices of the port that > > - should operate in IrDA mode. > > +- nxp,irda-mode-ports: An array that lists the indices of the port > > that > > + should operate in IrDA mode. > > - nxp,modem-control-line-ports: An array that lists the indices of > > the port that > > Same here. > > > should have shared GPIO lines configured as > > modem control lines. > > Greets, > Maarten > >
On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > The NXP-specific "irda-mode-ports" property lacks a proper vendor > prefix. Add "nxp," prefix to comply with DT best practises. Looks like you've made changes to the driver in a way both will work, Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > .../devicetree/bindings/serial/nxp,sc16is7xx.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > index 1a7e4bff0456..d89815c5c562 100644 > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > @@ -21,8 +21,8 @@ Optional properties: > the second cell is used to specify the GPIO polarity: > 0 = active high, > 1 = active low. > -- irda-mode-ports: An array that lists the indices of the port that > - should operate in IrDA mode. > +- nxp,irda-mode-ports: An array that lists the indices of the port that > + should operate in IrDA mode. > - nxp,modem-control-line-ports: An array that lists the indices of the port that > should have shared GPIO lines configured as > modem control lines. > @@ -80,8 +80,8 @@ Optional properties: > the second cell is used to specify the GPIO polarity: > 0 = active high, > 1 = active low. > -- irda-mode-ports: An array that lists the indices of the port that > - should operate in IrDA mode. > +- nxp,irda-mode-ports: An array that lists the indices of the port that > + should operate in IrDA mode. > - nxp,modem-control-line-ports: An array that lists the indices of the port that > should have shared GPIO lines configured as > modem control lines. > -- > 2.30.2 >
On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > The NXP-specific "irda-mode-ports" property lacks a proper vendor > prefix. Add "nxp," prefix to comply with DT best practises. The opposite direction would be worth carrying in the driver, but I don't think adding a vendor prefix is. I would just leave this as-is. Rob
On Thu, 21 Sep 2023 11:24:24 -0500 Rob Herring <robh@kernel.org> wrote: > On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > The NXP-specific "irda-mode-ports" property lacks a proper vendor > > prefix. Add "nxp," prefix to comply with DT best practises. > > The opposite direction would be worth carrying in the driver, but I > don't think adding a vendor prefix is. I would just leave this as-is. > > Rob Hi Rob, I am not following you, can you clarify? Hugo.
On Thu, Sep 21, 2023 at 11:32 AM Hugo Villeneuve <hugo@hugovil.com> wrote: > > On Thu, 21 Sep 2023 11:24:24 -0500 > Rob Herring <robh@kernel.org> wrote: > > > On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote: > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > > The NXP-specific "irda-mode-ports" property lacks a proper vendor > > > prefix. Add "nxp," prefix to comply with DT best practises. > > > > The opposite direction would be worth carrying in the driver, but I > > don't think adding a vendor prefix is. I would just leave this as-is. > > > > Rob > > Hi Rob, > I am not following you, can you clarify? Just keep the property as-is and don't add a 'nxp,' prefixed version. It's not worth carrying the fallback in the driver. If you were dropping a vendor prefix from a property, then that's worth it because there might be other users added. Rob
On Fri, 22 Sep 2023 14:52:06 -0500 Rob Herring <robh@kernel.org> wrote: > On Thu, Sep 21, 2023 at 11:32 AM Hugo Villeneuve <hugo@hugovil.com> wrote: > > > > On Thu, 21 Sep 2023 11:24:24 -0500 > > Rob Herring <robh@kernel.org> wrote: > > > > > On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote: > > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > > > > The NXP-specific "irda-mode-ports" property lacks a proper vendor > > > > prefix. Add "nxp," prefix to comply with DT best practises. > > > > > > The opposite direction would be worth carrying in the driver, but I > > > don't think adding a vendor prefix is. I would just leave this as-is. > > > > > > Rob > > > > Hi Rob, > > I am not following you, can you clarify? > > Just keep the property as-is and don't add a 'nxp,' prefixed version. > It's not worth carrying the fallback in the driver. > > If you were dropping a vendor prefix from a property, then that's > worth it because there might be other users added. > > Rob Hi Rob, ok, then I will drop this patch as well as the other titled 'serial: sc16is7xx: recognize "nxp,irda-mode-ports" DT property' for V2. Hugo.
diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt index 1a7e4bff0456..d89815c5c562 100644 --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt @@ -21,8 +21,8 @@ Optional properties: the second cell is used to specify the GPIO polarity: 0 = active high, 1 = active low. -- irda-mode-ports: An array that lists the indices of the port that - should operate in IrDA mode. +- nxp,irda-mode-ports: An array that lists the indices of the port that + should operate in IrDA mode. - nxp,modem-control-line-ports: An array that lists the indices of the port that should have shared GPIO lines configured as modem control lines. @@ -80,8 +80,8 @@ Optional properties: the second cell is used to specify the GPIO polarity: 0 = active high, 1 = active low. -- irda-mode-ports: An array that lists the indices of the port that - should operate in IrDA mode. +- nxp,irda-mode-ports: An array that lists the indices of the port that + should operate in IrDA mode. - nxp,modem-control-line-ports: An array that lists the indices of the port that should have shared GPIO lines configured as modem control lines.