Message ID | 20230919103913.463156-2-andre.przywara@arm.com |
---|---|
State | Not Applicable |
Headers | show |
Series | mfd: axp20x: improve support without interrupts | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
Dne torek, 19. september 2023 ob 12:39:12 CEST je Andre Przywara napisal(a): > All X-Powers PMICs described by this binding have an IRQ pin, and so > far (almost) all boards connected this to some NMI pin or GPIO on the SoC > they are connected to. > However we start to see boards that omit this connection, and technically > the IRQ pin is not essential to the basic PMIC operation. > > The existing Linux driver allows skipping the IRQ pin setup for two chips > already, so update the binding to also make the DT property optional for > the missing chip. And while we are at it, add the AXP313a to that list, > as they are actually boards out there not connecting the IRQ pin. > > This allows to have DTs correctly describing those boards not wiring up > the interrupt. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Should I pick this patch through sunxi tree? Best regards, Jernej > --- > Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > index 9ad55746133b5..06f1779835a1e 100644 > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > @@ -67,7 +67,10 @@ allOf: > properties: > compatible: > contains: > - const: x-powers,axp305 > + enum: > + - x-powers,axp15060 > + - x-powers,axp305 > + - x-powers,axp313a > > then: > required: >
On Sun, 24 Sep 2023, Jernej Škrabec wrote: > Dne torek, 19. september 2023 ob 12:39:12 CEST je Andre Przywara napisal(a): > > All X-Powers PMICs described by this binding have an IRQ pin, and so > > far (almost) all boards connected this to some NMI pin or GPIO on the SoC > > they are connected to. > > However we start to see boards that omit this connection, and technically > > the IRQ pin is not essential to the basic PMIC operation. > > > > The existing Linux driver allows skipping the IRQ pin setup for two chips > > already, so update the binding to also make the DT property optional for > > the missing chip. And while we are at it, add the AXP313a to that list, > > as they are actually boards out there not connecting the IRQ pin. > > > > This allows to have DTs correctly describing those boards not wiring up > > the interrupt. > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Should I pick this patch through sunxi tree? No thank you.
On Tue, 19 Sep 2023 11:39:12 +0100, Andre Przywara wrote: > All X-Powers PMICs described by this binding have an IRQ pin, and so > far (almost) all boards connected this to some NMI pin or GPIO on the SoC > they are connected to. > However we start to see boards that omit this connection, and technically > the IRQ pin is not essential to the basic PMIC operation. > > The existing Linux driver allows skipping the IRQ pin setup for two chips > already, so update the binding to also make the DT property optional for > the missing chip. And while we are at it, add the AXP313a to that list, > as they are actually boards out there not connecting the IRQ pin. > > [...] Applied, thanks! [1/2] dt-bindings: mfd: x-powers,axp152: make interrupt optional for more chips commit: cf71329eb3a37f90c8ddec0651dc7b3fa76036c1 -- Lee Jones [李琼斯]
diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml index 9ad55746133b5..06f1779835a1e 100644 --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml @@ -67,7 +67,10 @@ allOf: properties: compatible: contains: - const: x-powers,axp305 + enum: + - x-powers,axp15060 + - x-powers,axp305 + - x-powers,axp313a then: required: