| Message ID | 20230919103116.580305-2-ckeepax@opensource.cirrus.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Minor default jack pop performance updates | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Sep 19, 2023 at 11:31:12AM +0100, Charles Keepax wrote: > The bias sense is being enabled by default in the driver, and the > default detect time is being dropped slightly. Update the binding > document to match. That's not really a compatible change. If I wrote my DT expecting bias sense was disabled by default then the OS changes behavior, my platform behavior would change. Maybe that doesn't matter here? IDK. It's on you if this breaks anyone, so: Acked-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml > index 7a6de938b11d1..4fa22fa70ace5 100644 > --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml > +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml > @@ -83,7 +83,7 @@ properties: > Current at which the headset micbias sense clamp will engage, 0 to > disable. > enum: [ 0, 14, 23, 41, 50, 60, 68, 86, 95 ] > - default: 0 > + default: 14 > > cirrus,bias-ramp-ms: > description: > @@ -97,7 +97,7 @@ properties: > Time in microseconds the type detection will run for. Long values will > cause more audible effects, but give more accurate detection. > enum: [ 20, 100, 1000, 10000, 50000, 75000, 100000, 200000 ] > - default: 10000 > + default: 1000 > > cirrus,button-automute: > type: boolean > -- > 2.39.2 >
On Tue, Sep 19, 2023 at 02:23:02PM -0500, Rob Herring wrote: > On Tue, Sep 19, 2023 at 11:31:12AM +0100, Charles Keepax wrote: > > The bias sense is being enabled by default in the driver, and the > > default detect time is being dropped slightly. Update the binding > > document to match. > > That's not really a compatible change. If I wrote my DT expecting bias > sense was disabled by default then the OS changes behavior, my > platform behavior would change. Maybe that doesn't matter here? IDK. > It's on you if this breaks anyone, so: > > Acked-by: Rob Herring <robh@kernel.org> > Yeah I appreciate that, but this should be fine, the part is very very new. The only systems using the part are still in development. Thanks, Charles
diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml index 7a6de938b11d1..4fa22fa70ace5 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml @@ -83,7 +83,7 @@ properties: Current at which the headset micbias sense clamp will engage, 0 to disable. enum: [ 0, 14, 23, 41, 50, 60, 68, 86, 95 ] - default: 0 + default: 14 cirrus,bias-ramp-ms: description: @@ -97,7 +97,7 @@ properties: Time in microseconds the type detection will run for. Long values will cause more audible effects, but give more accurate detection. enum: [ 20, 100, 1000, 10000, 50000, 75000, 100000, 200000 ] - default: 10000 + default: 1000 cirrus,button-automute: type: boolean
The bias sense is being enabled by default in the driver, and the default detect time is being dropped slightly. Update the binding document to match. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- Documentation/devicetree/bindings/sound/cirrus,cs42l43.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)