| Message ID | 20230919090739.2448-1-bragathemanick0908@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ASoC: dt-bindings: tfa9879: Convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 45 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 19 Sep 2023 14:37:39 +0530, Bragatheswaran Manickavel wrote: > Convert the tfa9879 audio CODEC bindings to DT schema > > Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> > --- > .../bindings/sound/nxp,tfa9879.yaml | 45 +++++++++++++++++++ > .../devicetree/bindings/sound/tfa9879.txt | 23 ---------- > 2 files changed, 45 insertions(+), 23 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/sound/nxp,tfa9879.example.dts:22.27-40 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/sound/nxp,tfa9879.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): MAINTAINERS: Documentation/devicetree/bindings/sound/tfa9879.txt See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230919090739.2448-1-bragathemanick0908@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Bragatheswaran,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.6-rc2 next-20230920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bragatheswaran-Manickavel/ASoC-dt-bindings-tfa9879-Convert-to-dtschema/20230919-170919
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20230919090739.2448-1-bragathemanick0908%40gmail.com
patch subject: [PATCH] ASoC: dt-bindings: tfa9879: Convert to dtschema
reproduce: (https://download.01.org/0day-ci/archive/20230920/202309201811.iKOZ5prG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309201811.iKOZ5prG-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/sound/tfa9879.txt
On 19/09/2023 11:07, Bragatheswaran Manickavel wrote: > Convert the tfa9879 audio CODEC bindings to DT schema > > +required: > + - compatible > + - reg > + - '#sound-dai-cells' > + > +additionalProperties: false Instead: unevaluatedProperties: false > + > +examples: > + - | > + i2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + amp: amp@6c { amplifier@6c > + compatible: "nxp,tfa9879"; > + reg: <0x6c>; > + "#sound-dai-cells": <0>; > + pinctrl-names: "default"; > + pinctrl-0: <&pinctrl_i2c1>; That's not a DT syntax. Best regards, Krzysztof
On 20/09/23 16:58, Krzysztof Kozlowski wrote: > On 19/09/2023 11:07, Bragatheswaran Manickavel wrote: >> Convert the tfa9879 audio CODEC bindings to DT schema >> >> +required: >> + - compatible >> + - reg >> + - '#sound-dai-cells' >> + >> +additionalProperties: false > Instead: > unevaluatedProperties: false > >> + >> +examples: >> + - | >> + i2c1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + amp: amp@6c { > amplifier@6c > >> + compatible: "nxp,tfa9879"; >> + reg: <0x6c>; >> + "#sound-dai-cells": <0>; >> + pinctrl-names: "default"; >> + pinctrl-0: <&pinctrl_i2c1>; > That's not a DT syntax. > > Best regards, > Krzysztof > Let me correct all this errors/warnings and send a new patch. Thanks, Bragathe
diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml new file mode 100644 index 000000000000..792494f4a2dd --- /dev/null +++ b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/nxp,tfa9879.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP TFA9879 class-D audio amplifier + +maintainers: + - Peter Rosin <peda@axentia.se> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: nxp,tfa9879 + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + +required: + - compatible + - reg + - '#sound-dai-cells' + +additionalProperties: false + +examples: + - | + i2c1 { + #address-cells = <1>; + #size-cells = <0>; + amp: amp@6c { + compatible: "nxp,tfa9879"; + reg: <0x6c>; + "#sound-dai-cells": <0>; + pinctrl-names: "default"; + pinctrl-0: <&pinctrl_i2c1>; + }; + }; + diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt deleted file mode 100644 index 1620e6848436..000000000000 --- a/Documentation/devicetree/bindings/sound/tfa9879.txt +++ /dev/null @@ -1,23 +0,0 @@ -NXP TFA9879 class-D audio amplifier - -Required properties: - -- compatible : "nxp,tfa9879" - -- reg : the I2C address of the device - -- #sound-dai-cells : must be 0. - -Example: - -&i2c1 { - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_i2c1>; - - amp: amp@6c { - #sound-dai-cells = <0>; - compatible = "nxp,tfa9879"; - reg = <0x6c>; - }; -}; -
Convert the tfa9879 audio CODEC bindings to DT schema Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com> --- .../bindings/sound/nxp,tfa9879.yaml | 45 +++++++++++++++++++ .../devicetree/bindings/sound/tfa9879.txt | 23 ---------- 2 files changed, 45 insertions(+), 23 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml delete mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt