diff mbox series

[1/2] dt-bindings: arm: aspeed: document board compatibles

Message ID 20230912140532.3797736-2-yangchen.openbmc@gmail.com
State Not Applicable
Headers show
Series Add CMC of Facebook Minerva platform | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Yang Chen Sept. 12, 2023, 2:05 p.m. UTC 
From: Yang Chen <yangchen.openbmc@gmail.com>

Document the new compatibles used on the Facebook Minerva Chassis
Management Controller (CMC).

Signed-off-by: Yang Chen <yangchen.openbmc@gmail.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 13, 2023, 8:20 a.m. UTC | #1 
On 12/09/2023 16:05, yangchen.openbmc@gmail.com wrote:
> From: Yang Chen <yangchen.openbmc@gmail.com>
> 
> Document the new compatibles used on the Facebook Minerva Chassis
> Management Controller (CMC).

How is this related to
https://lore.kernel.org/all/20230907064514.1764010-3-peteryin.openbmc@gmail.com/
? Looks like duplicate :/

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 13, 2023, 10:03 a.m. UTC | #2 
On 12/09/2023 16:05, yangchen.openbmc@gmail.com wrote:
> From: Yang Chen <yangchen.openbmc@gmail.com>
> 
> Document the new compatibles used on the Facebook Minerva Chassis
> Management Controller (CMC).
> 
> Signed-off-by: Yang Chen <yangchen.openbmc@gmail.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 13, 2023, 10:05 a.m. UTC | #3 
On 13/09/2023 11:52, Yang Chen wrote:
> Hi Krzysztof,
> 
> Thanks for your reply, Minerva is a project of Facebook server that
> includes two types of boards. One is the motherboard that includes a BMC
> and another is the Chassis Management Board that includes a CMC and both
> use the Aspeed SoC (AST2600). These patches are for the CMC and the link
> you provided is for the BMC and they need to use different DTS.

Are they similar? Maybe you should share board DTSI?

Best regards,
Krzysztof
Yang Chen Sept. 13, 2023, 2:19 p.m. UTC | #4 
> On 13/09/2023 11:52, Yang Chen wrote:
> > Hi Krzysztof,
> >
> > Thanks for your reply, Minerva is a project of Facebook server that
> > includes two types of boards. One is the motherboard that includes a BMC
> > and another is the Chassis Management Board that includes a CMC and both
> > use the Aspeed SoC (AST2600). These patches are for the CMC and the link
> > you provided is for the BMC and they need to use different DTS.
>
> Are they similar? Maybe you should share board DTSI?
>
> Best regards,
> Krzysztof
>

No, they are not similar. They just use the same SoC but they are on
different system boards with different electronic schematic.

Thanks,
Yang Chen
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 68f717670f78..749ee54a3ff8 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -79,6 +79,7 @@  properties:
               - facebook,elbert-bmc
               - facebook,fuji-bmc
               - facebook,greatlakes-bmc
+              - facebook,minerva-cmc
               - facebook,yosemite4-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc