| Message ID | 20230912075651.10693-3-moudy.ho@mediatek.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | introduce more MDP3 components in mt8195 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 11 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 12/09/2023 09:56, Moudy Ho wrote: > Due to the same hardware design, MDP RDMA needs to > be integrated into the same binding. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. This applies to entire patchset. It is not dt-binding, but dt-bindings. > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > --- > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 ------------------- > .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +- > 2 files changed, 3 insertions(+), 90 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml > deleted file mode 100644 > index dd12e2ff685c..000000000000 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml > +++ /dev/null > @@ -1,88 +0,0 @@ > -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > -%YAML 1.2 > ---- > -$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml# > -$schema: http://devicetree.org/meta-schemas/core.yaml# > - > -title: MediaTek MDP RDMA > - > -maintainers: > - - Chun-Kuang Hu <chunkuang.hu@kernel.org> > - - Philipp Zabel <p.zabel@pengutronix.de> > - > -description: > - The MediaTek MDP RDMA stands for Read Direct Memory Access. > - It provides real time data to the back-end panel driver, such as DSI, > - DPI and DP_INTF. > - It contains one line buffer to store the sufficient pixel data. > - RDMA device node must be siblings to the central MMSYS_CONFIG node. > - For a description of the MMSYS_CONFIG binding, see > - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details. > - > -properties: > - compatible: > - const: mediatek,mt8195-vdo1-rdma > - > - reg: > - maxItems: 1 > - > - interrupts: > - maxItems: 1 > - > - power-domains: > - maxItems: 1 > - > - clocks: > - items: > - - description: RDMA Clock This is different and you did not explain it in commit msg. Another difference - mboxes. Looks like you did not test your DTS... Best regards, Krzysztof
On Tue, 2023-09-12 at 10:16 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 12/09/2023 09:56, Moudy Ho wrote: > > Due to the same hardware design, MDP RDMA needs to > > be integrated into the same binding. > > > > Please use subject prefixes matching the subsystem. You can get them > for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the > directory > your patch is touching. > > This applies to entire patchset. It is not dt-binding, but dt- > bindings. > > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > > --- > > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 ------------- > ------ > > .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +- > > 2 files changed, 3 insertions(+), 90 deletions(-) > > delete mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > rdma.yaml > > > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > rdma.yaml > b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > rdma.yaml > > deleted file mode 100644 > > index dd12e2ff685c..000000000000 > > --- > a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- > rdma.yaml > > +++ /dev/null > > @@ -1,88 +0,0 @@ > > -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > -%YAML 1.2 > > ---- > > -$id: > http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml# > > -$schema: http://devicetree.org/meta-schemas/core.yaml# > > - > > -title: MediaTek MDP RDMA > > - > > -maintainers: > > - - Chun-Kuang Hu <chunkuang.hu@kernel.org> > > - - Philipp Zabel <p.zabel@pengutronix.de> > > - > > -description: > > - The MediaTek MDP RDMA stands for Read Direct Memory Access. > > - It provides real time data to the back-end panel driver, such as > DSI, > > - DPI and DP_INTF. > > - It contains one line buffer to store the sufficient pixel data. > > - RDMA device node must be siblings to the central MMSYS_CONFIG > node. > > - For a description of the MMSYS_CONFIG binding, see > > > - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > for details. > > - > > -properties: > > - compatible: > > - const: mediatek,mt8195-vdo1-rdma > > - > > - reg: > > - maxItems: 1 > > - > > - interrupts: > > - maxItems: 1 > > - > > - power-domains: > > - maxItems: 1 > > - > > - clocks: > > - items: > > - - description: RDMA Clock > > This is different and you did not explain it in commit msg. > > Another difference - mboxes. Looks like you did not test your DTS... > > Best regards, > Krzysztof > Hi Krzysztof, Sorry for the inconvenience. The property you mentioned was removed on [3/3]. This incorrect configuration went unnoticed because I passed the test with the entire series. It will be recified in the next version. Sincerely, Moudy
On 13/09/2023 05:04, Moudy Ho (何宗原) wrote: > On Tue, 2023-09-12 at 10:16 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 12/09/2023 09:56, Moudy Ho wrote: >>> Due to the same hardware design, MDP RDMA needs to >>> be integrated into the same binding. >>> >> >> Please use subject prefixes matching the subsystem. You can get them >> for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the >> directory >> your patch is touching. >> >> This applies to entire patchset. It is not dt-binding, but dt- >> bindings. >> >>> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> >>> --- >>> .../display/mediatek/mediatek,mdp-rdma.yaml | 88 ------------- >> ------ >>> .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +- >>> 2 files changed, 3 insertions(+), 90 deletions(-) >>> delete mode 100644 >> Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- >> rdma.yaml >>> >>> diff --git >> a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- >> rdma.yaml >> b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- >> rdma.yaml >>> deleted file mode 100644 >>> index dd12e2ff685c..000000000000 >>> --- >> a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp- >> rdma.yaml >>> +++ /dev/null >>> @@ -1,88 +0,0 @@ >>> -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> -%YAML 1.2 >>> ---- >>> -$id: >> http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml# >>> -$schema: http://devicetree.org/meta-schemas/core.yaml# >>> - >>> -title: MediaTek MDP RDMA >>> - >>> -maintainers: >>> - - Chun-Kuang Hu <chunkuang.hu@kernel.org> >>> - - Philipp Zabel <p.zabel@pengutronix.de> >>> - >>> -description: >>> - The MediaTek MDP RDMA stands for Read Direct Memory Access. >>> - It provides real time data to the back-end panel driver, such as >> DSI, >>> - DPI and DP_INTF. >>> - It contains one line buffer to store the sufficient pixel data. >>> - RDMA device node must be siblings to the central MMSYS_CONFIG >> node. >>> - For a description of the MMSYS_CONFIG binding, see >>> >> - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml >> for details. >>> - >>> -properties: >>> - compatible: >>> - const: mediatek,mt8195-vdo1-rdma >>> - >>> - reg: >>> - maxItems: 1 >>> - >>> - interrupts: >>> - maxItems: 1 >>> - >>> - power-domains: >>> - maxItems: 1 >>> - >>> - clocks: >>> - items: >>> - - description: RDMA Clock >> >> This is different and you did not explain it in commit msg. >> >> Another difference - mboxes. Looks like you did not test your DTS... >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > > Sorry for the inconvenience. > The property you mentioned was removed on [3/3]. This incorrect > configuration went unnoticed because I passed the test with the entire > series. > It will be recified in the next version. Please describe any differences (lost properties etc) in commit msg with some explanation. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml deleted file mode 100644 index dd12e2ff685c..000000000000 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml +++ /dev/null @@ -1,88 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: MediaTek MDP RDMA - -maintainers: - - Chun-Kuang Hu <chunkuang.hu@kernel.org> - - Philipp Zabel <p.zabel@pengutronix.de> - -description: - The MediaTek MDP RDMA stands for Read Direct Memory Access. - It provides real time data to the back-end panel driver, such as DSI, - DPI and DP_INTF. - It contains one line buffer to store the sufficient pixel data. - RDMA device node must be siblings to the central MMSYS_CONFIG node. - For a description of the MMSYS_CONFIG binding, see - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details. - -properties: - compatible: - const: mediatek,mt8195-vdo1-rdma - - reg: - maxItems: 1 - - interrupts: - maxItems: 1 - - power-domains: - maxItems: 1 - - clocks: - items: - - description: RDMA Clock - - iommus: - maxItems: 1 - - mediatek,gce-client-reg: - description: - The register of display function block to be set by gce. There are 4 arguments, - such as gce node, subsys id, offset and register size. The subsys id that is - mapping to the register of display function blocks is defined in the gce header - include/dt-bindings/gce/<chip>-gce.h of each chips. - $ref: /schemas/types.yaml#/definitions/phandle-array - items: - items: - - description: phandle of GCE - - description: GCE subsys id - - description: register offset - - description: register size - maxItems: 1 - -required: - - compatible - - reg - - power-domains - - clocks - - iommus - - mediatek,gce-client-reg - -additionalProperties: false - -examples: - - | - #include <dt-bindings/interrupt-controller/arm-gic.h> - #include <dt-bindings/clock/mt8195-clk.h> - #include <dt-bindings/power/mt8195-power.h> - #include <dt-bindings/gce/mt8195-gce.h> - #include <dt-bindings/memory/mt8195-memory-port.h> - - soc { - #address-cells = <2>; - #size-cells = <2>; - - rdma@1c104000 { - compatible = "mediatek,mt8195-vdo1-rdma"; - reg = <0 0x1c104000 0 0x1000>; - interrupts = <GIC_SPI 495 IRQ_TYPE_LEVEL_HIGH 0>; - clocks = <&vdosys1 CLK_VDO1_MDP_RDMA0>; - power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS1>; - iommus = <&iommu_vdo M4U_PORT_L2_MDP_RDMA0>; - mediatek,gce-client-reg = <&gce0 SUBSYS_1c10XXXX 0x4000 0x1000>; - }; - }; diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml index 3e128733ef53..0c22571d8c22 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml @@ -20,8 +20,9 @@ description: | properties: compatible: - items: - - const: mediatek,mt8183-mdp3-rdma + enum: + - mediatek,mt8183-mdp3-rdma + - mediatek,mt8195-vdo1-rdma reg: maxItems: 1
Due to the same hardware design, MDP RDMA needs to be integrated into the same binding. Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> --- .../display/mediatek/mediatek,mdp-rdma.yaml | 88 ------------------- .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +- 2 files changed, 3 insertions(+), 90 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml