| Message ID | 20230804175734.v2.1.I7a950de49ec24b957e90d7fe7abd5f2f5f2e24c3@changeid |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add no-esim sku for sc7180-lazor family and new board version | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi, On Fri, Aug 4, 2023 at 2:58 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > Introduce more sc7180-lazor sku and board version configuration, > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen, > add new board version 10 for audio codec ALC5682i-VS. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v2: > - add new entry rev9 with Parade bridge chip > > .../devicetree/bindings/arm/qcom.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 450f616774e0..dce7b771a280 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -470,6 +470,11 @@ properties: > - const: google,lazor-rev8 > - const: qcom,sc7180 > > + - description: Acer Chromebook Spin 513 Parade bridge chip (rev9) You probably didn't need to include "Parade bridge chip" in the description since that's implied by "rev9" > @@ -512,11 +522,26 @@ properties: > - const: google,lazor-rev8-sku0 > - const: qcom,sc7180 > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9) > + items: > + - const: google,lazor-rev9-sku0 > + - const: qcom,sc7180 > + > - description: Acer Chromebook Spin 513 with LTE (newest rev) > items: > - const: google,lazor-sku0 > - const: qcom,sc7180 > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9) > + items: > + - const: google,lazor-rev9-sku10 > + - const: qcom,sc7180 The no-eSIM and normal LTE should be combined into one, just like they are in your device tree. If you look at patch #3, you can see "sc7180-trogdor-lazor-r9-lte.dts" contains: compatible = "google,lazor-rev9-sku0", "google,lazor-rev9-sku10", "qcom,sc7180"; You need to have a single entry here that matches that. That means one entry that has both rev9-sku0 and rev9-sku10. You should be running "make dtbs_check" at the end of your series. As Krzysztof would say, (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions) -Doug
On 04/08/2023 11:58, Sheng-Liang Pan wrote: > Introduce more sc7180-lazor sku and board version configuration, > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen, > add new board version 10 for audio codec ALC5682i-VS. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v2: > - add new entry rev9 with Parade bridge chip > > .../devicetree/bindings/arm/qcom.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 450f616774e0..dce7b771a280 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -470,6 +470,11 @@ properties: > - const: google,lazor-rev8 > - const: qcom,sc7180 > > + - description: Acer Chromebook Spin 513 Parade bridge chip (rev9) > + items: > + - const: google,lazor-rev9 > + - const: qcom,sc7180 > + > - description: Acer Chromebook Spin 513 (newest rev) > items: > - const: google,lazor > @@ -491,6 +496,11 @@ properties: > - const: google,lazor-rev8-sku2 > - const: qcom,sc7180 > > + - description: Acer Chromebook Spin 513 Parade bridge chip with KB Backlight (rev9) > + items: > + - const: google,lazor-rev9-sku2 > + - const: qcom,sc7180 > + > - description: Acer Chromebook Spin 513 with KB Backlight (newest rev) > items: > - const: google,lazor-sku2 > @@ -512,11 +522,26 @@ properties: > - const: google,lazor-rev8-sku0 > - const: qcom,sc7180 > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9) > + items: > + - const: google,lazor-rev9-sku0 > + - const: qcom,sc7180 > + > - description: Acer Chromebook Spin 513 with LTE (newest rev) > items: > - const: google,lazor-sku0 > - const: qcom,sc7180 > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9) > + items: > + - const: google,lazor-rev9-sku10 > + - const: qcom,sc7180 > + > + - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev) > + items: > + - const: google,lazor-sku10 > + - const: qcom,sc7180 > + > - description: Acer Chromebook 511 (rev4 - rev8) > items: > - const: google,lazor-rev4-sku4 > @@ -526,6 +551,11 @@ properties: > - const: google,lazor-rev8-sku4 > - const: qcom,sc7180 > > + - description: Acer Chromebook 511 Parade bridge chip (rev9) > + items: > + - const: google,lazor-rev9-sku4 > + - const: qcom,sc7180 > + > - description: Acer Chromebook 511 (newest rev) > items: > - const: google,lazor-sku4 > @@ -545,11 +575,36 @@ properties: > - const: google,lazor-rev8-sku6 > - const: qcom,sc7180 > > + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen (rev9) > + items: > + - const: google,lazor-rev9-sku6 > + - const: qcom,sc7180 > + > - description: Acer Chromebook 511 without Touchscreen (newest rev) > items: > - const: google,lazor-sku6 > - const: qcom,sc7180 > > + - description: Acer Chromebook 511 Parade bridge chip no-esim (rev9) > + items: > + - const: google,lazor-rev9-sku15 > + - const: qcom,sc7180 > + > + - description: Acer Chromebook 511 no-esim (newest rev) > + items: > + - const: google,lazor-sku15 > + - const: qcom,sc7180 > + > + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen no-esim (rev9) > + items: > + - const: google,lazor-rev9-sku18 > + - const: qcom,sc7180 > + > + - description: Acer Chromebook 511 without Touchscreen no-esim (newest rev) > + items: > + - const: google,lazor-sku18 All of these entries (existing and new) should be just one entry with: - enum: - .... - .... - const: qcom,sc7180 Best regards, Krzysztof
On 4.08.2023 18:30, Doug Anderson wrote: > Hi, > > On Fri, Aug 4, 2023 at 2:58 AM Sheng-Liang Pan > <sheng-liang.pan@quanta.corp-partner.google.com> wrote: >> >> Introduce more sc7180-lazor sku and board version configuration, >> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen, >> add new board version 10 for audio codec ALC5682i-VS. >> >> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> >> --- [...] > > You should be running "make dtbs_check" at the end of your series. As Ideally on each patch separately, with: # or you can set git config alias.last describe --abbrev=0, thx Bjorn git rebase -i $(git describe --abbrev=0) replace 'pick' -> 'edit' while (rebase is ongoing, can probably check retval of git rebase --continue) do "make ... dtbs check something.." as otherwise you may slip in a breakage inbetween that you fix later on Konrad
Hi, On Sun, Aug 6, 2023 at 11:32 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 04/08/2023 11:58, Sheng-Liang Pan wrote: > > Introduce more sc7180-lazor sku and board version configuration, > > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen, > > add new board version 10 for audio codec ALC5682i-VS. > > > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > > --- > > > > Changes in v2: > > - add new entry rev9 with Parade bridge chip > > > > .../devicetree/bindings/arm/qcom.yaml | 55 +++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > > index 450f616774e0..dce7b771a280 100644 > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > > @@ -470,6 +470,11 @@ properties: > > - const: google,lazor-rev8 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip (rev9) > > + items: > > + - const: google,lazor-rev9 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook Spin 513 (newest rev) > > items: > > - const: google,lazor > > @@ -491,6 +496,11 @@ properties: > > - const: google,lazor-rev8-sku2 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip with KB Backlight (rev9) > > + items: > > + - const: google,lazor-rev9-sku2 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook Spin 513 with KB Backlight (newest rev) > > items: > > - const: google,lazor-sku2 > > @@ -512,11 +522,26 @@ properties: > > - const: google,lazor-rev8-sku0 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9) > > + items: > > + - const: google,lazor-rev9-sku0 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook Spin 513 with LTE (newest rev) > > items: > > - const: google,lazor-sku0 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9) > > + items: > > + - const: google,lazor-rev9-sku10 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev) > > + items: > > + - const: google,lazor-sku10 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook 511 (rev4 - rev8) > > items: > > - const: google,lazor-rev4-sku4 > > @@ -526,6 +551,11 @@ properties: > > - const: google,lazor-rev8-sku4 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook 511 Parade bridge chip (rev9) > > + items: > > + - const: google,lazor-rev9-sku4 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook 511 (newest rev) > > items: > > - const: google,lazor-sku4 > > @@ -545,11 +575,36 @@ properties: > > - const: google,lazor-rev8-sku6 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen (rev9) > > + items: > > + - const: google,lazor-rev9-sku6 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook 511 without Touchscreen (newest rev) > > items: > > - const: google,lazor-sku6 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook 511 Parade bridge chip no-esim (rev9) > > + items: > > + - const: google,lazor-rev9-sku15 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook 511 no-esim (newest rev) > > + items: > > + - const: google,lazor-sku15 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen no-esim (rev9) > > + items: > > + - const: google,lazor-rev9-sku18 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook 511 without Touchscreen no-esim (newest rev) > > + items: > > + - const: google,lazor-sku18 > > All of these entries (existing and new) should be just one entry with: > - enum: > - .... > - .... > - const: qcom,sc7180 I believe we've had this discussion before. At least twice. Here's a link to the last time you said "Ah, OK, I guess this is fine". https://lore.kernel.org/r/d3d4d90b-85b5-5ad9-78e6-5a074c21af4f@linaro.org
On 15/08/2023 22:41, Doug Anderson wrote: > Hi, > > On Sun, Aug 6, 2023 at 11:32 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 04/08/2023 11:58, Sheng-Liang Pan wrote: >>> Introduce more sc7180-lazor sku and board version configuration, >>> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen, >>> add new board version 10 for audio codec ALC5682i-VS. >>> >>> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> >>> --- >>> >>> Changes in v2: >>> - add new entry rev9 with Parade bridge chip >>> >>> .../devicetree/bindings/arm/qcom.yaml | 55 +++++++++++++++++++ >>> 1 file changed, 55 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>> index 450f616774e0..dce7b771a280 100644 >>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>> @@ -470,6 +470,11 @@ properties: >>> - const: google,lazor-rev8 >>> - const: qcom,sc7180 >>> >>> + - description: Acer Chromebook Spin 513 Parade bridge chip (rev9) >>> + items: >>> + - const: google,lazor-rev9 >>> + - const: qcom,sc7180 >>> + >>> - description: Acer Chromebook Spin 513 (newest rev) >>> items: >>> - const: google,lazor >>> @@ -491,6 +496,11 @@ properties: >>> - const: google,lazor-rev8-sku2 >>> - const: qcom,sc7180 >>> >>> + - description: Acer Chromebook Spin 513 Parade bridge chip with KB Backlight (rev9) >>> + items: >>> + - const: google,lazor-rev9-sku2 >>> + - const: qcom,sc7180 >>> + >>> - description: Acer Chromebook Spin 513 with KB Backlight (newest rev) >>> items: >>> - const: google,lazor-sku2 >>> @@ -512,11 +522,26 @@ properties: >>> - const: google,lazor-rev8-sku0 >>> - const: qcom,sc7180 >>> >>> + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9) >>> + items: >>> + - const: google,lazor-rev9-sku0 >>> + - const: qcom,sc7180 >>> + >>> - description: Acer Chromebook Spin 513 with LTE (newest rev) >>> items: >>> - const: google,lazor-sku0 >>> - const: qcom,sc7180 >>> >>> + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9) >>> + items: >>> + - const: google,lazor-rev9-sku10 >>> + - const: qcom,sc7180 >>> + >>> + - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev) >>> + items: >>> + - const: google,lazor-sku10 >>> + - const: qcom,sc7180 >>> + >>> - description: Acer Chromebook 511 (rev4 - rev8) >>> items: >>> - const: google,lazor-rev4-sku4 >>> @@ -526,6 +551,11 @@ properties: >>> - const: google,lazor-rev8-sku4 >>> - const: qcom,sc7180 >>> >>> + - description: Acer Chromebook 511 Parade bridge chip (rev9) >>> + items: >>> + - const: google,lazor-rev9-sku4 >>> + - const: qcom,sc7180 >>> + >>> - description: Acer Chromebook 511 (newest rev) >>> items: >>> - const: google,lazor-sku4 >>> @@ -545,11 +575,36 @@ properties: >>> - const: google,lazor-rev8-sku6 >>> - const: qcom,sc7180 >>> >>> + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen (rev9) >>> + items: >>> + - const: google,lazor-rev9-sku6 >>> + - const: qcom,sc7180 >>> + >>> - description: Acer Chromebook 511 without Touchscreen (newest rev) >>> items: >>> - const: google,lazor-sku6 >>> - const: qcom,sc7180 >>> >>> + - description: Acer Chromebook 511 Parade bridge chip no-esim (rev9) >>> + items: >>> + - const: google,lazor-rev9-sku15 >>> + - const: qcom,sc7180 >>> + >>> + - description: Acer Chromebook 511 no-esim (newest rev) >>> + items: >>> + - const: google,lazor-sku15 >>> + - const: qcom,sc7180 >>> + >>> + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen no-esim (rev9) >>> + items: >>> + - const: google,lazor-rev9-sku18 >>> + - const: qcom,sc7180 >>> + >>> + - description: Acer Chromebook 511 without Touchscreen no-esim (newest rev) >>> + items: >>> + - const: google,lazor-sku18 >> >> All of these entries (existing and new) should be just one entry with: >> - enum: >> - .... >> - .... >> - const: qcom,sc7180 > > I believe we've had this discussion before. At least twice. Here's a > link to the last time you said "Ah, OK, I guess this is fine". > > https://lore.kernel.org/r/d3d4d90b-85b5-5ad9-78e6-5a074c21af4f@linaro.org Current solutions brings descriptions, so it has some benefits... I guess this is fine for third time. Maybe this time I will remember... Although I keep coming with several same questions to all SoC DTS/bindings which do things differently than common case. I will be coming because that's the price of doing things awkwardly or differently than everyone else, e.g. overriding by full DT path like in Tegra. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 450f616774e0..dce7b771a280 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -470,6 +470,11 @@ properties: - const: google,lazor-rev8 - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 Parade bridge chip (rev9) + items: + - const: google,lazor-rev9 + - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 (newest rev) items: - const: google,lazor @@ -491,6 +496,11 @@ properties: - const: google,lazor-rev8-sku2 - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 Parade bridge chip with KB Backlight (rev9) + items: + - const: google,lazor-rev9-sku2 + - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev) items: - const: google,lazor-sku2 @@ -512,11 +522,26 @@ properties: - const: google,lazor-rev8-sku0 - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9) + items: + - const: google,lazor-rev9-sku0 + - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 with LTE (newest rev) items: - const: google,lazor-sku0 - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9) + items: + - const: google,lazor-rev9-sku10 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev) + items: + - const: google,lazor-sku10 + - const: qcom,sc7180 + - description: Acer Chromebook 511 (rev4 - rev8) items: - const: google,lazor-rev4-sku4 @@ -526,6 +551,11 @@ properties: - const: google,lazor-rev8-sku4 - const: qcom,sc7180 + - description: Acer Chromebook 511 Parade bridge chip (rev9) + items: + - const: google,lazor-rev9-sku4 + - const: qcom,sc7180 + - description: Acer Chromebook 511 (newest rev) items: - const: google,lazor-sku4 @@ -545,11 +575,36 @@ properties: - const: google,lazor-rev8-sku6 - const: qcom,sc7180 + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen (rev9) + items: + - const: google,lazor-rev9-sku6 + - const: qcom,sc7180 + - description: Acer Chromebook 511 without Touchscreen (newest rev) items: - const: google,lazor-sku6 - const: qcom,sc7180 + - description: Acer Chromebook 511 Parade bridge chip no-esim (rev9) + items: + - const: google,lazor-rev9-sku15 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 no-esim (newest rev) + items: + - const: google,lazor-sku15 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen no-esim (rev9) + items: + - const: google,lazor-rev9-sku18 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 without Touchscreen no-esim (newest rev) + items: + - const: google,lazor-sku18 + - const: qcom,sc7180 + - description: Google Mrbland with AUO panel (rev0) items: - const: google,mrbland-rev0-sku0
Introduce more sc7180-lazor sku and board version configuration, add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen, add new board version 10 for audio codec ALC5682i-VS. Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Changes in v2: - add new entry rev9 with Parade bridge chip .../devicetree/bindings/arm/qcom.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+)