diff mbox series

dt-bindings: pinctrl: pinctrl-single: add am62x compatible

Message ID 20230803092311.604610-1-d-gole@ti.com
State Changes Requested, archived
Headers show
Series dt-bindings: pinctrl: pinctrl-single: add am62x compatible | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied fail build log

Commit Message

Dhruva Gole Aug. 3, 2023, 9:23 a.m. UTC
Add the am62x compatible property to add support for the new
wakeup enable and status bits positions

Cc: Nishanth Menon <nm@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
CC: Tony Lindgren <tony@atomide.com>
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---

Base: tag: next-20230731 + below "depends on" patch
Depends on: https://lore.kernel.org/linux-omap/20230731061908.GG5194@atomide.com/T/

 Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Tony Lindgren Aug. 7, 2023, 2:43 p.m. UTC | #1
* Dhruva Gole <d-gole@ti.com> [230803 09:24]:
> Add the am62x compatible property to add support for the new
> wakeup enable and status bits positions
> 
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> CC: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>

Reviewed-by: Tony Lindgren <tony@atomide.com>
Krzysztof Kozlowski Aug. 7, 2023, 2:53 p.m. UTC | #2
On 03/08/2023 11:23, Dhruva Gole wrote:
> Add the am62x compatible property to add support for the new
> wakeup enable and status bits positions
> 
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> CC: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
> 
> Base: tag: next-20230731 + below "depends on" patch
> Depends on: https://lore.kernel.org/linux-omap/20230731061908.GG5194@atomide.com/T/
> 
>  Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> index b6b6bcd7074b..4c98035a1217 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> @@ -23,6 +23,7 @@ properties:
>            - pinconf-single
>        - items:
>            - enum:
> +              - ti,am6-padconf

This does not look like am62x. Except this, am62x looks like family, not
SoC.

Best regards,
Krzysztof
Dhruva Gole Aug. 7, 2023, 3:48 p.m. UTC | #3
Krzysztof,

On Aug 07, 2023 at 16:53:28 +0200, Krzysztof Kozlowski wrote:
> On 03/08/2023 11:23, Dhruva Gole wrote:
> > Add the am62x compatible property to add support for the new
> > wakeup enable and status bits positions
> > 
> > Cc: Nishanth Menon <nm@ti.com>
> > Cc: Vignesh Raghavendra <vigneshr@ti.com>
> > CC: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Dhruva Gole <d-gole@ti.com>
> > ---
> > 
> > Base: tag: next-20230731 + below "depends on" patch
> > Depends on: https://lore.kernel.org/linux-omap/20230731061908.GG5194@atomide.com/T/
> > 
> >  Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> > index b6b6bcd7074b..4c98035a1217 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> > @@ -23,6 +23,7 @@ properties:
> >            - pinconf-single
> >        - items:
> >            - enum:
> > +              - ti,am6-padconf
> 
> This does not look like am62x. Except this, am62x looks like family, not
> SoC.

We are at V3 in this patch,
Tony, please can you review the latest rev?
https://lore.kernel.org/all/20230804050737.635186-1-d-gole@ti.com/

Otherwise, I will re-spin a new series including the DT-Binding patch
and the driver changes in a single patch series, where I will pick Tony's R-by.

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
index b6b6bcd7074b..4c98035a1217 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
@@ -23,6 +23,7 @@  properties:
           - pinconf-single
       - items:
           - enum:
+              - ti,am6-padconf
               - ti,am437-padconf
               - ti,dra7-padconf
               - ti,omap2420-padconf