diff mbox series

[1/2] dt-bindings: arm: bcm: add bindings for ASUS RT-AC3100

Message ID 20230803071454.5902-1-arinc.unal@arinc9.com
State Not Applicable, archived
Headers show
Series [1/2] dt-bindings: arm: bcm: add bindings for ASUS RT-AC3100 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Arınç ÜNAL Aug. 3, 2023, 7:14 a.m. UTC
Add ASUS RT-AC3100 under BCM47094 based boards.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Aug. 3, 2023, 10:10 a.m. UTC | #1
On Thu, Aug 3, 2023 at 9:15 AM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:

> Add ASUS RT-AC3100 under BCM47094 based boards.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Linus Walleij Aug. 3, 2023, 10:13 a.m. UTC | #2
On Thu, Aug 3, 2023 at 9:15 AM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:

> ASUS RT-AC3100 is ASUS RT-AC88U without the external switch. Move the
> shared bindings to bcm47094-asus-rt-ac3100.dtsi.
>
> Remove the fixed-link node on port@7 as commit ba4aebce23b2 ("ARM: dts:
> BCM5301X: Describe switch ports in the main DTS") states it's not
> necessary.
>
> Replace the copyright notice with an author notice.
>
> Rename the model name from Asus to ASUS on bcm47094-asus-rt-ac88u.dts.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

LGTM!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Conor Dooley Aug. 3, 2023, 3:44 p.m. UTC | #3
On Thu, Aug 03, 2023 at 10:14:53AM +0300, Arınç ÜNAL wrote:
> Add ASUS RT-AC3100 under BCM47094 based boards.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> index 5c3ac97e8728..4cc4e6754681 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> @@ -66,6 +66,7 @@ properties:
>        - description: BCM47094 based boards
>          items:
>            - enum:
> +              - asus,rt-ac3100
>                - asus,rt-ac88u
>                - dlink,dir-885l
>                - dlink,dir-890l
> -- 
> 2.39.2
>
Florian Fainelli Aug. 4, 2023, 5:08 p.m. UTC | #4
From: Florian Fainelli <f.fainelli@gmail.com>

On Thu,  3 Aug 2023 10:14:53 +0300, Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
> Add ASUS RT-AC3100 under BCM47094 based boards.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
Florian Fainelli Aug. 4, 2023, 5:08 p.m. UTC | #5
From: Florian Fainelli <f.fainelli@gmail.com>

On Thu,  3 Aug 2023 10:14:54 +0300, Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
> ASUS RT-AC3100 is ASUS RT-AC88U without the external switch. Move the
> shared bindings to bcm47094-asus-rt-ac3100.dtsi.
> 
> Remove the fixed-link node on port@7 as commit ba4aebce23b2 ("ARM: dts:
> BCM5301X: Describe switch ports in the main DTS") states it's not
> necessary.
> 
> Replace the copyright notice with an author notice.
> 
> Rename the model name from Asus to ASUS on bcm47094-asus-rt-ac88u.dts.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
index 5c3ac97e8728..4cc4e6754681 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
@@ -66,6 +66,7 @@  properties:
       - description: BCM47094 based boards
         items:
           - enum:
+              - asus,rt-ac3100
               - asus,rt-ac88u
               - dlink,dir-885l
               - dlink,dir-890l