| Message ID | 20230801115143.27738-1-quic_ajainp@quicinc.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Aug 01, 2023 at 05:21:43PM +0530, Anvesh Jain P wrote: > Update rtc-pm8xxx bindings with disable-alarm-wakeup property. > > Signed-off-by: Venkata Rao Kakani <quic_vkakani@quicinc.com> > Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com> The corresponding driver patch, afaict got NAKed. Why were they not sent together? Thanks, Conor. > --- > Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > index 9c51c1b19067..e4f1d2ff02b6 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > @@ -42,6 +42,9 @@ properties: > > interrupt-controller: true > > + disable-alarm-wakeup: > + description: optional, disable alarm wake up capability. > + > patternProperties: > "led@[0-9a-f]+$": > type: object > > base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd > -- > 2.17.1 >
On 01/08/2023 13:51, Anvesh Jain P wrote: > Update rtc-pm8xxx bindings with disable-alarm-wakeup property. > > Signed-off-by: Venkata Rao Kakani <quic_vkakani@quicinc.com> > Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com> > --- > Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > index 9c51c1b19067..e4f1d2ff02b6 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > @@ -42,6 +42,9 @@ properties: > > interrupt-controller: true > > + disable-alarm-wakeup: > + description: optional, disable alarm wake up capability. This was no tested. Missing type, vendor prefix. Additionally the description says absolutely nothing, just repeats the schema. Sorry, does not look like hardware property with such description. Anyway sending it without DTS or driver is also no-go, so NAK, sorry. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml index 9c51c1b19067..e4f1d2ff02b6 100644 --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml @@ -42,6 +42,9 @@ properties: interrupt-controller: true + disable-alarm-wakeup: + description: optional, disable alarm wake up capability. + patternProperties: "led@[0-9a-f]+$": type: object