| Message ID | 20230730190243.113105-1-david@ixit.cz |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v3] dt-bindings: sound: gtm601: convert to YAML | expand |
On 30/07/2023 21:02, David Heidelberg wrote: > Convert GTM601 binding to the YAML format. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > v3: > - incorporated feedback from Krzysztof ... > +properties: > + compatible: > + oneOf: > + - items: # 48 kHz stereo > + - const: broadmobi,bm818 > + - const: option,gtm601 > + - const: option,gtm601 # 8 kHz mono > + > + '#sound-dai-cells': > + const: 0 > + > +allOf: > + - $ref: dai-common.yaml# > + > +additionalProperties: false I missed one thing in the previous review, sorry. Something was looking here as missing but my brain did not work. Please add "required:" with compatible. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/gtm601.txt b/Documentation/devicetree/bindings/sound/gtm601.txt deleted file mode 100644 index efa32a486c4a..000000000000 --- a/Documentation/devicetree/bindings/sound/gtm601.txt +++ /dev/null @@ -1,19 +0,0 @@ -GTM601 UMTS modem audio interface CODEC - -This device has no configuration interface. The sample rate and channels are -based on the compatible string - "option,gtm601" = 8kHz mono - "broadmobi,bm818" = 48KHz stereo - -Required properties: - - - compatible : one of - "option,gtm601" - "broadmobi,bm818" - - -Example: - -codec: gtm601_codec { - compatible = "option,gtm601"; -}; diff --git a/Documentation/devicetree/bindings/sound/option,gtm601.yaml b/Documentation/devicetree/bindings/sound/option,gtm601.yaml new file mode 100644 index 000000000000..9a70d20eb30d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/option,gtm601.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/option,gtm601.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GTM601 UMTS modem audio interface CODEC + +maintainers: + - kernel@puri.sm + +description: > + This device has no configuration interface. The sample rate and channels are + based on the compatible string + +properties: + compatible: + oneOf: + - items: # 48 kHz stereo + - const: broadmobi,bm818 + - const: option,gtm601 + - const: option,gtm601 # 8 kHz mono + + '#sound-dai-cells': + const: 0 + +allOf: + - $ref: dai-common.yaml# + +additionalProperties: false + +examples: + - | + codec { + compatible = "option,gtm601"; + #sound-dai-cells = <0>; + };
Convert GTM601 binding to the YAML format. Signed-off-by: David Heidelberg <david@ixit.cz> --- v3: - incorporated feedback from Krzysztof v2: - add #sound-dai-cells - put kernel@puri.sm into maintainers .../devicetree/bindings/sound/gtm601.txt | 19 ---------- .../bindings/sound/option,gtm601.yaml | 37 +++++++++++++++++++ 2 files changed, 37 insertions(+), 19 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/gtm601.txt create mode 100644 Documentation/devicetree/bindings/sound/option,gtm601.yaml