| Message ID | 20230717093347.3869167-4-sai.krishna.potthuri@amd.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ipinctrl: pinctrl-zynqmp: Add tri-state configuration support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 10 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Jul 17, 2023 at 03:03:46PM +0530, Sai Krishna Potthuri wrote: > Add 'output-enable' configuration parameter to the properties list. > > Using these pinctrl properties observed hang issues with older Xilinx > ZynqMP Platform Management Firmware, hence reverted the patch previously. > Commit ff8356060e3a5e126abb ("Revert "dt-bindings: pinctrl-zynqmp: Add > output-enable configuration""). And what has changed since then that makes it okay to add? Is the old firmware not still in the wild? Thanks, Conor. > > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> > --- > .../devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > index 2722dc7bb03d..1e2b9b627b12 100644 > --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > @@ -274,6 +274,10 @@ patternProperties: > slew-rate: > enum: [0, 1] > > + output-enable: > + description: > + This will internally disable the tri-state for MIO pins. > + > drive-strength: > description: > Selects the drive strength for MIO pins, in mA. > -- > 2.25.1 >
Hi Conor, > -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Tuesday, July 18, 2023 9:20 PM > To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com> > Cc: Linus Walleij <linus.walleij@linaro.org>; Simek, Michal > <michal.simek@amd.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > <conor+dt@kernel.org>; Mathieu Poirier <mathieu.poirier@linaro.org>; Shah, > Tanmay <tanmay.shah@amd.com>; Levinsky, Ben <ben.levinsky@amd.com>; > Marek Vasut <marex@denx.de>; Roman Gushchin <roman.gushchin@linux.dev>; > Arnd Bergmann <arnd@arndb.de>; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-gpio@vger.kernel.org; devicetree@vger.kernel.org; > saikrishna12468@gmail.com; git (AMD-Xilinx) <git@amd.com> > Subject: Re: [PATCH 3/4] dt-bindings: pinctrl-zynqmp: Add output-enable > configuration > > On Mon, Jul 17, 2023 at 03:03:46PM +0530, Sai Krishna Potthuri wrote: > > Add 'output-enable' configuration parameter to the properties list. > > > > Using these pinctrl properties observed hang issues with older Xilinx > > ZynqMP Platform Management Firmware, hence reverted the patch previously. > > Commit ff8356060e3a5e126abb ("Revert "dt-bindings: pinctrl-zynqmp: Add > > output-enable configuration""). > > And what has changed since then that makes it okay to add? > Is the old firmware not still in the wild? This time when Linux firmware driver get the request for TRISTATE configuration from pinctrl driver, it checks if that configuration is supported by the Xilinx ZynqMP Platform Management firmware. If yes, then calls will be made otherwise it returns error. Regards Sai Krishna > > Thanks, > Conor. > > > > > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> > > --- > > .../devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > > b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > > index 2722dc7bb03d..1e2b9b627b12 100644 > > --- > > a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.ya > > +++ ml > > @@ -274,6 +274,10 @@ patternProperties: > > slew-rate: > > enum: [0, 1] > > > > + output-enable: > > + description: > > + This will internally disable the tri-state for MIO pins. > > + > > drive-strength: > > description: > > Selects the drive strength for MIO pins, in mA. > > -- > > 2.25.1 > >
On Wed, Jul 19, 2023 at 06:49:43AM +0000, Potthuri, Sai Krishna wrote: > Hi Conor, > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: Tuesday, July 18, 2023 9:20 PM > > To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com> > > Cc: Linus Walleij <linus.walleij@linaro.org>; Simek, Michal > > <michal.simek@amd.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof > > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > > <conor+dt@kernel.org>; Mathieu Poirier <mathieu.poirier@linaro.org>; Shah, > > Tanmay <tanmay.shah@amd.com>; Levinsky, Ben <ben.levinsky@amd.com>; > > Marek Vasut <marex@denx.de>; Roman Gushchin <roman.gushchin@linux.dev>; > > Arnd Bergmann <arnd@arndb.de>; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; linux-gpio@vger.kernel.org; devicetree@vger.kernel.org; > > saikrishna12468@gmail.com; git (AMD-Xilinx) <git@amd.com> > > Subject: Re: [PATCH 3/4] dt-bindings: pinctrl-zynqmp: Add output-enable > > configuration > > > > On Mon, Jul 17, 2023 at 03:03:46PM +0530, Sai Krishna Potthuri wrote: > > > Add 'output-enable' configuration parameter to the properties list. > > > > > > Using these pinctrl properties observed hang issues with older Xilinx > > > ZynqMP Platform Management Firmware, hence reverted the patch previously. > > > Commit ff8356060e3a5e126abb ("Revert "dt-bindings: pinctrl-zynqmp: Add > > > output-enable configuration""). > > > > And what has changed since then that makes it okay to add? > > Is the old firmware not still in the wild? > This time when Linux firmware driver get the request for TRISTATE configuration > from pinctrl driver, it checks if that configuration is supported by the Xilinx ZynqMP > Platform Management firmware. If yes, then calls will be made otherwise it returns error. Please put that information in your commit message. With that done, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml index 2722dc7bb03d..1e2b9b627b12 100644 --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml @@ -274,6 +274,10 @@ patternProperties: slew-rate: enum: [0, 1] + output-enable: + description: + This will internally disable the tri-state for MIO pins. + drive-strength: description: Selects the drive strength for MIO pins, in mA.
Add 'output-enable' configuration parameter to the properties list. Using these pinctrl properties observed hang issues with older Xilinx ZynqMP Platform Management Firmware, hence reverted the patch previously. Commit ff8356060e3a5e126abb ("Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration""). Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> --- .../devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 4 ++++ 1 file changed, 4 insertions(+)