| Message ID | 20230704202929.91962-1-marex@denx.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Marek, you are right. Reviewed-by: Andreas Kemnade <andreas@kemnade.info> On Tue, 4 Jul 2023 22:29:29 +0200 Marek Vasut <marex@denx.de> wrote: > Since the chip can drive up to 6 lines, the maximum > register number should be only 5, not 6. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Andreas Kemnade <andreas@kemnade.info> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Lee Jones <lee@kernel.org> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-leds@vger.kernel.org > --- > Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > index 14700a2e5feaa..44dd91aa239de 100644 > --- a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > @@ -35,7 +35,7 @@ properties: > description: GPIO pin to enable/disable the device. > > patternProperties: > - "^led@[0-6]$": > + "^led@[0-5]$": > type: object > $ref: common.yaml# > unevaluatedProperties: false > @@ -43,7 +43,7 @@ patternProperties: > properties: > reg: > minimum: 0 > - maximum: 6 > + maximum: 5 > > required: > - reg
On Tue, 04 Jul 2023 22:29:29 +0200, Marek Vasut wrote: > Since the chip can drive up to 6 lines, the maximum > register number should be only 5, not 6. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Andreas Kemnade <andreas@kemnade.info> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Lee Jones <lee@kernel.org> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-leds@vger.kernel.org > --- > Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 04 Jul 2023, Marek Vasut wrote: > Since the chip can drive up to 6 lines, the maximum > register number should be only 5, not 6. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Andreas Kemnade <andreas@kemnade.info> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Lee Jones <lee@kernel.org> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-leds@vger.kernel.org > --- > Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml index 14700a2e5feaa..44dd91aa239de 100644 --- a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml @@ -35,7 +35,7 @@ properties: description: GPIO pin to enable/disable the device. patternProperties: - "^led@[0-6]$": + "^led@[0-5]$": type: object $ref: common.yaml# unevaluatedProperties: false @@ -43,7 +43,7 @@ patternProperties: properties: reg: minimum: 0 - maximum: 6 + maximum: 5 required: - reg
Since the chip can drive up to 6 lines, the maximum register number should be only 5, not 6. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Andreas Kemnade <andreas@kemnade.info> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Lee Jones <lee@kernel.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-leds@vger.kernel.org --- Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)