| Message ID | 20230616170022.76107-3-sebastian.reichel@collabora.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | RK3588 PCIe2 support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Jun 16, 2023 at 07:00:20PM +0200, Sebastian Reichel wrote: > Rockchip RK356x and RK3588 handle legacy interrupts via a ganged > interrupts. The RK356x DT implements this via a sub-node named > "legacy-interrupt-controller", just like a couple of other PCIe > implementations. This adds proper documentation for this and updates > the example to avoid regressions. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../bindings/pci/rockchip-dw-pcie.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > index 98e45d2d8dfe..bf81d306cc80 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > @@ -67,6 +67,22 @@ properties: > - const: legacy > - const: err > > + legacy-interrupt-controller: > + description: Interrupt controller node for handling legacy PCI interrupts. > + type: object additionalProperties: false With that, Reviewed-by: Rob Herring <robh@kernel.org>
On Fri, Jun 16, 2023 at 07:00:20PM +0200, Sebastian Reichel wrote: > Rockchip RK356x and RK3588 handle legacy interrupts via a ganged > interrupts. The RK356x DT implements this via a sub-node named > "legacy-interrupt-controller", just like a couple of other PCIe > implementations. This adds proper documentation for this and updates > the example to avoid regressions. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../bindings/pci/rockchip-dw-pcie.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > index 98e45d2d8dfe..bf81d306cc80 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > @@ -67,6 +67,22 @@ properties: > - const: legacy > - const: err > > + legacy-interrupt-controller: > + description: Interrupt controller node for handling legacy PCI interrupts. > + type: object > + properties: > + "#address-cells": > + const: 0 > + > + "#interrupt-cells": > + const: 1 > + > + "interrupt-controller": true redundant quotes. > + > + interrupts: > + items: > + - description: combined legacy interrupt Missing the "additionalProperties" qualifier and the "required" property. -Serge(y) > + > msi-map: true > > num-lanes: true > @@ -148,6 +164,14 @@ examples: > reset-names = "pipe"; > #address-cells = <3>; > #size-cells = <2>; > + > + legacy-interrupt-controller { > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <1>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 72 IRQ_TYPE_EDGE_RISING>; > + }; > }; > }; > ... > -- > 2.39.2 >
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml index 98e45d2d8dfe..bf81d306cc80 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml @@ -67,6 +67,22 @@ properties: - const: legacy - const: err + legacy-interrupt-controller: + description: Interrupt controller node for handling legacy PCI interrupts. + type: object + properties: + "#address-cells": + const: 0 + + "#interrupt-cells": + const: 1 + + "interrupt-controller": true + + interrupts: + items: + - description: combined legacy interrupt + msi-map: true num-lanes: true @@ -148,6 +164,14 @@ examples: reset-names = "pipe"; #address-cells = <3>; #size-cells = <2>; + + legacy-interrupt-controller { + interrupt-controller; + #address-cells = <0>; + #interrupt-cells = <1>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 72 IRQ_TYPE_EDGE_RISING>; + }; }; }; ...
Rockchip RK356x and RK3588 handle legacy interrupts via a ganged interrupts. The RK356x DT implements this via a sub-node named "legacy-interrupt-controller", just like a couple of other PCIe implementations. This adds proper documentation for this and updates the example to avoid regressions. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- .../bindings/pci/rockchip-dw-pcie.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)