| Message ID | 20230614-sa3ul-v5-1-29dd2366fba3@ti.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Remove power-domains property for devices with compatible ti,am62-sa3ul | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 23 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 14:42-20230714, Kamlesh Gurudasani wrote: > Devices specific to compatible ti,am62-sa3ul don't have control over > power of SA3UL from main domain. > > "power-domains" property in crypto node tries to access > the SA3UL power, for which it gets NACK and hence, driver doesn't > probe properly for those particular devices. > > Make "power-domains" property as false for devices with > compatible ti,am62-sa3ul. > > Fixes: 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation") > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com> > --- > Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) Herbert, Do you see a problem if I pick this patch via TI SoC Tree? if you are OK, I'd like to take the series to keep it clean. > > diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > index 77ec8bc70bf7..f0ef7685550a 100644 > --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > @@ -66,10 +66,22 @@ patternProperties: > required: > - compatible > - reg > - - power-domains > - dmas > - dma-names > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: ti,am62-sa3ul > + then: > + properties: > + power-domains: false > + else: > + required: > + - power-domains > + > additionalProperties: false > > examples: > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml index 77ec8bc70bf7..f0ef7685550a 100644 --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml @@ -66,10 +66,22 @@ patternProperties: required: - compatible - reg - - power-domains - dmas - dma-names +allOf: + - if: + properties: + compatible: + contains: + const: ti,am62-sa3ul + then: + properties: + power-domains: false + else: + required: + - power-domains + additionalProperties: false examples:
Devices specific to compatible ti,am62-sa3ul don't have control over power of SA3UL from main domain. "power-domains" property in crypto node tries to access the SA3UL power, for which it gets NACK and hence, driver doesn't probe properly for those particular devices. Make "power-domains" property as false for devices with compatible ti,am62-sa3ul. Fixes: 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation") Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com> --- Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)