| Message ID | 20230612105250.15441-7-maso.huang@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ASoC: mediatek: Add support for MT79xx SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 12/06/2023 12:52, Maso Hunag wrote: > From: Maso Huang <maso.huang@mediatek.com> > > Add document for mt79xx board with wm8960. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > > Signed-off-by: Maso Huang <maso.huang@mediatek.com> > --- > .../sound/mediatek,mt79xx-wm8960.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml > new file mode 100644 > index 000000000000..26b38bb629da > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt79xx-wm8960.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT79xx ASOC sound card with WM8960 codec What is a MT79xx ASOC? Is it some specific SoC name? What does "A" stands for in SoC? XX also looks odd, I thought Mediatek uses only numbers. > + > +maintainers: > + - Maso Huang <maso.huang@mediatek.com> > + > +properties: > + compatible: > + const: mediatek,mt79xx-wm8960-machine > + > + mediatek,platform: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT79xx ASoC platform. What is MT79xx ASoC platform? Best regards, Krzysztof
On Tue, 2023-06-13 at 10:49 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 12/06/2023 12:52, Maso Hunag wrote: > > From: Maso Huang <maso.huang@mediatek.com> > > > > Add document for mt79xx board with wm8960. > > Please use scripts/get_maintainers.pl to get a list of necessary > people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you > base > your patches on recent Linux kernel. > Hi Krzysztof, I'll add necessary maintainers back in v2 patch. > > > > Signed-off-by: Maso Huang <maso.huang@mediatek.com> > > --- > > .../sound/mediatek,mt79xx-wm8960.yaml | 53 > +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml > > > > diff --git > a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml > b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml > > new file mode 100644 > > index 000000000000..26b38bb629da > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx- > wm8960.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > http://devicetree.org/schemas/sound/mediatek,mt79xx-wm8960.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek MT79xx ASOC sound card with WM8960 codec > > What is a MT79xx ASOC? Is it some specific SoC name? What does "A" > stands for in SoC? XX also looks odd, I thought Mediatek uses only > numbers. > I'll use mt7986 instead of mt79xx in v2 patch. And ASoC means ALSA SoC. > > + > > +maintainers: > > + - Maso Huang <maso.huang@mediatek.com> > > + > > +properties: > > + compatible: > > + const: mediatek,mt79xx-wm8960-machine > > + > > + mediatek,platform: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of MT79xx ASoC platform. > > What is MT79xx ASoC platform? > I'll use mt7986 instead of mt79xx in v2 patch. > > > Best regards, > Krzysztof > Best regards, Maso
On 14/06/2023 09:40, Maso Huang (黃加竹) wrote: >>> Signed-off-by: Maso Huang <maso.huang@mediatek.com> >>> --- >>> .../sound/mediatek,mt79xx-wm8960.yaml | 53 >> +++++++++++++++++++ >>> 1 file changed, 53 insertions(+) >>> create mode 100644 >> Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml >>> >>> diff --git >> a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml >> b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml >>> new file mode 100644 >>> index 000000000000..26b38bb629da >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx- >> wm8960.yaml >>> @@ -0,0 +1,53 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: >> http://devicetree.org/schemas/sound/mediatek,mt79xx-wm8960.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: MediaTek MT79xx ASOC sound card with WM8960 codec >> >> What is a MT79xx ASOC? Is it some specific SoC name? What does "A" >> stands for in SoC? XX also looks odd, I thought Mediatek uses only >> numbers. >> > > I'll use mt7986 instead of mt79xx in v2 patch. > And ASoC means ALSA SoC. ALSA is Linux stuff, so does not belong to bindings. I have no clue what is "ALSA SoC" (as SoC means System on Chip). Please describe real hardware not Linux or your configuration or some SW. Best regards, Krzysztof
On Wed, 2023-06-14 at 10:22 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 14/06/2023 09:40, Maso Huang (黃加竹) wrote: > >>> Signed-off-by: Maso Huang <maso.huang@mediatek.com> > >>> --- > >>> .../sound/mediatek,mt79xx-wm8960.yaml | 53 > >> +++++++++++++++++++ > >>> 1 file changed, 53 insertions(+) > >>> create mode 100644 > >> Documentation/devicetree/bindings/sound/mediatek,mt79xx- > wm8960.yaml > >>> > >>> diff --git > >> a/Documentation/devicetree/bindings/sound/mediatek,mt79xx- > wm8960.yaml > >> b/Documentation/devicetree/bindings/sound/mediatek,mt79xx- > wm8960.yaml > >>> new file mode 100644 > >>> index 000000000000..26b38bb629da > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx- > >> wm8960.yaml > >>> @@ -0,0 +1,53 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: > >> http://devicetree.org/schemas/sound/mediatek,mt79xx-wm8960.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: MediaTek MT79xx ASOC sound card with WM8960 codec > >> > >> What is a MT79xx ASOC? Is it some specific SoC name? What does "A" > >> stands for in SoC? XX also looks odd, I thought Mediatek uses only > >> numbers. > >> > > > > I'll use mt7986 instead of mt79xx in v2 patch. > > And ASoC means ALSA SoC. > > ALSA is Linux stuff, so does not belong to bindings. I have no clue > what > is "ALSA SoC" (as SoC means System on Chip). > > Please describe real hardware not Linux or your configuration or some > SW. > Got it, I'll remove it in v2 patch. > > Best regards, > Krzysztof > Best regards, Maso
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml new file mode 100644 index 000000000000..26b38bb629da --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-wm8960.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mediatek,mt79xx-wm8960.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MT79xx ASOC sound card with WM8960 codec + +maintainers: + - Maso Huang <maso.huang@mediatek.com> + +properties: + compatible: + const: mediatek,mt79xx-wm8960-machine + + mediatek,platform: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of MT79xx ASoC platform. + + audio-routing: + $ref: /schemas/types.yaml#/definitions/non-unique-string-array + description: + A list of the connections between audio components. Each entry is a + sink/source pair of strings. Valid names could be the input or output + widgets of audio components, power supplies, MicBias of codec and the + software switch. + + mediatek,audio-codec: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of wm8960 codec. + +additionalProperties: false + +required: + - compatible + - mediatek,platform + - audio-routing + - mediatek,audio-codec + +examples: + - | + sound { + compatible = "mediatek,mt79xx-wm8960-machine"; + mediatek,platform = <&afe>; + audio-routing = + "Headphone", "HP_L", + "Headphone", "HP_R", + "LINPUT1", "AMIC", + "RINPUT1", "AMIC"; + mediatek,audio-codec = <&wm8960>; + }; + +...