| Message ID | 20230606175246.190465-8-miquel.raynal@bootlin.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Prevent NAND chip unevaluated properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 06 Jun 2023 19:52:36 +0200, Miquel Raynal wrote: > List all the possible properties in the NAND chip as per the example and > set unevaluatedProperties to false in the NAND chip section. > > Cc: Paul Cercueil <paul@crapouillou.net> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > Documentation/devicetree/bindings/mtd/ingenic,nand.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mtd/ingenic,nand.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.example.dtb: nand-controller@1: nand@1: False schema does not allow {'reg': [[1]], 'nand-ecc-step-size': [[1024]], 'nand-ecc-strength': [[24]], 'nand-ecc-mode': ['hw'], 'nand-on-flash-bbt': True, 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'partitions': {'compatible': ['fixed-partitions'], '#address-cells': [[2]], '#size-cells': [[2]], 'partition@0': {'label': ['u-boot-spl'], 'reg': [[0, 0, 0, 8388608]]}, 'partition@800000': {'label': ['u-boot'], 'reg': [[0, 8388608, 0, 2097152]]}, 'partition@a00000': {'label': ['u-boot-env'], 'reg': [[0, 10485760, 0, 2097152]]}, 'partition@c00000': {'label': ['boot'], 'reg': [[0, 12582912, 0, 67108864]]}, 'partition@4c00000': {'label': ['system'], 'reg': [[0, 79691776, 1, 4215275520]]}}} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.example.dtb: nand-controller@1: nand@1: Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt', 'partitions', 'reg' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230606175246.190465-8-miquel.raynal@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Rob, robh@kernel.org wrote on Tue, 06 Jun 2023 12:52:00 -0600: > On Tue, 06 Jun 2023 19:52:36 +0200, Miquel Raynal wrote: > > List all the possible properties in the NAND chip as per the example and > > set unevaluatedProperties to false in the NAND chip section. > > > > Cc: Paul Cercueil <paul@crapouillou.net> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > Documentation/devicetree/bindings/mtd/ingenic,nand.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/mtd/ingenic,nand.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml It seems like your automated tooling failed to apply the second patch in this series (creating raw-nand-chip.yaml). It says "sha1 information is lacking or useless". This work is based on a recent -rc so I'm not sure what is "lacking or useless" in this case. Anyway, do you plan to give this series a look anyway? Or should I rebase against a specific branch? Thanks, Miquèl > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.example.dtb: nand-controller@1: nand@1: False schema does not allow {'reg': [[1]], 'nand-ecc-step-size': [[1024]], 'nand-ecc-strength': [[24]], 'nand-ecc-mode': ['hw'], 'nand-on-flash-bbt': True, 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'partitions': {'compatible': ['fixed-partitions'], '#address-cells': [[2]], '#size-cells': [[2]], 'partition@0': {'label': ['u-boot-spl'], 'reg': [[0, 0, 0, 8388608]]}, 'partition@800000': {'label': ['u-boot'], 'reg': [[0, 8388608, 0, 2097152]]}, 'partition@a00000': {'label': ['u-boot-env'], 'reg': [[0, 10485760, 0, 2097152]]}, 'partition@c00000': {'label': ['boot'], 'reg': [[0, 12582912, 0, 67108864]]}, 'partition@4c00000': {'label': ['system'], 'reg': [[0, 79691776, 1, 4215275520]]}}} > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.example.dtb: nand-controller@1: nand@1: Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt', 'partitions', 'reg' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230606175246.190465-8-miquel.raynal@bootlin.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
On Wed, Jun 07, 2023 at 11:33:14AM +0200, Miquel Raynal wrote: > Hi Rob, > > robh@kernel.org wrote on Tue, 06 Jun 2023 12:52:00 -0600: > > > On Tue, 06 Jun 2023 19:52:36 +0200, Miquel Raynal wrote: > > > List all the possible properties in the NAND chip as per the example and > > > set unevaluatedProperties to false in the NAND chip section. > > > > > > Cc: Paul Cercueil <paul@crapouillou.net> > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > --- > > > Documentation/devicetree/bindings/mtd/ingenic,nand.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > ./Documentation/devicetree/bindings/mtd/ingenic,nand.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml > > It seems like your automated tooling failed to apply the second patch > in this series (creating raw-nand-chip.yaml). It says "sha1 information > is lacking or useless". This work is based on a recent -rc so I'm not > sure what is "lacking or useless" in this case. The base used is rc1. > Anyway, do you plan to give this series a look anyway? Or should I > rebase against a specific branch? Yes, I'll leave it in the queue. I'm just getting back after being out a month. Rob
Hi Rob, robh@kernel.org wrote on Thu, 8 Jun 2023 09:20:41 -0600: > On Wed, Jun 07, 2023 at 11:33:14AM +0200, Miquel Raynal wrote: > > Hi Rob, > > > > robh@kernel.org wrote on Tue, 06 Jun 2023 12:52:00 -0600: > > > > > On Tue, 06 Jun 2023 19:52:36 +0200, Miquel Raynal wrote: > > > > List all the possible properties in the NAND chip as per the example and > > > > set unevaluatedProperties to false in the NAND chip section. > > > > > > > > Cc: Paul Cercueil <paul@crapouillou.net> > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > --- > > > > Documentation/devicetree/bindings/mtd/ingenic,nand.yaml | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > ./Documentation/devicetree/bindings/mtd/ingenic,nand.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml > > > > It seems like your automated tooling failed to apply the second patch > > in this series (creating raw-nand-chip.yaml). It says "sha1 information > > is lacking or useless". This work is based on a recent -rc so I'm not > > sure what is "lacking or useless" in this case. > > The base used is rc1. Ack. > > > Anyway, do you plan to give this series a look anyway? Or should I > > rebase against a specific branch? > > Yes, I'll leave it in the queue. I'm just getting back after being out a > month. Sure. Good luck with your month-old backlog :) Thanks, Miquèl
diff --git a/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml b/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml index a7bdb5d3675c..b9312ebefeb9 100644 --- a/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml +++ b/Documentation/devicetree/bindings/mtd/ingenic,nand.yaml @@ -39,7 +39,9 @@ properties: patternProperties: "^nand@[a-f0-9]$": type: object + $ref: raw-nand-chip.yaml properties: + rb-gpios: description: GPIO specifier for the busy pin. maxItems: 1 @@ -48,6 +50,8 @@ patternProperties: description: GPIO specifier for the write-protect pin. maxItems: 1 + unevaluatedProperties: false + required: - compatible - reg
List all the possible properties in the NAND chip as per the example and set unevaluatedProperties to false in the NAND chip section. Cc: Paul Cercueil <paul@crapouillou.net> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/mtd/ingenic,nand.yaml | 4 ++++ 1 file changed, 4 insertions(+)