[1/3] dt-bindings: arm: add TQMa8Xx boards

TQMa8Xx is a SOM series featuring NXP i.MX8X SoC.
They are called TQMa8XQP and TQMa8XDP respectively.
MBa8Xx is an evaluation mainboard for this SOM

Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Hi Alexander,

On 23-06-06, Alexander Stein wrote:
> TQMa8Xx is a SOM series featuring NXP i.MX8X SoC.
> They are called TQMa8XQP and TQMa8XDP respectively.
> MBa8Xx is an evaluation mainboard for this SOM
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 2510eaa8906dd..c4dcdac43bafb 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1195,6 +1195,23 @@ properties:
>            - const: toradex,colibri-imx8x
>            - const: fsl,imx8qxp
>  
> +      - description:
> +          TQMa8Xx is a series of SOM featuring NXP i.MX8X system-on-chip
> +          variants. It is designed to be clicked on different carrier boards
> +          MBa8Xx is the starterkit
> +        oneOf:
> +          - items:
> +              - enum:
> +                  - tq,imx8dxp-tqma8xdp-mba8xx # TQ-Systems GmbH TQMa8XDP SOM on MBa8Xx
> +              - const: tq,imx8dxp-tqma8xdp     # TQ-Systems GmbH TQMa8XDP SOM (with i.MX8DXP)
> +              - const: fsl,imx8dxp
> +              - const: fsl,imx8qxp
				^
Should be removed? The rest lgtm, so feel free to add my:

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Nit: Please check the dts(i) files for C++ comments '//' and replace
them with '/**/'. There was at least one C++ comment.

Regards,
  Marco

> +          - items:
> +              - enum:
> +                  - tq,imx8qxp-tqma8xqp-mba8xx # TQ-Systems GmbH TQMa8XQP SOM on MBa8Xx
> +              - const: tq,imx8qxp-tqma8xqp     # TQ-Systems GmbH TQMa8XQP SOM (with i.MX8QXP)
> +              - const: fsl,imx8qxp
> +
>        - description: i.MX8ULP based Boards
>          items:
>            - enum:
> -- 
> 2.34.1
> 
> 
>

Hi Marco,

thanks for the feedback.

Am Dienstag, 6. Juni 2023, 14:07:56 CEST schrieb Marco Felsch:
> Hi Alexander,
> 
> On 23-06-06, Alexander Stein wrote:
> > TQMa8Xx is a SOM series featuring NXP i.MX8X SoC.
> > They are called TQMa8XQP and TQMa8XDP respectively.
> > MBa8Xx is an evaluation mainboard for this SOM
> > 
> > Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml index
> > 2510eaa8906dd..c4dcdac43bafb 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > 
> > @@ -1195,6 +1195,23 @@ properties:
> >            - const: toradex,colibri-imx8x
> >            - const: fsl,imx8qxp
> > 
> > +      - description:
> > +          TQMa8Xx is a series of SOM featuring NXP i.MX8X system-on-chip
> > +          variants. It is designed to be clicked on different carrier
> > boards +          MBa8Xx is the starterkit
> > +        oneOf:
> > +          - items:
> > +              - enum:
> > +                  - tq,imx8dxp-tqma8xdp-mba8xx # TQ-Systems GmbH TQMa8XDP
> > SOM on MBa8Xx +              - const: tq,imx8dxp-tqma8xdp     #
> > TQ-Systems GmbH TQMa8XDP SOM (with i.MX8DXP) +              - const:
> > fsl,imx8dxp
> > +              - const: fsl,imx8qxp
> 
> 				^
> Should be removed? The rest lgtm, so feel free to add my:

As imx8dxp is missing completely, I think it's even better the not add this 
compatible for now.

> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Thanks, you meant this for this patch only or the whole series?

> Nit: Please check the dts(i) files for C++ comments '//' and replace
> them with '/**/'. There was at least one C++ comment.

Ah, you are right. Thanks.

Regards,
Alexander

> Regards,
>   Marco
> 
> > +          - items:
> > +              - enum:
> > +                  - tq,imx8qxp-tqma8xqp-mba8xx # TQ-Systems GmbH TQMa8XQP
> > SOM on MBa8Xx +              - const: tq,imx8qxp-tqma8xqp     #
> > TQ-Systems GmbH TQMa8XQP SOM (with i.MX8QXP) +              - const:
> > fsl,imx8qxp
> > +
> > 
> >        - description: i.MX8ULP based Boards
> >        
> >          items:
> >            - enum:

On Tue, Jun 06, 2023 at 02:07:30PM +0200, Marco Felsch wrote:
> Hi Alexander,
> 
> On 23-06-06, Alexander Stein wrote:
> > TQMa8Xx is a SOM series featuring NXP i.MX8X SoC.
> > They are called TQMa8XQP and TQMa8XDP respectively.
> > MBa8Xx is an evaluation mainboard for this SOM
> > 
> > Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 2510eaa8906dd..c4dcdac43bafb 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1195,6 +1195,23 @@ properties:
> >            - const: toradex,colibri-imx8x
> >            - const: fsl,imx8qxp
> >  
> > +      - description:
> > +          TQMa8Xx is a series of SOM featuring NXP i.MX8X system-on-chip
> > +          variants. It is designed to be clicked on different carrier boards
> > +          MBa8Xx is the starterkit
> > +        oneOf:
> > +          - items:
> > +              - enum:
> > +                  - tq,imx8dxp-tqma8xdp-mba8xx # TQ-Systems GmbH TQMa8XDP SOM on MBa8Xx
> > +              - const: tq,imx8dxp-tqma8xdp     # TQ-Systems GmbH TQMa8XDP SOM (with i.MX8DXP)
> > +              - const: fsl,imx8dxp
> > +              - const: fsl,imx8qxp
> 				^
> Should be removed? The rest lgtm, so feel free to add my:
> 
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Ye, with that removed, assuming it is a typo,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.