diff mbox series

[v2] dt-bindings: serial: 8250_omap: add rs485-rts-active-high

Message ID 20230531111038.6302-1-francesco@dolcini.it
State Not Applicable, archived
Headers show
Series [v2] dt-bindings: serial: 8250_omap: add rs485-rts-active-high | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 7 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Francesco Dolcini May 31, 2023, 11:10 a.m. UTC 
From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add rs485-rts-active-high property, this was removed by mistake.
In general we just use rs485-rts-active-low property, however the OMAP
UART for legacy reason uses the -high one.

Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
v2: removed reported-by
---
 Documentation/devicetree/bindings/serial/8250_omap.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski June 1, 2023, 10:12 a.m. UTC | #1 
On 31/05/2023 13:10, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Add rs485-rts-active-high property, this was removed by mistake.
> In general we just use rs485-rts-active-low property, however the OMAP
> UART for legacy reason uses the -high one.
> 
> Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Geert Uytterhoeven Oct. 19, 2023, 10:09 a.m. UTC | #2 
Hi Francesco,

On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Add rs485-rts-active-high property, this was removed by mistake.
> In general we just use rs485-rts-active-low property, however the OMAP
> UART for legacy reason uses the -high one.
>
> Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> v2: removed reported-by

Thanks for your patch, which is now commit 403e97d6ab2cb6fd
("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
in v6.4-rc5.

> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> @@ -70,6 +70,7 @@ properties:
>    dsr-gpios: true
>    rng-gpios: true
>    dcd-gpios: true
> +  rs485-rts-active-high: true

make dt_binding_check complains:

    Documentation/devicetree/bindings/serial/8250_omap.yaml:
rs485-rts-active-high: missing type definition

This property should have been added to
Documentation/devicetree/bindings/serial/serial.yaml first.

>    rts-gpio: true
>    power-domains: true
>    clock-frequency: true

Gr{oetje,eeting}s,

                        Geert
Francesco Dolcini Oct. 19, 2023, 3:05 p.m. UTC | #3 
Hello Geert,

On Thu, Oct 19, 2023 at 12:09:06PM +0200, Geert Uytterhoeven wrote:
> On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> >
> > Add rs485-rts-active-high property, this was removed by mistake.
> > In general we just use rs485-rts-active-low property, however the OMAP
> > UART for legacy reason uses the -high one.
> >
> > Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> > Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> > v2: removed reported-by
> 
> Thanks for your patch, which is now commit 403e97d6ab2cb6fd
> ("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
> in v6.4-rc5.
> 
> > --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > @@ -70,6 +70,7 @@ properties:
> >    dsr-gpios: true
> >    rng-gpios: true
> >    dcd-gpios: true
> > +  rs485-rts-active-high: true
> 
> make dt_binding_check complains:
> 
>     Documentation/devicetree/bindings/serial/8250_omap.yaml:
> rs485-rts-active-high: missing type definition

For some reasons it works for me (and worked when I did send the patch)

$ make dt_binding_check DT_SCHEMA_FILES=8250_omap.yaml
...
  HOSTCC  scripts/dtc/libfdt/fdt_overlay.o
  HOSTCC  scripts/dtc/fdtoverlay.o
  HOSTLD  scripts/dtc/fdtoverlay
  LINT    Documentation/devicetree/bindings
invalid config: unknown option "required" for rule "quoted-strings"
xargs: /usr/bin/yamllint: exited with status 255; aborting
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,ls-fs-output-impedance-bp
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: ignoring, error in schema: properties: gpio-controller
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,burnout-current-nanoamp
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: ignoring, error in schema: properties: adi,ext2-burnout-current-nanoamp
  DTEX    Documentation/devicetree/bindings/serial/8250_omap.example.dts
  DTC_CHK Documentation/devicetree/bindings/serial/8250_omap.example.dtb


any idea on what could be different between us?

> This property should have been added to
> Documentation/devicetree/bindings/serial/serial.yaml first.

Francesco
Geert Uytterhoeven Oct. 19, 2023, 3:13 p.m. UTC | #4 
Hi Franceso,

On Thu, Oct 19, 2023 at 5:05 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> On Thu, Oct 19, 2023 at 12:09:06PM +0200, Geert Uytterhoeven wrote:
> > On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> > > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > >
> > > Add rs485-rts-active-high property, this was removed by mistake.
> > > In general we just use rs485-rts-active-low property, however the OMAP
> > > UART for legacy reason uses the -high one.
> > >
> > > Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> > > Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > ---
> > > v2: removed reported-by
> >
> > Thanks for your patch, which is now commit 403e97d6ab2cb6fd
> > ("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
> > in v6.4-rc5.
> >
> > > --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > > +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > > @@ -70,6 +70,7 @@ properties:
> > >    dsr-gpios: true
> > >    rng-gpios: true
> > >    dcd-gpios: true
> > > +  rs485-rts-active-high: true
> >
> > make dt_binding_check complains:
> >
> >     Documentation/devicetree/bindings/serial/8250_omap.yaml:
> > rs485-rts-active-high: missing type definition
>
> For some reasons it works for me (and worked when I did send the patch)
>
> $ make dt_binding_check DT_SCHEMA_FILES=8250_omap.yaml
> ...
>   HOSTCC  scripts/dtc/libfdt/fdt_overlay.o
>   HOSTCC  scripts/dtc/fdtoverlay.o
>   HOSTLD  scripts/dtc/fdtoverlay
>   LINT    Documentation/devicetree/bindings
> invalid config: unknown option "required" for rule "quoted-strings"
> xargs: /usr/bin/yamllint: exited with status 255; aborting
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,ls-fs-output-impedance-bp
> /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: ignoring, error in schema: properties: gpio-controller
> /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
> /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,burnout-current-nanoamp
> /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: ignoring, error in schema: properties: adi,ext2-burnout-current-nanoamp
>   DTEX    Documentation/devicetree/bindings/serial/8250_omap.example.dts
>   DTC_CHK Documentation/devicetree/bindings/serial/8250_omap.example.dtb
>
>
> any idea on what could be different between us?

Are you using the latest dt-schema?

Gr{oetje,eeting}s,

                        Geert
Francesco Dolcini Oct. 19, 2023, 3:37 p.m. UTC | #5 
On Thu, Oct 19, 2023 at 05:13:01PM +0200, Geert Uytterhoeven wrote:
> Hi Franceso,
> 
> On Thu, Oct 19, 2023 at 5:05 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> > On Thu, Oct 19, 2023 at 12:09:06PM +0200, Geert Uytterhoeven wrote:
> > > On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> > > > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > >
> > > > Add rs485-rts-active-high property, this was removed by mistake.
> > > > In general we just use rs485-rts-active-low property, however the OMAP
> > > > UART for legacy reason uses the -high one.
> > > >
> > > > Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> > > > Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
> > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > ---
> > > > v2: removed reported-by
> > >
> > > Thanks for your patch, which is now commit 403e97d6ab2cb6fd
> > > ("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
> > > in v6.4-rc5.
> > >
> > > > --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > > > +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > > > @@ -70,6 +70,7 @@ properties:
> > > >    dsr-gpios: true
> > > >    rng-gpios: true
> > > >    dcd-gpios: true
> > > > +  rs485-rts-active-high: true
> > >
> > > make dt_binding_check complains:
> > >
> > >     Documentation/devicetree/bindings/serial/8250_omap.yaml:
> > > rs485-rts-active-high: missing type definition
> >
> > For some reasons it works for me (and worked when I did send the patch)
> >
> > $ make dt_binding_check DT_SCHEMA_FILES=8250_omap.yaml
> > ...
> >   HOSTCC  scripts/dtc/libfdt/fdt_overlay.o
> >   HOSTCC  scripts/dtc/fdtoverlay.o
> >   HOSTLD  scripts/dtc/fdtoverlay
> >   LINT    Documentation/devicetree/bindings
> > invalid config: unknown option "required" for rule "quoted-strings"
> > xargs: /usr/bin/yamllint: exited with status 255; aborting
> >   CHKDT   Documentation/devicetree/bindings/processed-schema.json
> >   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,ls-fs-output-impedance-bp
> > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: ignoring, error in schema: properties: gpio-controller
> > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
> > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,burnout-current-nanoamp
> > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: ignoring, error in schema: properties: adi,ext2-burnout-current-nanoamp
> >   DTEX    Documentation/devicetree/bindings/serial/8250_omap.example.dts
> >   DTC_CHK Documentation/devicetree/bindings/serial/8250_omap.example.dtb
> >
> >
> > any idea on what could be different between us?
> 
> Are you using the latest dt-schema?

Nope, and I tried to update it and now everything fails in a miserable
way.

In any case the fix is clear and I am pretty confident the issue I had is
what you just wrote, I'll send a patch.

Francesco
Rob Herring Oct. 19, 2023, 7:34 p.m. UTC | #6 
On Thu, Oct 19, 2023 at 10:37 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> On Thu, Oct 19, 2023 at 05:13:01PM +0200, Geert Uytterhoeven wrote:
> > Hi Franceso,
> >
> > On Thu, Oct 19, 2023 at 5:05 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> > > On Thu, Oct 19, 2023 at 12:09:06PM +0200, Geert Uytterhoeven wrote:
> > > > On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@dolcini.it> wrote:
> > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > >
> > > > > Add rs485-rts-active-high property, this was removed by mistake.
> > > > > In general we just use rs485-rts-active-low property, however the OMAP
> > > > > UART for legacy reason uses the -high one.
> > > > >
> > > > > Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> > > > > Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@francesco-nb.int.toradex.com/
> > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > > ---
> > > > > v2: removed reported-by
> > > >
> > > > Thanks for your patch, which is now commit 403e97d6ab2cb6fd
> > > > ("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
> > > > in v6.4-rc5.
> > > >
> > > > > --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > > > > +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > > > > @@ -70,6 +70,7 @@ properties:
> > > > >    dsr-gpios: true
> > > > >    rng-gpios: true
> > > > >    dcd-gpios: true
> > > > > +  rs485-rts-active-high: true
> > > >
> > > > make dt_binding_check complains:
> > > >
> > > >     Documentation/devicetree/bindings/serial/8250_omap.yaml:
> > > > rs485-rts-active-high: missing type definition
> > >
> > > For some reasons it works for me (and worked when I did send the patch)
> > >
> > > $ make dt_binding_check DT_SCHEMA_FILES=8250_omap.yaml
> > > ...
> > >   HOSTCC  scripts/dtc/libfdt/fdt_overlay.o
> > >   HOSTCC  scripts/dtc/fdtoverlay.o
> > >   HOSTLD  scripts/dtc/fdtoverlay
> > >   LINT    Documentation/devicetree/bindings
> > > invalid config: unknown option "required" for rule "quoted-strings"
> > > xargs: /usr/bin/yamllint: exited with status 255; aborting
> > >   CHKDT   Documentation/devicetree/bindings/processed-schema.json
> > >   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> > > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,ls-fs-output-impedance-bp
> > > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: ignoring, error in schema: properties: gpio-controller
> > > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
> > > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,burnout-current-nanoamp
> > > /home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: ignoring, error in schema: properties: adi,ext2-burnout-current-nanoamp
> > >   DTEX    Documentation/devicetree/bindings/serial/8250_omap.example.dts
> > >   DTC_CHK Documentation/devicetree/bindings/serial/8250_omap.example.dtb
> > >
> > >
> > > any idea on what could be different between us?
> >
> > Are you using the latest dt-schema?

Indeed, it is a new check.

> Nope, and I tried to update it and now everything fails in a miserable
> way.

Do you have more details?

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml
index eb3488d8f9ee..6a7be42da523 100644
--- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
+++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
@@ -70,6 +70,7 @@  properties:
   dsr-gpios: true
   rng-gpios: true
   dcd-gpios: true
+  rs485-rts-active-high: true
   rts-gpio: true
   power-domains: true
   clock-frequency: true