| Message ID | 20230522193219.1477158-1-tharvey@gateworks.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, May 22, 2023 at 12:32:17PM -0700, Tim Harvey wrote: > Remove the invalid #address-cells and #size-cells nodes from > the fan-controller. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Applied 2/4, 3/4 and 4/4, thanks!
On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote: > Remove the unnecessary #address-cells and #size-cells nodes from > the fan-controller. These are not needed as the fan controller does not > have any children. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > v2: > - udpated commit log to explain why the nodes are unnessesary > - added Krzysztof's rb tag > - added Connor's ab tag > --- > .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ---------- > 1 file changed, 10 deletions(-) This is not going to get applied if you don't send it to Lee. > > diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > index acb9c54942d9..dc379f3ebf24 100644 > --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > @@ -122,12 +122,6 @@ patternProperties: > compatible: > const: gw,gsc-fan > > - "#address-cells": > - const: 1 > - > - "#size-cells": > - const: 0 > - > reg: > description: The fan controller base address > maxItems: 1 > @@ -135,8 +129,6 @@ patternProperties: > required: > - compatible > - reg > - - "#address-cells" > - - "#size-cells" > > required: > - compatible > @@ -194,8 +186,6 @@ examples: > }; > > fan-controller@2c { > - #address-cells = <1>; > - #size-cells = <0>; > compatible = "gw,gsc-fan"; > reg = <0x2c>; > }; > -- > 2.25.1 >
On Fri, Jun 9, 2023 at 9:00 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote: > > Remove the unnecessary #address-cells and #size-cells nodes from > > the fan-controller. These are not needed as the fan controller does not > > have any children. > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > v2: > > - udpated commit log to explain why the nodes are unnessesary > > - added Krzysztof's rb tag > > - added Connor's ab tag > > --- > > .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ---------- > > 1 file changed, 10 deletions(-) > > This is not going to get applied if you don't send it to Lee. Lee, Sorry, I missed adding you to this thread. Can you pick it up or do you need me to re-send to the list and you? Best Regards, Tim > > > > > diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > > index acb9c54942d9..dc379f3ebf24 100644 > > --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > > +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > > @@ -122,12 +122,6 @@ patternProperties: > > compatible: > > const: gw,gsc-fan > > > > - "#address-cells": > > - const: 1 > > - > > - "#size-cells": > > - const: 0 > > - > > reg: > > description: The fan controller base address > > maxItems: 1 > > @@ -135,8 +129,6 @@ patternProperties: > > required: > > - compatible > > - reg > > - - "#address-cells" > > - - "#size-cells" > > > > required: > > - compatible > > @@ -194,8 +186,6 @@ examples: > > }; > > > > fan-controller@2c { > > - #address-cells = <1>; > > - #size-cells = <0>; > > compatible = "gw,gsc-fan"; > > reg = <0x2c>; > > }; > > -- > > 2.25.1 > >
On Fri, 09 Jun 2023, Tim Harvey wrote: > On Fri, Jun 9, 2023 at 9:00 AM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote: > > > Remove the unnecessary #address-cells and #size-cells nodes from > > > the fan-controller. These are not needed as the fan controller does not > > > have any children. > > > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > v2: > > > - udpated commit log to explain why the nodes are unnessesary > > > - added Krzysztof's rb tag > > > - added Connor's ab tag > > > --- > > > .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ---------- > > > 1 file changed, 10 deletions(-) > > > > This is not going to get applied if you don't send it to Lee. > > Lee, > > Sorry, I missed adding you to this thread. Can you pick it up or do > you need me to re-send to the list and you? I need you to resend it please.
diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml index acb9c54942d9..dc379f3ebf24 100644 --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml @@ -122,12 +122,6 @@ patternProperties: compatible: const: gw,gsc-fan - "#address-cells": - const: 1 - - "#size-cells": - const: 0 - reg: description: The fan controller base address maxItems: 1 @@ -135,8 +129,6 @@ patternProperties: required: - compatible - reg - - "#address-cells" - - "#size-cells" required: - compatible @@ -194,8 +186,6 @@ examples: }; fan-controller@2c { - #address-cells = <1>; - #size-cells = <0>; compatible = "gw,gsc-fan"; reg = <0x2c>; };