| Message ID | 20230406135552.23980-2-sebastian.reichel@collabora.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | generic-ohci/ehci: add RK3588 support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Apr 06, 2023 at 03:55:50PM +0200, Sebastian Reichel wrote: > Add compatible for RK3588 OHCI. As far as I know it's fully > compatible with generic-ohci. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index a9ba7257b884..e116ed90471e 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -44,6 +44,7 @@ properties: > - hpe,gxp-ohci > - ibm,476gtr-ohci > - ingenic,jz4740-ohci > + - rockchip,rk3588-ohci > - snps,hsdk-v1.0-ohci > - const: generic-ohci > - enum: > @@ -69,7 +70,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 > description: | > In case the Renesas R-Car Gen3 SoCs: > - if a host only channel: first clock should be host. > @@ -147,6 +148,21 @@ allOf: > then: > properties: > transceiver: false > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3588-ohci > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 Only need minItems here. > + else: > + properties: > + clocks: > + minItems: 1 > + maxItems: 3 Only need maxItems here. With that, Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml index a9ba7257b884..e116ed90471e 100644 --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml @@ -44,6 +44,7 @@ properties: - hpe,gxp-ohci - ibm,476gtr-ohci - ingenic,jz4740-ohci + - rockchip,rk3588-ohci - snps,hsdk-v1.0-ohci - const: generic-ohci - enum: @@ -69,7 +70,7 @@ properties: clocks: minItems: 1 - maxItems: 3 + maxItems: 4 description: | In case the Renesas R-Car Gen3 SoCs: - if a host only channel: first clock should be host. @@ -147,6 +148,21 @@ allOf: then: properties: transceiver: false + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-ohci + then: + properties: + clocks: + minItems: 4 + maxItems: 4 + else: + properties: + clocks: + minItems: 1 + maxItems: 3 additionalProperties: false
Add compatible for RK3588 OHCI. As far as I know it's fully compatible with generic-ohci. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- .../devicetree/bindings/usb/generic-ohci.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)