| Message ID | 20230405125759.4201-2-quic_kriskura@quicinc.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add multiport support for DWC3 controllers | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 05/04/2023 14:57, Krishna Kurapati wrote: > Add bindings to indicate properties required to support multiport > on Snps Dwc3 controller. > > Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ You did not test it at v4 and you got report for this. Your changelog in commit msg does not mention fixing it. It looks like you did not test it for the second time (or sixth time). Best regards, Krzysztof
On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote: > On 05/04/2023 14:57, Krishna Kurapati wrote: >> Add bindings to indicate properties required to support multiport >> on Snps Dwc3 controller. >> >> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >> --- >> Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ > > You did not test it at v4 and you got report for this. Your changelog in > commit msg does not mention fixing it. > > It looks like you did not test it for the second time (or sixth time). > > Best regards, > Krzysztof > Hi Krzysztof, I did do a dt_binding_check and I got the following result: kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$ make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml HOSTCC scripts/basic/fixdep HOSTCC scripts/dtc/dtc.o HOSTCC scripts/dtc/flattree.o HOSTCC scripts/dtc/fstree.o HOSTCC scripts/dtc/data.o HOSTCC scripts/dtc/livetree.o HOSTCC scripts/dtc/treesource.o HOSTCC scripts/dtc/srcpos.o HOSTCC scripts/dtc/checks.o HOSTCC scripts/dtc/util.o LEX scripts/dtc/dtc-lexer.lex.c YACC scripts/dtc/dtc-parser.tab.[ch] HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTLD scripts/dtc/dtc LINT Documentation/devicetree/bindings invalid config: unknown option "max-spaces-inside-empty" for rule "brackets" xargs: /usr/bin/yamllint: exited with status 255; aborting CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,pre-emphasis-duration-bp /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: ignoring, error in schema: properties: gpio-controller /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,excitation-current-0-nanoamp DTEX Documentation/devicetree/bindings/usb/snps,dwc3.example.dts DTC_CHK Documentation/devicetree/bindings/usb/snps,dwc3.example.dtb I can try upgrading the dt-schema and try again. Regards, Krishna,
On 05/04/2023 16:15, Krishna Kurapati PSSNV wrote: > > > On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote: >> On 05/04/2023 14:57, Krishna Kurapati wrote: >>> Add bindings to indicate properties required to support multiport >>> on Snps Dwc3 controller. >>> >>> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> >>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >>> --- >>> Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ >> >> You did not test it at v4 and you got report for this. Your changelog in >> commit msg does not mention fixing it. >> >> It looks like you did not test it for the second time (or sixth time). >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > > I did do a dt_binding_check and I got the following result: > > kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$ > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml > HOSTCC scripts/basic/fixdep > HOSTCC scripts/dtc/dtc.o > HOSTCC scripts/dtc/flattree.o > HOSTCC scripts/dtc/fstree.o > HOSTCC scripts/dtc/data.o > HOSTCC scripts/dtc/livetree.o > HOSTCC scripts/dtc/treesource.o > HOSTCC scripts/dtc/srcpos.o > HOSTCC scripts/dtc/checks.o > HOSTCC scripts/dtc/util.o > LEX scripts/dtc/dtc-lexer.lex.c > YACC scripts/dtc/dtc-parser.tab.[ch] > HOSTCC scripts/dtc/dtc-lexer.lex.o > HOSTCC scripts/dtc/dtc-parser.tab.o > HOSTLD scripts/dtc/dtc > LINT Documentation/devicetree/bindings > invalid config: unknown option "max-spaces-inside-empty" for rule "brackets" > xargs: /usr/bin/yamllint: exited with status 255; aborting > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: > ignoring, error in schema: properties: qcom,pre-emphasis-duration-bp > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: > ignoring, error in schema: properties: gpio-controller > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: > ignoring, error in schema: patternProperties: ^thermistor@: properties: > adi,excitation-current-nanoamp > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: > ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: > properties: adi,excitation-current-0-nanoamp All these are some errors, maybe coming from your schema, maybe from next. You can narrow the tests with DT_SCHEMA_FILES (as mentioned in guide). Best regards, Krzysztof
On Wed, 05 Apr 2023 18:27:52 +0530, Krishna Kurapati wrote: > Add bindings to indicate properties required to support multiport > on Snps Dwc3 controller. > > Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ > > .../devicetree/bindings/usb/snps,dwc3.yaml | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:90:5: [warning] wrong indentation: expected 6 but found 4 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230405125759.4201-2-quic_kriskura@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Apr 05, 2023 at 07:45:07PM +0530, Krishna Kurapati PSSNV wrote: > > > On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote: > > On 05/04/2023 14:57, Krishna Kurapati wrote: > > > Add bindings to indicate properties required to support multiport > > > on Snps Dwc3 controller. > > > > > > Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > > --- > > > Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ > > > > You did not test it at v4 and you got report for this. Your changelog in > > commit msg does not mention fixing it. > > > > It looks like you did not test it for the second time (or sixth time). > > > > Best regards, > > Krzysztof > > > Hi Krzysztof, > > I did do a dt_binding_check and I got the following result: > > kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$ > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml > HOSTCC scripts/basic/fixdep > HOSTCC scripts/dtc/dtc.o > HOSTCC scripts/dtc/flattree.o > HOSTCC scripts/dtc/fstree.o > HOSTCC scripts/dtc/data.o > HOSTCC scripts/dtc/livetree.o > HOSTCC scripts/dtc/treesource.o > HOSTCC scripts/dtc/srcpos.o > HOSTCC scripts/dtc/checks.o > HOSTCC scripts/dtc/util.o > LEX scripts/dtc/dtc-lexer.lex.c > YACC scripts/dtc/dtc-parser.tab.[ch] > HOSTCC scripts/dtc/dtc-lexer.lex.o > HOSTCC scripts/dtc/dtc-parser.tab.o > HOSTLD scripts/dtc/dtc > LINT Documentation/devicetree/bindings > invalid config: unknown option "max-spaces-inside-empty" for rule "brackets" > xargs: /usr/bin/yamllint: exited with status 255; aborting This indicates your yamllint version is too old. Rob
On 4/6/2023 1:47 AM, Rob Herring wrote: > On Wed, Apr 05, 2023 at 07:45:07PM +0530, Krishna Kurapati PSSNV wrote: >> >> >> On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote: >>> On 05/04/2023 14:57, Krishna Kurapati wrote: >>>> Add bindings to indicate properties required to support multiport >>>> on Snps Dwc3 controller. >>>> >>>> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> >>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >>>> --- >>>> Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ >>> >>> You did not test it at v4 and you got report for this. Your changelog in >>> commit msg does not mention fixing it. >>> >>> It looks like you did not test it for the second time (or sixth time). >>> >>> Best regards, >>> Krzysztof >>> >> Hi Krzysztof, >> >> I did do a dt_binding_check and I got the following result: >> >> kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$ >> make DT_CHECKER_FLAGS=-m dt_binding_check >> DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> HOSTCC scripts/basic/fixdep >> HOSTCC scripts/dtc/dtc.o >> HOSTCC scripts/dtc/flattree.o >> HOSTCC scripts/dtc/fstree.o >> HOSTCC scripts/dtc/data.o >> HOSTCC scripts/dtc/livetree.o >> HOSTCC scripts/dtc/treesource.o >> HOSTCC scripts/dtc/srcpos.o >> HOSTCC scripts/dtc/checks.o >> HOSTCC scripts/dtc/util.o >> LEX scripts/dtc/dtc-lexer.lex.c >> YACC scripts/dtc/dtc-parser.tab.[ch] >> HOSTCC scripts/dtc/dtc-lexer.lex.o >> HOSTCC scripts/dtc/dtc-parser.tab.o >> HOSTLD scripts/dtc/dtc >> LINT Documentation/devicetree/bindings >> invalid config: unknown option "max-spaces-inside-empty" for rule "brackets" >> xargs: /usr/bin/yamllint: exited with status 255; aborting > > This indicates your yamllint version is too old. > > Rob Let me give a try with latest version. Thanks for pointing it out. 🙂 Regards, Krishna,
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index be36956af53b..96701eb5a17c 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -81,15 +81,16 @@ properties: phys: minItems: 1 - maxItems: 2 + maxItems: 8 phy-names: minItems: 1 - maxItems: 2 - items: - enum: - - usb2-phy - - usb3-phy + maxItems: 8 + oneOf: + - items: + enum: [ usb2-phy, usb3-phy ] + - items: + pattern: "^usb[23]-port[0-3]$" power-domains: description:
Add bindings to indicate properties required to support multiport on Snps Dwc3 controller. Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ .../devicetree/bindings/usb/snps,dwc3.yaml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)