| Message ID | 20230314080917.68246-3-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | mailbox/arm64/ qcom: rework compatibles for fallback | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 11 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, 14 Mar 2023 09:09:06 +0100, Krzysztof Kozlowski wrote: > The qcom,sdx55-apcs-gcc is followed by another compatible (syscon), thus > the 'if' clause must match by contains. > > Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, Mar 14, 2023 at 09:09:06AM +0100, Krzysztof Kozlowski wrote: > The qcom,sdx55-apcs-gcc is followed by another compatible (syscon), thus > the 'if' clause must match by contains. > > Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Manivannan Sadhasivam <mani@kernel.org> Thanks, Mani > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 2992227631c4..4d2f408a5efb 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -91,8 +91,9 @@ allOf: > - if: > properties: > compatible: > - enum: > - - qcom,sdx55-apcs-gcc > + contains: > + enum: > + - qcom,sdx55-apcs-gcc > then: > properties: > clocks: > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 2992227631c4..4d2f408a5efb 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -91,8 +91,9 @@ allOf: - if: properties: compatible: - enum: - - qcom,sdx55-apcs-gcc + contains: + enum: + - qcom,sdx55-apcs-gcc then: properties: clocks:
The qcom,sdx55-apcs-gcc is followed by another compatible (syscon), thus the 'if' clause must match by contains. Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)