| Message ID | 20230128111114.4049-2-sven@svenpeter.dev |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Apple M1 USB4/Thunderbolt DART support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 28/01/2023 20.11, Sven Peter wrote: > This DART variant is found in the t8103 (M1) SoCs and used for the > USB4/Thunderbolt PCIe ports. Unlike the regular t8103 DART these support > up to 64 SIDs and require a slightly different MMIO layout. This variant > is only found on the M1 SoCs. > > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > Documentation/devicetree/bindings/iommu/apple,dart.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iommu/apple,dart.yaml b/Documentation/devicetree/bindings/iommu/apple,dart.yaml > index 903edf85d72e..f9c1843c074d 100644 > --- a/Documentation/devicetree/bindings/iommu/apple,dart.yaml > +++ b/Documentation/devicetree/bindings/iommu/apple,dart.yaml > @@ -24,6 +24,7 @@ properties: > compatible: > enum: > - apple,t8103-dart > + - apple,t8103-dart-usb4 > - apple,t8110-dart > - apple,t6000-dart > You probably wanted t8103-usb4-dart (as mentioned in the commit message). Other than that, Acked-by: Hector Martin <marcan@marcan.st> - Hector
On Sat, Jan 28, 2023 at 12:11:11PM +0100, Sven Peter wrote: > This DART variant is found in the t8103 (M1) SoCs and used for the > USB4/Thunderbolt PCIe ports. Unlike the regular t8103 DART these support > up to 64 SIDs and require a slightly different MMIO layout. This variant > is only found on the M1 SoCs. Looks fine to me other than the discrepancy in the name. > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > Documentation/devicetree/bindings/iommu/apple,dart.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iommu/apple,dart.yaml b/Documentation/devicetree/bindings/iommu/apple,dart.yaml > index 903edf85d72e..f9c1843c074d 100644 > --- a/Documentation/devicetree/bindings/iommu/apple,dart.yaml > +++ b/Documentation/devicetree/bindings/iommu/apple,dart.yaml > @@ -24,6 +24,7 @@ properties: > compatible: > enum: > - apple,t8103-dart > + - apple,t8103-dart-usb4 > - apple,t8110-dart > - apple,t6000-dart > > -- > 2.25.1 >
diff --git a/Documentation/devicetree/bindings/iommu/apple,dart.yaml b/Documentation/devicetree/bindings/iommu/apple,dart.yaml index 903edf85d72e..f9c1843c074d 100644 --- a/Documentation/devicetree/bindings/iommu/apple,dart.yaml +++ b/Documentation/devicetree/bindings/iommu/apple,dart.yaml @@ -24,6 +24,7 @@ properties: compatible: enum: - apple,t8103-dart + - apple,t8103-dart-usb4 - apple,t8110-dart - apple,t6000-dart
This DART variant is found in the t8103 (M1) SoCs and used for the USB4/Thunderbolt PCIe ports. Unlike the regular t8103 DART these support up to 64 SIDs and require a slightly different MMIO layout. This variant is only found on the M1 SoCs. Signed-off-by: Sven Peter <sven@svenpeter.dev> --- Documentation/devicetree/bindings/iommu/apple,dart.yaml | 1 + 1 file changed, 1 insertion(+)