| Message ID | 20221229151648.19839-2-stephan@gerhold.net |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Fix APR audio regression on 6.2-rc1 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 3 warnings, 16 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Dec 29, 2022 at 04:16:47PM +0100, Stephan Gerhold wrote: > The protection domain functionality exists only in SoCs starting from > MSM8998 [1], while the APR bindings are also used on older platforms. > > Commit 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to > shared schema") made the "qcom,protection-domain" required but it > should remain optional to avoid dtbs_check warnings on older platforms, > e.g.: > > arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: > apr: service@3: 'qcom,protection-domain' is a required property > From schema: Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > > [1]: https://lore.kernel.org/all/20200312120842.21991-1-sibis@codeaurora.org/ > > Fixes: 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to shared schema") > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn > --- > .../devicetree/bindings/soc/qcom/qcom,apr-services.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > index 290555426c39..bdf482db32aa 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > @@ -39,8 +39,8 @@ properties: > qcom,protection-domain: > $ref: /schemas/types.yaml#/definitions/string-array > description: | > - Protection domain service name and path for APR service > - possible values are:: > + Protection domain service name and path for APR service (if supported). > + Possible values are:: > "avs/audio", "msm/adsp/audio_pd". > "kernel/elf_loader", "msm/modem/wlan_pd". > "tms/servreg", "msm/adsp/audio_pd". > @@ -49,6 +49,5 @@ properties: > > required: > - reg > - - qcom,protection-domain > > additionalProperties: true > -- > 2.39.0 >
On 29/12/2022 16:16, Stephan Gerhold wrote: > The protection domain functionality exists only in SoCs starting from > MSM8998 [1], while the APR bindings are also used on older platforms. > > Commit 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to > shared schema") made the "qcom,protection-domain" required but it > should remain optional to avoid dtbs_check warnings on older platforms, > e.g.: > > arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: > apr: service@3: 'qcom,protection-domain' is a required property > From schema: Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > > [1]: https://lore.kernel.org/all/20200312120842.21991-1-sibis@codeaurora.org/ > > Fixes: 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to shared schema") > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml index 290555426c39..bdf482db32aa 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml @@ -39,8 +39,8 @@ properties: qcom,protection-domain: $ref: /schemas/types.yaml#/definitions/string-array description: | - Protection domain service name and path for APR service - possible values are:: + Protection domain service name and path for APR service (if supported). + Possible values are:: "avs/audio", "msm/adsp/audio_pd". "kernel/elf_loader", "msm/modem/wlan_pd". "tms/servreg", "msm/adsp/audio_pd". @@ -49,6 +49,5 @@ properties: required: - reg - - qcom,protection-domain additionalProperties: true
The protection domain functionality exists only in SoCs starting from MSM8998 [1], while the APR bindings are also used on older platforms. Commit 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to shared schema") made the "qcom,protection-domain" required but it should remain optional to avoid dtbs_check warnings on older platforms, e.g.: arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: apr: service@3: 'qcom,protection-domain' is a required property From schema: Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml [1]: https://lore.kernel.org/all/20200312120842.21991-1-sibis@codeaurora.org/ Fixes: 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to shared schema") Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- .../devicetree/bindings/soc/qcom/qcom,apr-services.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)