diff mbox series

[v2,1/4] dt-bindings: arm: Move MX8Menlo board to i.MX8M Mini Toradex Verdin SoM entry

Message ID 20221216210244.591865-1-marex@denx.de
State Not Applicable, archived
Headers show
Series [v2,1/4] dt-bindings: arm: Move MX8Menlo board to i.MX8M Mini Toradex Verdin SoM entry | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied fail build log

Commit Message

Marek Vasut Dec. 16, 2022, 9:02 p.m. UTC
The MX8Menlo board is based on i.MX8M Mini Toradex Verdin SoM
which results in compatible string in the form:
"vendor,custom-board", "toradex,som-nonwifi", "toradex,som", "fsl,soc"
Move the binding entry so this quadruplet can be matched on.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@denx.de>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: devicetree@vger.kernel.org
To: linux-arm-kernel@lists.infradead.org
---
V2: - Rework the patch
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Francesco Dolcini Dec. 16, 2022, 9:25 p.m. UTC | #1
On Fri, Dec 16, 2022 at 10:02:41PM +0100, Marek Vasut wrote:
> The MX8Menlo board is based on i.MX8M Mini Toradex Verdin SoM
> which results in compatible string in the form:
> "vendor,custom-board", "toradex,som-nonwifi", "toradex,som", "fsl,soc"
> Move the binding entry so this quadruplet can be matched on.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>


> ---
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Francesco Dolcini <francesco.dolcini@toradex.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: devicetree@vger.kernel.org
> To: linux-arm-kernel@lists.infradead.org
> ---
> V2: - Rework the patch
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 05b5276a0e14c..cd3078768887a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -830,7 +830,6 @@ properties:
>                - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
>                - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
>                - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
> -              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
>                - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
>                - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
>                - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
> @@ -861,6 +860,7 @@ properties:
>        - description: Toradex Boards with Verdin iMX8M Mini Modules
>          items:
>            - enum:
> +              - menlo,mx8menlo                       # Verdin iMX8M Mini Module on i.MX8MM Menlo board
>                - toradex,verdin-imx8mm-nonwifi-dahlia # Verdin iMX8M Mini Module on Dahlia
>                - toradex,verdin-imx8mm-nonwifi-dev    # Verdin iMX8M Mini Module on Verdin Development Board
>            - const: toradex,verdin-imx8mm-nonwifi     # Verdin iMX8M Mini Module without Wi-Fi / BT
> -- 
> 2.35.1
>
Marek Vasut Dec. 16, 2022, 9:35 p.m. UTC | #2
On 12/16/22 22:25, Francesco Dolcini wrote:
> On Fri, Dec 16, 2022 at 10:02:41PM +0100, Marek Vasut wrote:
>> The MX8Menlo board is based on i.MX8M Mini Toradex Verdin SoM
>> which results in compatible string in the form:
>> "vendor,custom-board", "toradex,som-nonwifi", "toradex,som", "fsl,soc"
>> Move the binding entry so this quadruplet can be matched on.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Thank you

Rob/Krzysztof, this one patch will generate new validation warning. A 
counterpart patch to properly fix it is posted:

https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221216210150.591838-1-marex@denx.de/
Rob Herring (Arm) Dec. 20, 2022, 6:21 p.m. UTC | #3
On Fri, 16 Dec 2022 22:02:41 +0100, Marek Vasut wrote:
> The MX8Menlo board is based on i.MX8M Mini Toradex Verdin SoM
> which results in compatible string in the form:
> "vendor,custom-board", "toradex,som-nonwifi", "toradex,som", "fsl,soc"
> Move the binding entry so this quadruplet can be matched on.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Francesco Dolcini <francesco.dolcini@toradex.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: devicetree@vger.kernel.org
> To: linux-arm-kernel@lists.infradead.org
> ---
> V2: - Rework the patch
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski Dec. 21, 2022, 8:36 a.m. UTC | #4
On 16/12/2022 22:02, Marek Vasut wrote:
> The MX8Menlo board is based on i.MX8M Mini Toradex Verdin SoM
> which results in compatible string in the form:
> "vendor,custom-board", "toradex,som-nonwifi", "toradex,som", "fsl,soc"
> Move the binding entry so this quadruplet can be matched on.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 05b5276a0e14c..cd3078768887a 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -830,7 +830,6 @@  properties:
               - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
               - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
               - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
-              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
               - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
               - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
               - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
@@ -861,6 +860,7 @@  properties:
       - description: Toradex Boards with Verdin iMX8M Mini Modules
         items:
           - enum:
+              - menlo,mx8menlo                       # Verdin iMX8M Mini Module on i.MX8MM Menlo board
               - toradex,verdin-imx8mm-nonwifi-dahlia # Verdin iMX8M Mini Module on Dahlia
               - toradex,verdin-imx8mm-nonwifi-dev    # Verdin iMX8M Mini Module on Verdin Development Board
           - const: toradex,verdin-imx8mm-nonwifi     # Verdin iMX8M Mini Module without Wi-Fi / BT