| Message ID | 20221213082449.2721-7-hayashi.kunihiko@socionext.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 13/12/2022 09:24, Kunihiko Hayashi wrote: > Prior to adding dt-bindings for SoC-dependent controllers, rename the > thermal node and its parent node to the generic names in the example. > > And drop a parent node of the thermal-sensor as it is not directly Drop double space in "thermal-sensor as" above With this: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2022/12/13 23:54, Krzysztof Kozlowski wrote: > On 13/12/2022 09:24, Kunihiko Hayashi wrote: >> Prior to adding dt-bindings for SoC-dependent controllers, rename the >> thermal node and its parent node to the generic names in the example. >> >> And drop a parent node of the thermal-sensor as it is not directly > > Drop double space in "thermal-sensor as" above I'll fix it. > With this: > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thank you, --- Best Regards Kunihiko Hayashi
diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml index c5b25ce44956..6f975821fa5e 100644 --- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml @@ -46,14 +46,9 @@ examples: - | // The UniPhier thermal should be a subnode of a "syscon" compatible node. - sysctrl@61840000 { - compatible = "socionext,uniphier-ld20-sysctrl", - "simple-mfd", "syscon"; - reg = <0x61840000 0x10000>; - - pvtctl: thermal { - compatible = "socionext,uniphier-ld20-thermal"; - interrupts = <0 3 1>; - #thermal-sensor-cells = <0>; - }; + #include <dt-bindings/interrupt-controller/arm-gic.h> + pvtctl: thermal-sensor { + compatible = "socionext,uniphier-ld20-thermal"; + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; + #thermal-sensor-cells = <0>; };
Prior to adding dt-bindings for SoC-dependent controllers, rename the thermal node and its parent node to the generic names in the example. And drop a parent node of the thermal-sensor as it is not directly necessary. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../thermal/socionext,uniphier-thermal.yaml | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)