diff mbox series

[v3] dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property

Message ID 20221212055137.270638-1-marex@denx.de
State Changes Requested, archived
Headers show
Series [v3] dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Marek Vasut Dec. 12, 2022, 5:51 a.m. UTC 
The power-domains property is mandatory on i.MX8M Mini, Nano, Plus
and i.MX6SX, i.MX6SL. Document the property and mark it as required
on the aforementioned variants of the IP, present in those SoCs.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
To: devicetree@vger.kernel.org
---
V2: - Add AB from Krzysztof
    - Add mx6sx power domain into the list
V3: - Update commit message
    - Add i.MX6SL
    - Update example
---
 .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Ying Liu Dec. 12, 2022, 6:45 a.m. UTC | #1 
On Mon, 2022-12-12 at 06:51 +0100, Marek Vasut wrote:
> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus
> and i.MX6SX, i.MX6SL. Document the property and mark it as required
> on the aforementioned variants of the IP, present in those SoCs.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> To: devicetree@vger.kernel.org
> ---
> V2: - Add AB from Krzysztof
>     - Add mx6sx power domain into the list
> V3: - Update commit message
>     - Add i.MX6SL
>     - Update example
> ---
>  .../devicetree/bindings/display/fsl,lcdif.yaml  | 17
> +++++++++++++++++
>  1 file changed, 17 insertions(+)

Reviewed-by: Liu Ying <victor.liu@nxp.com>
Rob Herring Dec. 12, 2022, 12:54 p.m. UTC | #2 
On Sun, Dec 11, 2022 at 11:51 PM Marek Vasut <marex@denx.de> wrote:
>
> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus
> and i.MX6SX, i.MX6SL. Document the property and mark it as required
> on the aforementioned variants of the IP, present in those SoCs.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> To: devicetree@vger.kernel.org
> ---
> V2: - Add AB from Krzysztof
>     - Add mx6sx power domain into the list
> V3: - Update commit message
>     - Add i.MX6SL
>     - Update example
> ---
>  .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 876015a44a1e6..1f17be501749b 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -52,6 +52,9 @@ properties:
>    interrupts:
>      maxItems: 1
>
> +  power-domains:
> +    maxItems: 1
> +

This conflicts with adding 'power-domains' for i.MX8MP in my tree.

>    port:
>      $ref: /schemas/graph.yaml#/properties/port
>      description: The LCDIF output port
> @@ -87,6 +90,19 @@ allOf:
>            maxItems: 1
>          clock-names:
>            maxItems: 1
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx6sl-lcdif
> +              - fsl,imx6sx-lcdif
> +              - fsl,imx8mm-lcdif
> +              - fsl,imx8mn-lcdif
> +              - fsl,imx8mp-lcdif
> +    then:
> +      required:
> +        - power-domains
>
>  examples:
>    - |
> @@ -101,6 +117,7 @@ examples:
>                   <&clks IMX6SX_CLK_LCDIF_APB>,
>                   <&clks IMX6SX_CLK_DISPLAY_AXI>;
>          clock-names = "pix", "axi", "disp_axi";
> +        power-domains = <&pd_disp>;
>
>          port {
>              endpoint {
> --
> 2.35.1
>
Krzysztof Kozlowski Dec. 13, 2022, 7:57 a.m. UTC | #3 
On 12/12/2022 13:54, Rob Herring wrote:
> On Sun, Dec 11, 2022 at 11:51 PM Marek Vasut <marex@denx.de> wrote:
>>
>> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus
>> and i.MX6SX, i.MX6SL. Document the property and mark it as required
>> on the aforementioned variants of the IP, present in those SoCs.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>> Cc: Liu Ying <victor.liu@nxp.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: linux-arm-kernel@lists.infradead.org
>> To: devicetree@vger.kernel.org
>> ---
>> V2: - Add AB from Krzysztof
>>     - Add mx6sx power domain into the list
>> V3: - Update commit message
>>     - Add i.MX6SL
>>     - Update example
>> ---
>>  .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>> index 876015a44a1e6..1f17be501749b 100644
>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>> @@ -52,6 +52,9 @@ properties:
>>    interrupts:
>>      maxItems: 1
>>
>> +  power-domains:
>> +    maxItems: 1
>> +
> 
> This conflicts with adding 'power-domains' for i.MX8MP in my tree.

Yes, this is a duplicated patch.

Please either check for already submitted works in lore (dfn:) or use
linux-next as your base...

Unack.

Best regards,
Krzysztof
Marek Vasut Dec. 13, 2022, 1:04 p.m. UTC | #4 
On 12/13/22 08:57, Krzysztof Kozlowski wrote:
> On 12/12/2022 13:54, Rob Herring wrote:
>> On Sun, Dec 11, 2022 at 11:51 PM Marek Vasut <marex@denx.de> wrote:
>>>
>>> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus
>>> and i.MX6SX, i.MX6SL. Document the property and mark it as required
>>> on the aforementioned variants of the IP, present in those SoCs.
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> ---
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>> Cc: Liu Ying <victor.liu@nxp.com>
>>> Cc: Lucas Stach <l.stach@pengutronix.de>
>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>> Cc: linux-arm-kernel@lists.infradead.org
>>> To: devicetree@vger.kernel.org
>>> ---
>>> V2: - Add AB from Krzysztof
>>>      - Add mx6sx power domain into the list
>>> V3: - Update commit message
>>>      - Add i.MX6SL
>>>      - Update example
>>> ---
>>>   .../devicetree/bindings/display/fsl,lcdif.yaml  | 17 +++++++++++++++++
>>>   1 file changed, 17 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> index 876015a44a1e6..1f17be501749b 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> @@ -52,6 +52,9 @@ properties:
>>>     interrupts:
>>>       maxItems: 1
>>>
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>
>> This conflicts with adding 'power-domains' for i.MX8MP in my tree.
> 
> Yes, this is a duplicated patch.
> 
> Please either check for already submitted works in lore (dfn:) or use
> linux-next as your base...

Understood, I only used linux-next 20221208 , which was the latest 
available at that point.

If I rebase on today's next-20221213 , I see the only duplicate part is

"
+  power-domains:
+    maxItems: 1
+
"

The rest of this patch is still valid.

> Unack.

I see
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 876015a44a1e6..1f17be501749b 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -52,6 +52,9 @@  properties:
   interrupts:
     maxItems: 1
 
+  power-domains:
+    maxItems: 1
+
   port:
     $ref: /schemas/graph.yaml#/properties/port
     description: The LCDIF output port
@@ -87,6 +90,19 @@  allOf:
           maxItems: 1
         clock-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6sl-lcdif
+              - fsl,imx6sx-lcdif
+              - fsl,imx8mm-lcdif
+              - fsl,imx8mn-lcdif
+              - fsl,imx8mp-lcdif
+    then:
+      required:
+        - power-domains
 
 examples:
   - |
@@ -101,6 +117,7 @@  examples:
                  <&clks IMX6SX_CLK_LCDIF_APB>,
                  <&clks IMX6SX_CLK_DISPLAY_AXI>;
         clock-names = "pix", "axi", "disp_axi";
+        power-domains = <&pd_disp>;
 
         port {
             endpoint {