| Message ID | 20221124102745.2620370-2-sarath.babu.naidu.gaddam@amd.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Xilinx DMA enhancements and optimization | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On 24/11/2022 11:27, Sarath Babu Naidu Gaddam wrote: > From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > > Add an optional AXI DMA property 'xlnx,axistream-connected'. This > can be specified to indicate that DMA is connected to a streaming IP > in the hardware design and dma driver needs to do some additional > handling i.e pass metadata and perform streaming IP specific > configuration. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > Signed-off-by: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com> > --- > Changes in V2: > 1) Moved xlnx,axistream-connected optional property to under AXI DMA. > 2) Removed Acked-by: Rob Herring. > --- You already add two properties here. Convert to DT schema and then add. Best regards, Krzysztof
On Sat, Nov 26, 2022 at 03:32:23PM +0100, Krzysztof Kozlowski wrote: > On 24/11/2022 11:27, Sarath Babu Naidu Gaddam wrote: > > From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > > > > Add an optional AXI DMA property 'xlnx,axistream-connected'. This > > can be specified to indicate that DMA is connected to a streaming IP > > in the hardware design and dma driver needs to do some additional > > handling i.e pass metadata and perform streaming IP specific > > configuration. > > > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > > Signed-off-by: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com> > > --- > > Changes in V2: > > 1) Moved xlnx,axistream-connected optional property to under AXI DMA. > > 2) Removed Acked-by: Rob Herring. > > --- > > You already add two properties here. Convert to DT schema and then add. That would be better, but I did ack it before. Though that was a year and half ago... Rob
On Thu, 24 Nov 2022 15:57:40 +0530, Sarath Babu Naidu Gaddam wrote: > From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > > Add an optional AXI DMA property 'xlnx,axistream-connected'. This > can be specified to indicate that DMA is connected to a streaming IP > in the hardware design and dma driver needs to do some additional > handling i.e pass metadata and perform streaming IP specific > configuration. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > Signed-off-by: Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@amd.com> > --- > Changes in V2: > 1) Moved xlnx,axistream-connected optional property to under AXI DMA. > 2) Removed Acked-by: Rob Herring. > --- > Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index d1700a5c36bf..fea5b09a439d 100644 --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt @@ -49,6 +49,10 @@ Optional properties for AXI DMA and MCDMA: register as configured in h/w. Takes values {8...26}. If the property is missing or invalid then the default value 23 is used. This is the maximum value that is supported by all IP versions. + +Optional properties for AXI DMA: +- xlnx,axistream-connected: Tells whether DMA is connected to AXI stream IP. + Optional properties for VDMA: - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. It takes following values: