| Message ID | 20221102222543.153026-1-marex@denx.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Am Mittwoch, 2. November 2022, 23:25:43 CET schrieb Marek Vasut: > The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain > the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since > the fallback compatible is what the driver matches on, this way: > compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr" > The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used > only that single compatible string. > > Document both options in the binding document. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Anson Huang <Anson.Huang@nxp.com> > Cc: Fabio Estevam <festevam@denx.de> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Oleksij Rempel <linux@rempel-privat.de> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > .../devicetree/bindings/nvmem/snvs-lpgpr.yaml | 20 +++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml > b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml index > e374aa7891ae7..ec20e33d9b8f8 100644 > --- a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml > +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml > @@ -11,14 +11,18 @@ maintainers: > > properties: > compatible: > - enum: > - - fsl,imx6q-snvs-lpgpr > - - fsl,imx6ul-snvs-lpgpr > - - fsl,imx7d-snvs-lpgpr > - - fsl,imx8mm-snvs-lpgpr > - - fsl,imx8mn-snvs-lpgpr > - - fsl,imx8mp-snvs-lpgpr > - - fsl,imx8mq-snvs-lpgpr > + oneOf: > + - items: > + - enum: > + - fsl,imx8mm-snvs-lpgpr > + - fsl,imx8mn-snvs-lpgpr > + - fsl,imx8mp-snvs-lpgpr > + - fsl,imx8mq-snvs-lpgpr > + - const: fsl,imx7d-snvs-lpgpr > + - enum: > + - fsl,imx6q-snvs-lpgpr > + - fsl,imx6ul-snvs-lpgpr > + - fsl,imx7d-snvs-lpgpr > > required: > - compatible Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
On 02/11/2022 18:25, Marek Vasut wrote: > The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain > the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since > the fallback compatible is what the driver matches on, this way: > compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr" > The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used > only that single compatible string. > > Document both options in the binding document. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, Nov 02, 2022 at 11:25:43PM +0100, Marek Vasut wrote: > The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain > the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since > the fallback compatible is what the driver matches on, this way: > compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr" > The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used > only that single compatible string. > > Document both options in the binding document. > > Signed-off-by: Marek Vasut <marex@denx.de> Applied, thanks!
diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml index e374aa7891ae7..ec20e33d9b8f8 100644 --- a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml @@ -11,14 +11,18 @@ maintainers: properties: compatible: - enum: - - fsl,imx6q-snvs-lpgpr - - fsl,imx6ul-snvs-lpgpr - - fsl,imx7d-snvs-lpgpr - - fsl,imx8mm-snvs-lpgpr - - fsl,imx8mn-snvs-lpgpr - - fsl,imx8mp-snvs-lpgpr - - fsl,imx8mq-snvs-lpgpr + oneOf: + - items: + - enum: + - fsl,imx8mm-snvs-lpgpr + - fsl,imx8mn-snvs-lpgpr + - fsl,imx8mp-snvs-lpgpr + - fsl,imx8mq-snvs-lpgpr + - const: fsl,imx7d-snvs-lpgpr + - enum: + - fsl,imx6q-snvs-lpgpr + - fsl,imx6ul-snvs-lpgpr + - fsl,imx7d-snvs-lpgpr required: - compatible
The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since the fallback compatible is what the driver matches on, this way: compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr" The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used only that single compatible string. Document both options in the binding document. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Anson Huang <Anson.Huang@nxp.com> Cc: Fabio Estevam <festevam@denx.de> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Oleksij Rempel <linux@rempel-privat.de> Cc: Peng Fan <peng.fan@nxp.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- .../devicetree/bindings/nvmem/snvs-lpgpr.yaml | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)