| Message ID | 20221031204804.195267-1-marex@denx.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] dt-bindings: net: broadcom-bluetooth: Add CYW4373A0 DT binding | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Oct 31, 2022 at 9:48 PM Marek Vasut <marex@denx.de> wrote: > CYW4373A0 is a Wi-Fi + Bluetooth combo device from Cypress. > This chip is present e.g. on muRata 2AE module. Extend the > binding with its DT compatible. > > Signed-off-by: Marek Vasut <marex@denx.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, Oct 31, 2022 at 9:48 PM Marek Vasut <marex@denx.de> wrote: > CYW4373A0 is a Wi-Fi + Bluetooth combo device from Cypress. > This chip is present e.g. on muRata 2AE module. > > This chip has additional quirk where the HCI command 0xfc45, used on > older chips to switch UART clock from 24 MHz to 48 MHz, to support > baudrates over 3 Mbdps, is no longer recognized by this newer chip. > This newer chip can configure the 4 Mbdps baudrate without the need > to issue HCI command 0xfc45, so add flag to indicate this and do not > issue the command on this chip to avoid failure to set 4 Mbdps baud > rate. > > It is not clear whether there is a way to determine which chip does > and which chip does not support the HCI command 0xfc45, other than > trial and error. > > Signed-off-by: Marek Vasut <marex@denx.de> (...) > +static struct bcm_device_data bcm4373a0_device_data = { > + .no_uart_clock_set = true, > +}; Shouldn't this be named cyw4373a0_device_data like the compatible string and the device below it? With that fixed: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Hi Linus, On Tue, Nov 1, 2022 at 3:30 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Oct 31, 2022 at 9:48 PM Marek Vasut <marex@denx.de> wrote: > > > CYW4373A0 is a Wi-Fi + Bluetooth combo device from Cypress. > > This chip is present e.g. on muRata 2AE module. Extend the > > binding with its DT compatible. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Should we have these changes in bluetooth-next or dt has a dedicated tree?
On Tue, Nov 01, 2022 at 03:39:21PM -0700, Luiz Augusto von Dentz wrote: > Hi Linus, > > On Tue, Nov 1, 2022 at 3:30 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Mon, Oct 31, 2022 at 9:48 PM Marek Vasut <marex@denx.de> wrote: > > > > > CYW4373A0 is a Wi-Fi + Bluetooth combo device from Cypress. > > > This chip is present e.g. on muRata 2AE module. Extend the > > > binding with its DT compatible. > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Should we have these changes in bluetooth-next or dt has a dedicated tree? Most of the time, they go thru the subsystem trees like bluetooth-next. Rob
On Mon, 31 Oct 2022 21:48:03 +0100, Marek Vasut wrote: > CYW4373A0 is a Wi-Fi + Bluetooth combo device from Cypress. > This chip is present e.g. on muRata 2AE module. Extend the > binding with its DT compatible. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Hakan Jansson <hakan.jansson@infineon.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > Cc: Marcel Holtmann <marcel@holtmann.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > To: linux-bluetooth@vger.kernel.org > --- > Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml index 445b2a5536259..e0c8abc274134 100644 --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml @@ -24,6 +24,7 @@ properties: - brcm,bcm43540-bt - brcm,bcm4335a0 - brcm,bcm4349-bt + - cypress,cyw4373a0-bt - infineon,cyw55572-bt shutdown-gpios:
CYW4373A0 is a Wi-Fi + Bluetooth combo device from Cypress. This chip is present e.g. on muRata 2AE module. Extend the binding with its DT compatible. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Hakan Jansson <hakan.jansson@infineon.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org To: linux-bluetooth@vger.kernel.org --- Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 + 1 file changed, 1 insertion(+)