diff mbox series

[5/5] dt-bindings: clock: Introduce pdc bindings for QDU1000 and QRU1000

Message ID 20221001030403.27659-6-quic_molvera@quicinc.com
State Changes Requested, archived
Headers show
Series clk: qcom: Add clocks for the QDU1000 and QRU1000 SoCs | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied fail build log
robh/checkpatch success
robh/patch-applied fail build log

Commit Message

Melody Olvera Oct. 1, 2022, 3:04 a.m. UTC
Add compatible fields for QDU1000 and QRU1000 pdcs.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml      | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Baryshkov Oct. 1, 2022, 6:58 a.m. UTC | #1
On Sat, 1 Oct 2022 at 06:04, Melody Olvera <quic_molvera@quicinc.com> wrote:
>
> Add compatible fields for QDU1000 and QRU1000 pdcs.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml      | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> index b6f56cf5fbe3..5c7b790db7e0 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> @@ -33,6 +33,8 @@ properties:
>            - qcom,sm8150-pdc
>            - qcom,sm8250-pdc
>            - qcom,sm8350-pdc
> +          - qcom,qdu1000-pdc
> +          - qcom,qru1000-pdc

Alphabetic sorting please. q comes before s.

>        - const: qcom,pdc
>
>    reg:
> --
> 2.37.3
>
Marc Zyngier Oct. 1, 2022, 9:22 a.m. UTC | #2
On 2022-10-01 04:04, Melody Olvera wrote:
> Add compatible fields for QDU1000 and QRU1000 pdcs.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml      | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> index b6f56cf5fbe3..5c7b790db7e0 100644
> --- 
> a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> +++ 
> b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> @@ -33,6 +33,8 @@ properties:
>            - qcom,sm8150-pdc
>            - qcom,sm8250-pdc
>            - qcom,sm8350-pdc
> +          - qcom,qdu1000-pdc
> +          - qcom,qru1000-pdc
>        - const: qcom,pdc
> 
>    reg:

Please fix the title of the commit, as this has little to do with 
clocks.

         M.
Melody Olvera Oct. 3, 2022, 7:46 p.m. UTC | #3
On 10/1/2022 1:58 AM, Dmitry Baryshkov wrote:
> On Sat, 1 Oct 2022 at 06:04, Melody Olvera <quic_molvera@quicinc.com> wrote:
>> Add compatible fields for QDU1000 and QRU1000 pdcs.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml      | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>> index b6f56cf5fbe3..5c7b790db7e0 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>> @@ -33,6 +33,8 @@ properties:
>>            - qcom,sm8150-pdc
>>            - qcom,sm8250-pdc
>>            - qcom,sm8350-pdc
>> +          - qcom,qdu1000-pdc
>> +          - qcom,qru1000-pdc
> Alphabetic sorting please. q comes before s.
Will do.
>
>>        - const: qcom,pdc
>>
>>    reg:
>> --
>> 2.37.3
>>
Thanks,

Melody
Melody Olvera Oct. 3, 2022, 7:47 p.m. UTC | #4
On 10/1/2022 4:22 AM, Marc Zyngier wrote:
> On 2022-10-01 04:04, Melody Olvera wrote:
>> Add compatible fields for QDU1000 and QRU1000 pdcs.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml      | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>> b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>> index b6f56cf5fbe3..5c7b790db7e0 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>> @@ -33,6 +33,8 @@ properties:
>>            - qcom,sm8150-pdc
>>            - qcom,sm8250-pdc
>>            - qcom,sm8350-pdc
>> +          - qcom,qdu1000-pdc
>> +          - qcom,qru1000-pdc
>>        - const: qcom,pdc
>>
>>    reg:
>
> Please fix the title of the commit, as this has little to do with clocks.

Will do.

>
>         M.

Thanks,

Melody
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
index b6f56cf5fbe3..5c7b790db7e0 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
@@ -33,6 +33,8 @@  properties:
           - qcom,sm8150-pdc
           - qcom,sm8250-pdc
           - qcom,sm8350-pdc
+          - qcom,qdu1000-pdc
+          - qcom,qru1000-pdc
       - const: qcom,pdc
 
   reg: