| Message ID | 20220705094239.17174-8-johan+linaro@kernel.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | phy: qcom,qmp: fix dt-bindings and deprecate lane suffix | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 05/07/2022 11:42, Johan Hovold wrote: > Drop the compatible conditional and tighten the property constraints. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Squash it with previous patch. Does not make sense to add new file and a patch later change it. Best regards, Krzysztof
On Tue, Jul 05, 2022 at 12:09:19PM +0200, Krzysztof Kozlowski wrote: > On 05/07/2022 11:42, Johan Hovold wrote: > > Drop the compatible conditional and tighten the property constraints. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > Squash it with previous patch. Does not make sense to add new file and a > patch later change it. I beg to differ, for the reasons I just spelled out in my previous reply. Johan
On 05/07/2022 12:21, Johan Hovold wrote: > On Tue, Jul 05, 2022 at 12:09:19PM +0200, Krzysztof Kozlowski wrote: >> On 05/07/2022 11:42, Johan Hovold wrote: >>> Drop the compatible conditional and tighten the property constraints. >>> >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >> >> Squash it with previous patch. Does not make sense to add new file and a >> patch later change it. > > I beg to differ, for the reasons I just spelled out in my previous > reply. So let's keep the discussion there. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml index 14fd86fd91ec..b73bf5c06358 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -19,10 +19,8 @@ properties: const: qcom,msm8996-qmp-pcie-phy reg: - minItems: 1 items: - description: Address and length of PHY's common serdes block. - - description: Address and length of PHY's DP_COM control block. "#address-cells": enum: [ 1, 2 ] @@ -33,20 +31,28 @@ properties: ranges: true clocks: - minItems: 1 - maxItems: 4 + items: + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. clock-names: - minItems: 1 - maxItems: 4 + items: + - const: aux + - const: cfg_ahb + - const: ref resets: - minItems: 1 - maxItems: 3 + items: + - description: Reset of PHY block. + - description: PHY common block reset. + - description: PHY's ahb cfg block reset. reset-names: - minItems: 1 - maxItems: 3 + items: + - const: phy + - const: common + - const: cfg vdda-phy-supply: description: @@ -56,10 +62,6 @@ properties: description: Phandle to 1.8V regulator supply to PHY refclk pll block. - vddp-ref-clk-supply: - description: - Phandle to a regulator supply to any specific refclk pll block. - patternProperties: "^phy@[0-9a-f]+$": type: object @@ -77,38 +79,7 @@ required: - clock-names - resets - reset-names + - vdda-phy-supply + - vdda-pll-supply additionalProperties: false - -allOf: - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8996-qmp-pcie-phy - then: - properties: - clocks: - items: - - description: PHY aux clock. - - description: PHY config clock. - - description: 19.2 MHz ref clock. - clock-names: - items: - - const: aux - - const: cfg_ahb - - const: ref - resets: - items: - - description: Reset of PHY block. - - description: PHY common block reset. - - description: PHY's ahb cfg block reset. - reset-names: - items: - - const: phy - - const: common - - const: cfg - required: - - vdda-phy-supply - - vdda-pll-supply
Drop the compatible conditional and tighten the property constraints. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 65 +++++-------------- 1 file changed, 18 insertions(+), 47 deletions(-)