| Message ID | 20220629141000.18111-2-johan+linaro@kernel.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | PCI: qcom: Add support for SC8280XP and SA8540P | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 8 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 29 June 2022 17:09:51 GMT+03:00, Johan Hovold <johan+linaro@kernel.org> wrote: >Fix the reset conditional which always evaluated to true due to a >misspelled property name ("compatibles" in plural). > >Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") >Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >--- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >index 7e84063afe25..ed9f9462a758 100644 >--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >@@ -615,7 +615,7 @@ allOf: > - if: > not: > properties: >- compatibles: >+ compatible: Argh. Thanks for noticing and fixing the typo. If necessary I can respin MSI series in a few days. Anyway, for this patch: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > contains: > enum: > - qcom,pcie-msm8996
On 29/06/2022 16:09, Johan Hovold wrote: > Fix the reset conditional which always evaluated to true due to a > misspelled property name ("compatibles" in plural). > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, Jun 29, 2022 at 04:09:51PM +0200, Johan Hovold wrote: > Fix the reset conditional which always evaluated to true due to a > misspelled property name ("compatibles" in plural). > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 7e84063afe25..ed9f9462a758 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -615,7 +615,7 @@ allOf: > - if: > not: > properties: > - compatibles: > + compatible: > contains: > enum: > - qcom,pcie-msm8996 > -- > 2.35.1 >
On Wed, Jun 29, 2022 at 04:09:51PM +0200, Johan Hovold wrote: > Fix the reset conditional which always evaluated to true due to a > misspelled property name ("compatibles" in plural). > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> I applied this patch to pci/ctrl/qcom-pending for v5.20, thanks! I'd like to see an ack from Stanimir (per get_maintainers.pl) for the rest. > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 7e84063afe25..ed9f9462a758 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -615,7 +615,7 @@ allOf: > - if: > not: > properties: > - compatibles: > + compatible: > contains: > enum: > - qcom,pcie-msm8996 > -- > 2.35.1 >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 7e84063afe25..ed9f9462a758 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -615,7 +615,7 @@ allOf: - if: not: properties: - compatibles: + compatible: contains: enum: - qcom,pcie-msm8996
Fix the reset conditional which always evaluated to true due to a misspelled property name ("compatibles" in plural). Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)