diff mbox series

[v3,1/4] dt-bindings: display: panel-common: allow for additional port node properties

Message ID 20220628181838.2031-2-max.oss.09@gmail.com
State Changes Requested, archived
Headers show
Series drm/panel: simple: add bus-format support for panel-dpi | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Max Krummenacher June 28, 2022, 6:18 p.m. UTC
From: Max Krummenacher <max.krummenacher@toradex.com>

Allow bindings which reference panel-common.yaml to add additional
properties under the port node.
I.e. 'panel-dpi' needs to add a new property to 'port/endpoint'.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

---

Changes in v3:
- New commit to allow for additional port node properties

 .../devicetree/bindings/display/panel/panel-common.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring (Arm) July 1, 2022, 5:08 p.m. UTC | #1
On Tue, Jun 28, 2022 at 08:18:35PM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Allow bindings which reference panel-common.yaml to add additional
> properties under the port node.
> I.e. 'panel-dpi' needs to add a new property to 'port/endpoint'.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> 
> ---
> 
> Changes in v3:
> - New commit to allow for additional port node properties
> 
>  .../devicetree/bindings/display/panel/panel-common.yaml         | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index 5b38dc89cb21..ff8dc07ef3b5 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -68,7 +68,7 @@ properties:
>  
>    # Connectivity
>    port:
> -    $ref: /schemas/graph.yaml#/properties/port
> +    $ref: /schemas/graph.yaml#/$defs/port-base

This will allow extra properties for everyone using this. That means 
either bus-format needs to go in here (so that it is the only extra 
property allowed) or we should remove 'port' here and push this into all 
the users.

But we should reach agreement on bus-format before doing anything.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
index 5b38dc89cb21..ff8dc07ef3b5 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
@@ -68,7 +68,7 @@  properties:
 
   # Connectivity
   port:
-    $ref: /schemas/graph.yaml#/properties/port
+    $ref: /schemas/graph.yaml#/$defs/port-base
 
   ddc-i2c-bus:
     $ref: /schemas/types.yaml#/definitions/phandle