| Message ID | 20220623162850.245608-4-sebastian.reichel@collabora.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | RK3588 Ethernet Support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 23/06/2022 18:28, Sebastian Reichel wrote: > Add compatible string for RK3588 gmac, which is similar to the RK3568 > one, but needs another syscon device for clock selection. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 + > 2 files changed, 7 insertions(+) Rebase on some new kernel tree, you use old Cc addresses. > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 083623c8d718..c42f5a74a92e 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -25,6 +25,7 @@ select: > - rockchip,rk3368-gmac > - rockchip,rk3399-gmac > - rockchip,rk3568-gmac > + - rockchip,rk3588-gmac > - rockchip,rv1108-gmac > required: > - compatible > @@ -50,6 +51,7 @@ properties: > - items: > - enum: > - rockchip,rk3568-gmac > + - rockchip,rk3588-gmac > - const: snps,dwmac-4.20a > > clocks: > @@ -81,6 +83,10 @@ properties: > description: The phandle of the syscon node for the general register file. > $ref: /schemas/types.yaml#/definitions/phandle > > + rockchip,php_grf: What does the "php" mean? No underscores in names, hyphens instead. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 083623c8d718..c42f5a74a92e 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -25,6 +25,7 @@ select: - rockchip,rk3368-gmac - rockchip,rk3399-gmac - rockchip,rk3568-gmac + - rockchip,rk3588-gmac - rockchip,rv1108-gmac required: - compatible @@ -50,6 +51,7 @@ properties: - items: - enum: - rockchip,rk3568-gmac + - rockchip,rk3588-gmac - const: snps,dwmac-4.20a clocks: @@ -81,6 +83,10 @@ properties: description: The phandle of the syscon node for the general register file. $ref: /schemas/types.yaml#/definitions/phandle + rockchip,php_grf: + description: The phandle of the syscon node for the peripheral general register file. + $ref: /schemas/types.yaml#/definitions/phandle + tx_delay: description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default. $ref: /schemas/types.yaml#/definitions/uint32 diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 36c85eb3dc0d..b5aba399ca5d 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -72,6 +72,7 @@ properties: - rockchip,rk3328-gmac - rockchip,rk3366-gmac - rockchip,rk3368-gmac + - rockchip,rk3588-gmac - rockchip,rk3399-gmac - rockchip,rv1108-gmac - snps,dwmac
Add compatible string for RK3588 gmac, which is similar to the RK3568 one, but needs another syscon device for clock selection. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 + 2 files changed, 7 insertions(+)