| Message ID | 20220408004412.663880-1-marex@denx.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2] dt-bindings: rcc: Add common clock properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Apr 08, 2022 at 02:44:12AM +0200, Marek Vasut wrote: > Add common properties appearing in DTSes (assigned-clocks and similar) > to fix dtbs_check warnings like: > > arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com> > Cc: Rob Herring <robh+dt@kernel.org> > To: devicetree@vger.kernel.org > Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com> > --- > V2: Add AB from Gabriel > --- > .../devicetree/bindings/clock/st,stm32mp1-rcc.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml > index a0ae4867ed27e..9bcf198bae170 100644 > --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml > +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml > @@ -62,6 +62,12 @@ properties: > reg: > maxItems: 1 > > + clocks: true How many and what are they? > + clock-names: true Needs exact names. > + assigned-clocks: true > + assigned-clock-parents: true > + assigned-clock-rates: true These are automatically added when 'clocks' is present. > + > required: > - "#clock-cells" > - "#reset-cells" > -- > 2.35.1 > >
On 4/8/22 23:21, Rob Herring wrote: > On Fri, Apr 08, 2022 at 02:44:12AM +0200, Marek Vasut wrote: >> Add common properties appearing in DTSes (assigned-clocks and similar) >> to fix dtbs_check warnings like: >> >> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> >> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com> >> Cc: Rob Herring <robh+dt@kernel.org> >> To: devicetree@vger.kernel.org >> Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com> >> --- >> V2: Add AB from Gabriel >> --- >> .../devicetree/bindings/clock/st,stm32mp1-rcc.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml >> index a0ae4867ed27e..9bcf198bae170 100644 >> --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml >> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml >> @@ -62,6 +62,12 @@ properties: >> reg: >> maxItems: 1 >> >> + clocks: true > > How many and what are they? 0 or 1 >> + clock-names: true > > Needs exact names. I'll send V3 soon.
diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml index a0ae4867ed27e..9bcf198bae170 100644 --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml @@ -62,6 +62,12 @@ properties: reg: maxItems: 1 + clocks: true + clock-names: true + assigned-clocks: true + assigned-clock-parents: true + assigned-clock-rates: true + required: - "#clock-cells" - "#reset-cells"