| Message ID | 20220323164442.921-2-jiaxin.yu@mediatek.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | ASoC: mediatek: mt8192: support rt1015p_rt5682s | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On Thu, Mar 24, 2022 at 12:44:39AM +0800, Jiaxin Yu wrote: > + speaker-codec: If it is possible to have 1 or more items, would "speaker-codecs" be a better name? > + type: object > + properties: > + sound-dai: > + minItems: 2 It should be 1. Consider of rt1015p case.
On Thu, 2022-03-24 at 08:54 +0800, Tzung-Bi Shih wrote: > On Thu, Mar 24, 2022 at 12:44:39AM +0800, Jiaxin Yu wrote: > > + speaker-codec: > > If it is possible to have 1 or more items, would "speaker-codecs" be > a better > name? Hi Tzung-Bi, Yes, it is better to use "speaker-codecs", I will change it that in driver patch and bindings patch. Jiaxin.Yu Thanks > > > + type: object > > + properties: > > + sound-dai: > > + minItems: 2 > > It should be 1. Consider of rt1015p case. Yes, I will correct it.
diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml index a781e7aaaa38..ad992342c883 100644 --- a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml @@ -18,6 +18,7 @@ properties: enum: - mediatek,mt8192_mt6359_rt1015_rt5682 - mediatek,mt8192_mt6359_rt1015p_rt5682 + - mediatek,mt8192_mt6359_rt1015p_rt5682s mediatek,platform: $ref: "/schemas/types.yaml#/definitions/phandle" @@ -27,11 +28,33 @@ properties: $ref: "/schemas/types.yaml#/definitions/phandle" description: The phandle of HDMI codec. + headset-codec: + type: object + properties: + sound-dai: + $ref: /schemas/types.yaml#/definitions/phandle + required: + - sound-dai + + speaker-codec: + type: object + properties: + sound-dai: + minItems: 2 + maxItems: 2 + items: + maxItems: 1 + $ref: /schemas/types.yaml#/definitions/phandle-array + required: + - sound-dai + additionalProperties: false required: - compatible - mediatek,platform + - headset-codec + - speaker-codec examples: - | @@ -44,6 +67,15 @@ examples: "aud_clk_mosi_on"; pinctrl-0 = <&aud_clk_mosi_off>; pinctrl-1 = <&aud_clk_mosi_on>; + + headset-codec { + sound-dai = <&rt5682>; + }; + + speaker-codec { + sound-dai = <&rt1015_l>, + <&rt1015_r>; + }; }; ...
1. Adds new compatible string "mt8192_mt6359_rt1015p_rt5682s" for machines with rt1015p and rt5682s. 2. Adds new property "headset-codec" for getting headset codec. 3. Adds new property "speaker-codec" for getting speaker codecs. Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com> --- .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+)