diff mbox series

[v2,1/2] dt-bindings: drm/bridge: anx7625: Revert DPI support

Message ID 20220308094911.2680291-2-robert.foss@linaro.org
State Not Applicable, archived
Headers show
Series Revert vendor property from anx7625 bindings | expand

Checks

Context Check Description
robh/patch-applied success
robh/checkpatch success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Robert Foss March 8, 2022, 9:49 a.m. UTC 
Revert DPI support from binding.

DPI support relies on the bus-type enum which does not yet support
Mipi DPI, since no v4l2_fwnode_bus_type has been defined for this
bus type.

When DPI for anx7625 was initially added, it assumed that
V4L2_FWNODE_BUS_TYPE_PARALLEL was the correct bus type for
representing DPI, which it is not.

In order to prevent adding this mis-usage to the ABI, let's revert
the support.

Signed-off-by: Robert Foss <robert.foss@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---

Changes since v1:
- Rob: Instead of reverting the entire commit introducing this,
       do a partial revert of only the relevant parts.

 .../display/bridge/analogix,anx7625.yaml      | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

Comments

Rob Herring March 8, 2022, 1:53 p.m. UTC | #1 
On Tue, Mar 8, 2022 at 3:49 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> Revert DPI support from binding.
>
> DPI support relies on the bus-type enum which does not yet support
> Mipi DPI, since no v4l2_fwnode_bus_type has been defined for this
> bus type.
>
> When DPI for anx7625 was initially added, it assumed that
> V4L2_FWNODE_BUS_TYPE_PARALLEL was the correct bus type for
> representing DPI, which it is not.
>
> In order to prevent adding this mis-usage to the ABI, let's revert
> the support.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Changes since v1:
> - Rob: Instead of reverting the entire commit introducing this,
>        do a partial revert of only the relevant parts.
>
>  .../display/bridge/analogix,anx7625.yaml      | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 1d3e88daca041..25b5ef3f759ca 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -91,22 +91,7 @@  properties:
         $ref: /schemas/graph.yaml#/$defs/port-base
         unevaluatedProperties: false
         description:
-          MIPI DSI/DPI input.
-
-        properties:
-          endpoint:
-            $ref: /schemas/media/video-interfaces.yaml#
-            type: object
-            additionalProperties: false
-
-            properties:
-              remote-endpoint: true
-
-              bus-type:
-                enum: [1, 5]
-                default: 1
-
-              data-lanes: true
+          Video port for MIPI DSI input.
 
       port@1:
         $ref: /schemas/graph.yaml#/properties/port
@@ -155,8 +140,6 @@  examples:
                     reg = <0>;
                     anx7625_in: endpoint {
                         remote-endpoint = <&mipi_dsi>;
-                        bus-type = <5>;
-                        data-lanes = <0 1 2 3>;
                     };
                 };