| Message ID | 20220307143421.1106209-4-andre.przywara@arm.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | ARM: suniv: dts: update Allwinner F1C100 | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success | |
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On Mon, 07 Mar 2022 14:34:10 +0000, Andre Przywara wrote: > The top level LicheePi Nano compatible name was never documented in the > bindings, so add the currently used string. > > It looks like the manufacturer might be "sipeed" as well, but I will go > with the "licheepi" string that is in the actual .dts for years now. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On 3/7/22 8:34 AM, Andre Przywara wrote: > The top level LicheePi Nano compatible name was never documented in the > bindings, so add the currently used string. > > It looks like the manufacturer might be "sipeed" as well, but I will go > with the "licheepi" string that is in the actual .dts for years now. From what I can tell, "Lichee Pi Nano" [1][2] is the original board, and the "Sipeed Lichee Nano" [3] is a newer batch by some of the same people [4]. Other than the silkscreen and the addition of the resistive touchscreen IC, the boards look identical. And in fact I was able to find an intermediate version of the schematic [5] that uses the old styling but includes the touchscreen IC. So this looks good to me. Reviewed-by: Samuel Holland <samuel@sholland.org> [1]: https://licheepizero.us/ [2]: http://nano.lichee.pro/ [3]: https://wiki.sipeed.com/hardware/en/lichee/Nano/Nano.html [4]: see e.g. http://bbs.lichee.pro/ [5]: https://github.com/hongxuyao/F1C100s_with_Keil_RTX4_emWin5/blob/spl-separated/doc/lichee-nano/lichee_nano-Schematic.pdf > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index c8a3102c0fde..a7e7b2e79616 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -391,6 +391,11 @@ properties: > - const: libretech,all-h5-cc-h5 > - const: allwinner,sun50i-h5 > > + - description: Lichee Pi Nano > + items: > + - const: licheepi,licheepi-nano > + - const: allwinner,suniv-f1c100s > + > - description: Lichee Pi One > items: > - const: licheepi,licheepi-one >
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index c8a3102c0fde..a7e7b2e79616 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -391,6 +391,11 @@ properties: - const: libretech,all-h5-cc-h5 - const: allwinner,sun50i-h5 + - description: Lichee Pi Nano + items: + - const: licheepi,licheepi-nano + - const: allwinner,suniv-f1c100s + - description: Lichee Pi One items: - const: licheepi,licheepi-one
The top level LicheePi Nano compatible name was never documented in the bindings, so add the currently used string. It looks like the manufacturer might be "sipeed" as well, but I will go with the "licheepi" string that is in the actual .dts for years now. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ 1 file changed, 5 insertions(+)