| Message ID | 20220121210340.32362-12-ansuelsmth@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Multiple addition and improvement to ipq8064 gcc | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
Quoting Ansuel Smith (2022-01-21 13:03:36) > Add ipq8064 ce5 clk define needed for CryptoEngine in gcc driver. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > include/dt-bindings/clock/qcom,gcc-ipq806x.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/clock/qcom,gcc-ipq806x.h b/include/dt-bindings/clock/qcom,gcc-ipq806x.h > index 7deec14a6dee..02262d2ac899 100644 > --- a/include/dt-bindings/clock/qcom,gcc-ipq806x.h > +++ b/include/dt-bindings/clock/qcom,gcc-ipq806x.h > @@ -240,7 +240,7 @@ > #define PLL14 232 > #define PLL14_VOTE 233 > #define PLL18 234 > -#define CE5_SRC 235 > +#define CE5_A_CLK 235 Technically this is ABI and changing it is bad. I see that CE5_SRC isn't used though so I guess it's OK. > #define CE5_H_CLK 236 > #define CE5_CORE_CLK 237 > #define CE3_SLEEP_CLK 238 > @@ -283,5 +283,8 @@ > #define EBI2_AON_CLK 281 > #define NSSTCM_CLK_SRC 282 > #define NSSTCM_CLK 283 > +#define CE5_A_CLK_SRC 285 > +#define CE5_H_CLK_SRC 286 > +#define CE5_CORE_CLK_SRC 287
On Tue, Jan 25, 2022 at 12:47:26PM -0800, Stephen Boyd wrote: > Quoting Ansuel Smith (2022-01-21 13:03:36) > > Add ipq8064 ce5 clk define needed for CryptoEngine in gcc driver. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > --- > > include/dt-bindings/clock/qcom,gcc-ipq806x.h | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/qcom,gcc-ipq806x.h b/include/dt-bindings/clock/qcom,gcc-ipq806x.h > > index 7deec14a6dee..02262d2ac899 100644 > > --- a/include/dt-bindings/clock/qcom,gcc-ipq806x.h > > +++ b/include/dt-bindings/clock/qcom,gcc-ipq806x.h > > @@ -240,7 +240,7 @@ > > #define PLL14 232 > > #define PLL14_VOTE 233 > > #define PLL18 234 > > -#define CE5_SRC 235 > > +#define CE5_A_CLK 235 > > Technically this is ABI and changing it is bad. I see that CE5_SRC isn't > used though so I guess it's OK. > Consider that this naming comes directly from qsdk so I really don't know why it was called SRC from the start. > > #define CE5_H_CLK 236 > > #define CE5_CORE_CLK 237 > > #define CE3_SLEEP_CLK 238 > > @@ -283,5 +283,8 @@ > > #define EBI2_AON_CLK 281 > > #define NSSTCM_CLK_SRC 282 > > #define NSSTCM_CLK 283 > > +#define CE5_A_CLK_SRC 285 > > +#define CE5_H_CLK_SRC 286 > > +#define CE5_CORE_CLK_SRC 287
diff --git a/include/dt-bindings/clock/qcom,gcc-ipq806x.h b/include/dt-bindings/clock/qcom,gcc-ipq806x.h index 7deec14a6dee..02262d2ac899 100644 --- a/include/dt-bindings/clock/qcom,gcc-ipq806x.h +++ b/include/dt-bindings/clock/qcom,gcc-ipq806x.h @@ -240,7 +240,7 @@ #define PLL14 232 #define PLL14_VOTE 233 #define PLL18 234 -#define CE5_SRC 235 +#define CE5_A_CLK 235 #define CE5_H_CLK 236 #define CE5_CORE_CLK 237 #define CE3_SLEEP_CLK 238 @@ -283,5 +283,8 @@ #define EBI2_AON_CLK 281 #define NSSTCM_CLK_SRC 282 #define NSSTCM_CLK 283 +#define CE5_A_CLK_SRC 285 +#define CE5_H_CLK_SRC 286 +#define CE5_CORE_CLK_SRC 287 #endif
Add ipq8064 ce5 clk define needed for CryptoEngine in gcc driver. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- include/dt-bindings/clock/qcom,gcc-ipq806x.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)